Re: [PATCH v1 1/4] dmi: Introduce dmi_get_bios_year() helper

On Tue, 2018-02-27 at 10:14 +0100, Jean Delvare wrote: > Hi Andy, > > On Thu, 22 Feb 2018 14:59:20 +0200, Andy Shevchenko wrote: > > It's used in several places and more users may come. > > By using this helper they may create a slightly cleaner code. > > In general I'm not a big fan of

Re: [PATCH v1 1/4] dmi: Introduce dmi_get_bios_year() helper

On Tue, 2018-02-27 at 10:14 +0100, Jean Delvare wrote: > Hi Andy, > > On Thu, 22 Feb 2018 14:59:20 +0200, Andy Shevchenko wrote: > > It's used in several places and more users may come. > > By using this helper they may create a slightly cleaner code. > > In general I'm not a big fan of

Re: [PATCH v1 1/4] dmi: Introduce dmi_get_bios_year() helper

On Mon, 2018-02-26 at 10:29 +0100, Rafael J. Wysocki wrote: > On Sun, Feb 25, 2018 at 2:23 PM, Andy Shevchenko > wrote: > > On Fri, 2018-02-23 at 15:35 -0600, Bjorn Helgaas wrote: > > > but making this inline looks similar to this, which > > > wasn't

Re: [PATCH v1 1/4] dmi: Introduce dmi_get_bios_year() helper

On Mon, 2018-02-26 at 10:29 +0100, Rafael J. Wysocki wrote: > On Sun, Feb 25, 2018 at 2:23 PM, Andy Shevchenko > wrote: > > On Fri, 2018-02-23 at 15:35 -0600, Bjorn Helgaas wrote: > > > but making this inline looks similar to this, which > > > wasn't well-received: > > > > > >

Re: [PATCH v1 1/4] dmi: Introduce dmi_get_bios_year() helper

Hi Andy, On Thu, 22 Feb 2018 14:59:20 +0200, Andy Shevchenko wrote: > It's used in several places and more users may come. > By using this helper they may create a slightly cleaner code. In general I'm not a big fan of arbitrary API shortcuts. I won't object if you think it's a good one to have,

Re: [PATCH v1 1/4] dmi: Introduce dmi_get_bios_year() helper

Hi Andy, On Thu, 22 Feb 2018 14:59:20 +0200, Andy Shevchenko wrote: > It's used in several places and more users may come. > By using this helper they may create a slightly cleaner code. In general I'm not a big fan of arbitrary API shortcuts. I won't object if you think it's a good one to have,

Re: [PATCH v1 1/4] dmi: Introduce dmi_get_bios_year() helper

On Sun, Feb 25, 2018 at 2:23 PM, Andy Shevchenko wrote: > On Fri, 2018-02-23 at 15:35 -0600, Bjorn Helgaas wrote: >> On Thu, Feb 22, 2018 at 02:59:20PM +0200, Andy Shevchenko wrote: >> > It's used in several places and more users may come. >> > By using this

Re: [PATCH v1 1/4] dmi: Introduce dmi_get_bios_year() helper

On Sun, Feb 25, 2018 at 2:23 PM, Andy Shevchenko wrote: > On Fri, 2018-02-23 at 15:35 -0600, Bjorn Helgaas wrote: >> On Thu, Feb 22, 2018 at 02:59:20PM +0200, Andy Shevchenko wrote: >> > It's used in several places and more users may come. >> > By using this helper they may create a slightly

Re: [PATCH v1 1/4] dmi: Introduce dmi_get_bios_year() helper

On Fri, 2018-02-23 at 15:35 -0600, Bjorn Helgaas wrote: > On Thu, Feb 22, 2018 at 02:59:20PM +0200, Andy Shevchenko wrote: > > It's used in several places and more users may come. > > By using this helper they may create a slightly cleaner code. > > > > Signed-off-by: Andy Shevchenko

Re: [PATCH v1 1/4] dmi: Introduce dmi_get_bios_year() helper

On Fri, 2018-02-23 at 15:35 -0600, Bjorn Helgaas wrote: > On Thu, Feb 22, 2018 at 02:59:20PM +0200, Andy Shevchenko wrote: > > It's used in several places and more users may come. > > By using this helper they may create a slightly cleaner code. > > > > Signed-off-by: Andy Shevchenko > > --- > >

Re: [PATCH v1 1/4] dmi: Introduce dmi_get_bios_year() helper

On Thu, Feb 22, 2018 at 02:59:20PM +0200, Andy Shevchenko wrote: > It's used in several places and more users may come. > By using this helper they may create a slightly cleaner code. > > Signed-off-by: Andy Shevchenko > --- > include/linux/dmi.h | 7 +++ >

Re: [PATCH v1 1/4] dmi: Introduce dmi_get_bios_year() helper

On Thu, Feb 22, 2018 at 02:59:20PM +0200, Andy Shevchenko wrote: > It's used in several places and more users may come. > By using this helper they may create a slightly cleaner code. > > Signed-off-by: Andy Shevchenko > --- > include/linux/dmi.h | 7 +++ > 1 file changed, 7 insertions(+) >