Re: [PATCH] Input: pxrc - fix leak of usb_device

2018-07-15 Thread Alexey Khoroshilov
Dear Marcus, On 15.07.2018 10:42, Marcus Folkesson wrote: > On Sat, Jul 14, 2018 at 08:51:09AM +, Dmitry Torokhov wrote: >> On Sat, Jul 14, 2018 at 10:09:20AM +0200, Marcus Folkesson wrote: >>> Hi Alexey, >>> >>> Good catch! >>> >>> On Fri, Jul 13, 2018 at 11:07:57PM +0300, Alexey Khoroshilov

Re: [PATCH] Input: pxrc - fix leak of usb_device

2018-07-15 Thread Alexey Khoroshilov
Dear Marcus, On 15.07.2018 10:42, Marcus Folkesson wrote: > On Sat, Jul 14, 2018 at 08:51:09AM +, Dmitry Torokhov wrote: >> On Sat, Jul 14, 2018 at 10:09:20AM +0200, Marcus Folkesson wrote: >>> Hi Alexey, >>> >>> Good catch! >>> >>> On Fri, Jul 13, 2018 at 11:07:57PM +0300, Alexey Khoroshilov

Re: [PATCH] Input: pxrc - fix leak of usb_device

2018-07-15 Thread Dmitry Torokhov
On Sun, Jul 15, 2018 at 12:12:44PM +0200, Greg Kroah-Hartman wrote: > On Sun, Jul 15, 2018 at 01:06:32PM +0300, Dmitry Torokhov wrote: > > On Sun, Jul 15, 2018 at 10:42 AM Marcus Folkesson > > wrote: > > > > > > On Sat, Jul 14, 2018 at 08:51:09AM +, Dmitry Torokhov wrote: > > > > On Sat, Jul

Re: [PATCH] Input: pxrc - fix leak of usb_device

2018-07-15 Thread Dmitry Torokhov
On Sun, Jul 15, 2018 at 12:12:44PM +0200, Greg Kroah-Hartman wrote: > On Sun, Jul 15, 2018 at 01:06:32PM +0300, Dmitry Torokhov wrote: > > On Sun, Jul 15, 2018 at 10:42 AM Marcus Folkesson > > wrote: > > > > > > On Sat, Jul 14, 2018 at 08:51:09AM +, Dmitry Torokhov wrote: > > > > On Sat, Jul

Re: [PATCH] Input: pxrc - fix leak of usb_device

2018-07-15 Thread Greg Kroah-Hartman
On Sun, Jul 15, 2018 at 01:06:32PM +0300, Dmitry Torokhov wrote: > On Sun, Jul 15, 2018 at 10:42 AM Marcus Folkesson > wrote: > > > > On Sat, Jul 14, 2018 at 08:51:09AM +, Dmitry Torokhov wrote: > > > On Sat, Jul 14, 2018 at 10:09:20AM +0200, Marcus Folkesson wrote: > > > > Hi Alexey, > > > >

Re: [PATCH] Input: pxrc - fix leak of usb_device

2018-07-15 Thread Greg Kroah-Hartman
On Sun, Jul 15, 2018 at 01:06:32PM +0300, Dmitry Torokhov wrote: > On Sun, Jul 15, 2018 at 10:42 AM Marcus Folkesson > wrote: > > > > On Sat, Jul 14, 2018 at 08:51:09AM +, Dmitry Torokhov wrote: > > > On Sat, Jul 14, 2018 at 10:09:20AM +0200, Marcus Folkesson wrote: > > > > Hi Alexey, > > > >

Re: [PATCH] Input: pxrc - fix leak of usb_device

2018-07-15 Thread Dmitry Torokhov
On Sun, Jul 15, 2018 at 10:42 AM Marcus Folkesson wrote: > > On Sat, Jul 14, 2018 at 08:51:09AM +, Dmitry Torokhov wrote: > > On Sat, Jul 14, 2018 at 10:09:20AM +0200, Marcus Folkesson wrote: > > > Hi Alexey, > > > > > > Good catch! > > > > > > On Fri, Jul 13, 2018 at 11:07:57PM +0300, Alexey

Re: [PATCH] Input: pxrc - fix leak of usb_device

2018-07-15 Thread Dmitry Torokhov
On Sun, Jul 15, 2018 at 10:42 AM Marcus Folkesson wrote: > > On Sat, Jul 14, 2018 at 08:51:09AM +, Dmitry Torokhov wrote: > > On Sat, Jul 14, 2018 at 10:09:20AM +0200, Marcus Folkesson wrote: > > > Hi Alexey, > > > > > > Good catch! > > > > > > On Fri, Jul 13, 2018 at 11:07:57PM +0300, Alexey

Re: [PATCH] Input: pxrc - fix leak of usb_device

2018-07-15 Thread Marcus Folkesson
On Sat, Jul 14, 2018 at 08:51:09AM +, Dmitry Torokhov wrote: > On Sat, Jul 14, 2018 at 10:09:20AM +0200, Marcus Folkesson wrote: > > Hi Alexey, > > > > Good catch! > > > > On Fri, Jul 13, 2018 at 11:07:57PM +0300, Alexey Khoroshilov wrote: > > > pxrc_probe() calls usb_get_dev(), but there is

Re: [PATCH] Input: pxrc - fix leak of usb_device

2018-07-15 Thread Marcus Folkesson
On Sat, Jul 14, 2018 at 08:51:09AM +, Dmitry Torokhov wrote: > On Sat, Jul 14, 2018 at 10:09:20AM +0200, Marcus Folkesson wrote: > > Hi Alexey, > > > > Good catch! > > > > On Fri, Jul 13, 2018 at 11:07:57PM +0300, Alexey Khoroshilov wrote: > > > pxrc_probe() calls usb_get_dev(), but there is

Re: [PATCH] Input: pxrc - fix leak of usb_device

2018-07-14 Thread Dmitry Torokhov
On Sat, Jul 14, 2018 at 10:09:20AM +0200, Marcus Folkesson wrote: > Hi Alexey, > > Good catch! > > On Fri, Jul 13, 2018 at 11:07:57PM +0300, Alexey Khoroshilov wrote: > > pxrc_probe() calls usb_get_dev(), but there is no usb_put_dev() > > anywhere in the driver. > > > > The patch adds one to

Re: [PATCH] Input: pxrc - fix leak of usb_device

2018-07-14 Thread Dmitry Torokhov
On Sat, Jul 14, 2018 at 10:09:20AM +0200, Marcus Folkesson wrote: > Hi Alexey, > > Good catch! > > On Fri, Jul 13, 2018 at 11:07:57PM +0300, Alexey Khoroshilov wrote: > > pxrc_probe() calls usb_get_dev(), but there is no usb_put_dev() > > anywhere in the driver. > > > > The patch adds one to

Re: [PATCH] Input: pxrc - fix leak of usb_device

2018-07-14 Thread Marcus Folkesson
Hi Alexey, Good catch! On Fri, Jul 13, 2018 at 11:07:57PM +0300, Alexey Khoroshilov wrote: > pxrc_probe() calls usb_get_dev(), but there is no usb_put_dev() > anywhere in the driver. > > The patch adds one to error handling code and to pxrc_disconnect(). > > Found by Linux Driver Verification

Re: [PATCH] Input: pxrc - fix leak of usb_device

2018-07-14 Thread Marcus Folkesson
Hi Alexey, Good catch! On Fri, Jul 13, 2018 at 11:07:57PM +0300, Alexey Khoroshilov wrote: > pxrc_probe() calls usb_get_dev(), but there is no usb_put_dev() > anywhere in the driver. > > The patch adds one to error handling code and to pxrc_disconnect(). > > Found by Linux Driver Verification

[PATCH] Input: pxrc - fix leak of usb_device

2018-07-13 Thread Alexey Khoroshilov
pxrc_probe() calls usb_get_dev(), but there is no usb_put_dev() anywhere in the driver. The patch adds one to error handling code and to pxrc_disconnect(). Found by Linux Driver Verification project (linuxtesting.org). Signed-off-by: Alexey Khoroshilov --- drivers/input/joystick/pxrc.c | 2 ++

[PATCH] Input: pxrc - fix leak of usb_device

2018-07-13 Thread Alexey Khoroshilov
pxrc_probe() calls usb_get_dev(), but there is no usb_put_dev() anywhere in the driver. The patch adds one to error handling code and to pxrc_disconnect(). Found by Linux Driver Verification project (linuxtesting.org). Signed-off-by: Alexey Khoroshilov --- drivers/input/joystick/pxrc.c | 2 ++