Re: [PATCH] PCI: rockchip: Support quirk to disable 5 GT/s (PCIe 2.x) link rate

2016-09-23 Thread Bjorn Helgaas
On Thu, Sep 22, 2016 at 10:31:18AM -0700, Brian Norris wrote: > rk3399 supports PCIe 2.x link speeds marginally at best, and on some > boards, the link won't train at 5 GT/s at all. Rather than sacrifice 500 > ms waiting for training that will never happen, let's support a device > tree quirk flag

Re: [PATCH] PCI: rockchip: Support quirk to disable 5 GT/s (PCIe 2.x) link rate

2016-09-23 Thread Bjorn Helgaas
On Thu, Sep 22, 2016 at 10:31:18AM -0700, Brian Norris wrote: > rk3399 supports PCIe 2.x link speeds marginally at best, and on some > boards, the link won't train at 5 GT/s at all. Rather than sacrifice 500 > ms waiting for training that will never happen, let's support a device > tree quirk flag

Re: [PATCH] PCI: rockchip: Support quirk to disable 5 GT/s (PCIe 2.x) link rate

2016-09-23 Thread Rob Herring
On Thu, Sep 22, 2016 at 10:31:18AM -0700, Brian Norris wrote: > rk3399 supports PCIe 2.x link speeds marginally at best, and on some > boards, the link won't train at 5 GT/s at all. Rather than sacrifice 500 > ms waiting for training that will never happen, let's support a device > tree quirk flag

Re: [PATCH] PCI: rockchip: Support quirk to disable 5 GT/s (PCIe 2.x) link rate

2016-09-23 Thread Rob Herring
On Thu, Sep 22, 2016 at 10:31:18AM -0700, Brian Norris wrote: > rk3399 supports PCIe 2.x link speeds marginally at best, and on some > boards, the link won't train at 5 GT/s at all. Rather than sacrifice 500 > ms waiting for training that will never happen, let's support a device > tree quirk flag

Re: [PATCH] PCI: rockchip: Support quirk to disable 5 GT/s (PCIe 2.x) link rate

2016-09-22 Thread Shawn Lin
Hi Brain, 在 2016/9/23 9:15, Brian Norris 写道: Hi Shawn, On Fri, Sep 23, 2016 at 08:27:35AM +0800, Shawn Lin wrote: 在 2016/9/23 1:31, Brian Norris 写道: rk3399 supports PCIe 2.x link speeds marginally at best, and on some boards, the link won't train at 5 GT/s at all. Rather than sacrifice 500

Re: [PATCH] PCI: rockchip: Support quirk to disable 5 GT/s (PCIe 2.x) link rate

2016-09-22 Thread Shawn Lin
Hi Brain, 在 2016/9/23 9:15, Brian Norris 写道: Hi Shawn, On Fri, Sep 23, 2016 at 08:27:35AM +0800, Shawn Lin wrote: 在 2016/9/23 1:31, Brian Norris 写道: rk3399 supports PCIe 2.x link speeds marginally at best, and on some boards, the link won't train at 5 GT/s at all. Rather than sacrifice 500

Re: [PATCH] PCI: rockchip: Support quirk to disable 5 GT/s (PCIe 2.x) link rate

2016-09-22 Thread Brian Norris
Hi Shawn, On Fri, Sep 23, 2016 at 08:27:35AM +0800, Shawn Lin wrote: > 在 2016/9/23 1:31, Brian Norris 写道: > >rk3399 supports PCIe 2.x link speeds marginally at best, and on some > >boards, the link won't train at 5 GT/s at all. Rather than sacrifice 500 > >ms waiting for training that will never

Re: [PATCH] PCI: rockchip: Support quirk to disable 5 GT/s (PCIe 2.x) link rate

2016-09-22 Thread Brian Norris
Hi Shawn, On Fri, Sep 23, 2016 at 08:27:35AM +0800, Shawn Lin wrote: > 在 2016/9/23 1:31, Brian Norris 写道: > >rk3399 supports PCIe 2.x link speeds marginally at best, and on some > >boards, the link won't train at 5 GT/s at all. Rather than sacrifice 500 > >ms waiting for training that will never

Re: [PATCH] PCI: rockchip: Support quirk to disable 5 GT/s (PCIe 2.x) link rate

2016-09-22 Thread Shawn Lin
Hi Brain, 在 2016/9/23 1:31, Brian Norris 写道: rk3399 supports PCIe 2.x link speeds marginally at best, and on some boards, the link won't train at 5 GT/s at all. Rather than sacrifice 500 ms waiting for training that will never happen, let's support a device tree quirk flag to disable generation

Re: [PATCH] PCI: rockchip: Support quirk to disable 5 GT/s (PCIe 2.x) link rate

2016-09-22 Thread Shawn Lin
Hi Brain, 在 2016/9/23 1:31, Brian Norris 写道: rk3399 supports PCIe 2.x link speeds marginally at best, and on some boards, the link won't train at 5 GT/s at all. Rather than sacrifice 500 ms waiting for training that will never happen, let's support a device tree quirk flag to disable generation

[PATCH] PCI: rockchip: Support quirk to disable 5 GT/s (PCIe 2.x) link rate

2016-09-22 Thread Brian Norris
rk3399 supports PCIe 2.x link speeds marginally at best, and on some boards, the link won't train at 5 GT/s at all. Rather than sacrifice 500 ms waiting for training that will never happen, let's support a device tree quirk flag to disable generation 2 speeds entirely. Signed-off-by: Brian Norris

[PATCH] PCI: rockchip: Support quirk to disable 5 GT/s (PCIe 2.x) link rate

2016-09-22 Thread Brian Norris
rk3399 supports PCIe 2.x link speeds marginally at best, and on some boards, the link won't train at 5 GT/s at all. Rather than sacrifice 500 ms waiting for training that will never happen, let's support a device tree quirk flag to disable generation 2 speeds entirely. Signed-off-by: Brian Norris