Re: [PATCH] arm64: dts: qcom: sc7180: Drop the unused non-MSA SID
Hi, On Tue, Jun 30, 2020 at 1:20 AM Sibi Sankar wrote: > > Having a non-MSA (Modem Self-Authentication) SID bypassed breaks modem > sandboxing i.e if a transaction were to originate from it, the hardware > memory protections units (XPUs) would fail to flag them (any transaction > originating from modem are historically termed as an MSA transaction). > Drop the unused non-MSA modem SID on SC7180 SoCs and cheza so that SMMU > continues to block them. > > Fixes: bec71ba243e95 ("arm64: dts: qcom: sc7180: Update Q6V5 MSS node") > Fixes: 68aee4af5f620 ("arm64: dts: qcom: sdm845-cheza: Add iommus property") > Cc: sta...@vger.kernel.org > Reported-by: Sai Prakash Ranjan > Signed-off-by: Sibi Sankar > --- > arch/arm64/boot/dts/qcom/sc7180-idp.dts| 2 +- > arch/arm64/boot/dts/qcom/sdm845-cheza.dtsi | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) I'm not sure if my review is worth all that much since it's not my area of expertise, but as far as I can tell this is good / ready to go in. I've confirmed that a similar on my sc7180 board doesn't seem to break anything for me so restricting things like this seems sane. Reviewed-by: Douglas Anderson Tested-by: Douglas Anderson -Doug
Re: [PATCH] arm64: dts: qcom: sc7180: Drop the unused non-MSA SID
On 2020-06-30 13:49, Sibi Sankar wrote: Having a non-MSA (Modem Self-Authentication) SID bypassed breaks modem sandboxing i.e if a transaction were to originate from it, the hardware memory protections units (XPUs) would fail to flag them (any transaction originating from modem are historically termed as an MSA transaction). Drop the unused non-MSA modem SID on SC7180 SoCs and cheza so that SMMU continues to block them. Fixes: bec71ba243e95 ("arm64: dts: qcom: sc7180: Update Q6V5 MSS node") Fixes: 68aee4af5f620 ("arm64: dts: qcom: sdm845-cheza: Add iommus property") Cc: sta...@vger.kernel.org Reported-by: Sai Prakash Ranjan Signed-off-by: Sibi Sankar --- arch/arm64/boot/dts/qcom/sc7180-idp.dts| 2 +- arch/arm64/boot/dts/qcom/sdm845-cheza.dtsi | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/sc7180-idp.dts b/arch/arm64/boot/dts/qcom/sc7180-idp.dts index 39dbfc89689e8..141de49a1b7d6 100644 --- a/arch/arm64/boot/dts/qcom/sc7180-idp.dts +++ b/arch/arm64/boot/dts/qcom/sc7180-idp.dts @@ -312,7 +312,7 @@ _id_1 { _mpss { status = "okay"; compatible = "qcom,sc7180-mss-pil"; - iommus = <_smmu 0x460 0x1>, <_smmu 0x444 0x3>; + iommus = <_smmu 0x461 0x0>, <_smmu 0x444 0x3>; memory-region = <_mem _mem>; }; diff --git a/arch/arm64/boot/dts/qcom/sdm845-cheza.dtsi b/arch/arm64/boot/dts/qcom/sdm845-cheza.dtsi index 70466cc4b4055..64fc1bfd66fad 100644 --- a/arch/arm64/boot/dts/qcom/sdm845-cheza.dtsi +++ b/arch/arm64/boot/dts/qcom/sdm845-cheza.dtsi @@ -634,7 +634,7 @@ _mdp { }; _pil { - iommus = <_smmu 0x780 0x1>, + iommus = <_smmu 0x781 0x0>, <_smmu 0x724 0x3>; }; Reviewed-by: Sai Prakash Ranjan -- QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation
[PATCH] arm64: dts: qcom: sc7180: Drop the unused non-MSA SID
Having a non-MSA (Modem Self-Authentication) SID bypassed breaks modem sandboxing i.e if a transaction were to originate from it, the hardware memory protections units (XPUs) would fail to flag them (any transaction originating from modem are historically termed as an MSA transaction). Drop the unused non-MSA modem SID on SC7180 SoCs and cheza so that SMMU continues to block them. Fixes: bec71ba243e95 ("arm64: dts: qcom: sc7180: Update Q6V5 MSS node") Fixes: 68aee4af5f620 ("arm64: dts: qcom: sdm845-cheza: Add iommus property") Cc: sta...@vger.kernel.org Reported-by: Sai Prakash Ranjan Signed-off-by: Sibi Sankar --- arch/arm64/boot/dts/qcom/sc7180-idp.dts| 2 +- arch/arm64/boot/dts/qcom/sdm845-cheza.dtsi | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/sc7180-idp.dts b/arch/arm64/boot/dts/qcom/sc7180-idp.dts index 39dbfc89689e8..141de49a1b7d6 100644 --- a/arch/arm64/boot/dts/qcom/sc7180-idp.dts +++ b/arch/arm64/boot/dts/qcom/sc7180-idp.dts @@ -312,7 +312,7 @@ _id_1 { _mpss { status = "okay"; compatible = "qcom,sc7180-mss-pil"; - iommus = <_smmu 0x460 0x1>, <_smmu 0x444 0x3>; + iommus = <_smmu 0x461 0x0>, <_smmu 0x444 0x3>; memory-region = <_mem _mem>; }; diff --git a/arch/arm64/boot/dts/qcom/sdm845-cheza.dtsi b/arch/arm64/boot/dts/qcom/sdm845-cheza.dtsi index 70466cc4b4055..64fc1bfd66fad 100644 --- a/arch/arm64/boot/dts/qcom/sdm845-cheza.dtsi +++ b/arch/arm64/boot/dts/qcom/sdm845-cheza.dtsi @@ -634,7 +634,7 @@ _mdp { }; _pil { - iommus = <_smmu 0x780 0x1>, + iommus = <_smmu 0x781 0x0>, <_smmu 0x724 0x3>; }; -- The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project