Re: [PATCH] block: makes bio_split support bio without data

2012-10-03 Thread Martin K. Petersen
> "Kent" == Kent Overstreet writes: Kent> I think we should be able to split REQ_DISCARD bios that have a Kent> payload or REQ_WRITE_SAME bios just fine though - for both of Kent> those cases, the payload doesn't correspond to a particular Kent> sector, so just copy the original bvec to the t

Re: [PATCH] block: makes bio_split support bio without data

2012-10-02 Thread Kent Overstreet
Adding Martin to the cc, so he can chime in on WRITE_SAME if I got it wrong On Wed, Oct 03, 2012 at 01:30:45PM +1000, NeilBrown wrote: > On Tue, 2 Oct 2012 14:09:23 -0700 Kent Overstreet > wrote: > > > On Tue, Oct 02, 2012 at 04:22:01PM +1000, NeilBrown wrote: > > > On Fri, 28 Sep 2012 09:23:43

Re: [PATCH] block: makes bio_split support bio without data

2012-10-02 Thread NeilBrown
On Tue, 2 Oct 2012 14:09:23 -0700 Kent Overstreet wrote: > On Tue, Oct 02, 2012 at 04:22:01PM +1000, NeilBrown wrote: > > On Fri, 28 Sep 2012 09:23:43 -0700 Kent Overstreet > > wrote: > > > > > On Mon, Sep 24, 2012 at 02:56:39PM +1000, NeilBrown wrote: > > > > > > > > Hi Jens, > > > > this pa

Re: [PATCH] block: makes bio_split support bio without data

2012-10-02 Thread Kent Overstreet
On Tue, Oct 02, 2012 at 04:22:01PM +1000, NeilBrown wrote: > On Fri, 28 Sep 2012 09:23:43 -0700 Kent Overstreet > wrote: > > > On Mon, Sep 24, 2012 at 02:56:39PM +1000, NeilBrown wrote: > > > > > > Hi Jens, > > > this patch has been sitting in my -next tree for a little while and I was > > > h

Re: [PATCH] block: makes bio_split support bio without data

2012-10-01 Thread NeilBrown
ecial cased in bio_advance() which makes things work out really > nicely). > > > Are you happy with it going in though my 'md' tree, or would you rather > > take > > it though your 'block' tree? > > > > Thanks, > > NeilBrown > > &g

Re: [PATCH] block: makes bio_split support bio without data

2012-09-28 Thread Kent Overstreet
t; NeilBrown > > > From: Shaohua Li > Date: Thu, 20 Sep 2012 09:36:03 +1000 > Subject: [PATCH] block: makes bio_split support bio without data > > discard bio hasn't data attached. We hit a BUG_ON with such bio. This makes > bio_split works for such bio. > &

Re: [PATCH] block: makes bio_split support bio without data

2012-09-28 Thread Jens Axboe
On 2012-09-28 09:36, Shaohua Li wrote: > On Tue, Sep 25, 2012 at 02:51:54PM +0200, Jens Axboe wrote: >> On 09/24/2012 06:56 AM, NeilBrown wrote: >>> >>> Hi Jens, >>> this patch has been sitting in my -next tree for a little while and I was >>> hoping for it to go in for the next merge window. >>>

Re: [PATCH] block: makes bio_split support bio without data

2012-09-28 Thread Shaohua Li
On Tue, Sep 25, 2012 at 02:51:54PM +0200, Jens Axboe wrote: > On 09/24/2012 06:56 AM, NeilBrown wrote: > > > > Hi Jens, > > this patch has been sitting in my -next tree for a little while and I was > > hoping for it to go in for the next merge window. > > It simply allows bio_split() to be used

Re: [PATCH] block: makes bio_split support bio without data

2012-09-25 Thread Jens Axboe
On 09/24/2012 06:56 AM, NeilBrown wrote: > > Hi Jens, > this patch has been sitting in my -next tree for a little while and I was > hoping for it to go in for the next merge window. > It simply allows bio_split() to be used on bios without a payload, such as > 'discard'. > Are you happy with

Re: [PATCH] block: makes bio_split support bio without data

2012-09-24 Thread NeilBrown
, > > NeilBrown > > > > > > From: Shaohua Li > > Date: Thu, 20 Sep 2012 09:36:03 +1000 > > Subject: [PATCH] block: makes bio_split support bio without data > > > > discard bio hasn't data attached. We hit a BUG_ON with such bio. This makes >

Re: [PATCH] block: makes bio_split support bio without data

2012-09-24 Thread Namhyung Kim
x27;discard'. > Are you happy with it going in though my 'md' tree, or would you rather take > it though your 'block' tree? > > Thanks, > NeilBrown > > > From: Shaohua Li > Date: Thu, 20 Sep 2012 09:36:03 +1000 > Subject: [PATCH] block: makes

[PATCH] block: makes bio_split support bio without data

2012-09-23 Thread NeilBrown
or would you rather take it though your 'block' tree? Thanks, NeilBrown From: Shaohua Li Date: Thu, 20 Sep 2012 09:36:03 +1000 Subject: [PATCH] block: makes bio_split support bio without data discard bio hasn't data attached. We hit a BUG_ON with such bio. This makes bio_split