Re: [PATCH] extcon: palmas: add support for using VBUSDET output

2015-11-20 Thread Chanwoo Choi
Hi, On Sat, Nov 21, 2015 at 12:05 AM, Chanwoo Choi wrote: > Hi Felipe, > > On Fri, Nov 20, 2015 at 11:37 PM, Felipe Balbi wrote: >> >> Hi Chanwoo, >> >> Chanwoo Choi writes: >>> Hi Felipe, >>> >>> On 2015년 11월 20일 14:33, Chanwoo Choi wrote: Hi Felipe, Looks good to me. But I

Re: [PATCH] extcon: palmas: add support for using VBUSDET output

2015-11-20 Thread Chanwoo Choi
Hi Felipe, On 2015. 11. 20. 오후 11:37, Felipe Balbi wrote: > > Hi Chanwoo, > > Chanwoo Choi writes: >> Hi Felipe, >> >> On 2015년 11월 20일 14:33, Chanwoo Choi wrote: >>> Hi Felipe, >>> >>> Looks good to me. But I have one comment. >>> >>> On 2015년 11월 13일 02:57, Felipe Balbi wrote: TPS659038

Re: [PATCH] extcon: palmas: add support for using VBUSDET output

2015-11-20 Thread Chanwoo Choi
Hi Felipe, On Fri, Nov 20, 2015 at 11:37 PM, Felipe Balbi wrote: > > Hi Chanwoo, > > Chanwoo Choi writes: >> Hi Felipe, >> >> On 2015년 11월 20일 14:33, Chanwoo Choi wrote: >>> Hi Felipe, >>> >>> Looks good to me. But I have one comment. >>> >>> On 2015년 11월 13일 02:57, Felipe Balbi wrote:

Re: [PATCH] extcon: palmas: add support for using VBUSDET output

2015-11-20 Thread Felipe Balbi
Hi Chanwoo, Chanwoo Choi writes: > Hi Felipe, > > On 2015년 11월 20일 14:33, Chanwoo Choi wrote: >> Hi Felipe, >> >> Looks good to me. But I have one comment. >> >> On 2015년 11월 13일 02:57, Felipe Balbi wrote: >>> TPS659038 can remux its GPIO_1 as VBUSDET output, >>> which can be tied to a SoC

Re: [PATCH] extcon: palmas: add support for using VBUSDET output

2015-11-20 Thread Chanwoo Choi
Hi Felipe, On Fri, Nov 20, 2015 at 11:37 PM, Felipe Balbi wrote: > > Hi Chanwoo, > > Chanwoo Choi writes: >> Hi Felipe, >> >> On 2015년 11월 20일 14:33, Chanwoo Choi wrote: >>> Hi Felipe, >>> >>> Looks good to me. But I have one comment. >>> >>> On 2015년 11월

Re: [PATCH] extcon: palmas: add support for using VBUSDET output

2015-11-20 Thread Felipe Balbi
Hi Chanwoo, Chanwoo Choi writes: > Hi Felipe, > > On 2015년 11월 20일 14:33, Chanwoo Choi wrote: >> Hi Felipe, >> >> Looks good to me. But I have one comment. >> >> On 2015년 11월 13일 02:57, Felipe Balbi wrote: >>> TPS659038 can remux its GPIO_1 as VBUSDET output, >>> which

Re: [PATCH] extcon: palmas: add support for using VBUSDET output

2015-11-20 Thread Chanwoo Choi
Hi Felipe, On 2015. 11. 20. 오후 11:37, Felipe Balbi wrote: > > Hi Chanwoo, > > Chanwoo Choi writes: >> Hi Felipe, >> >> On 2015년 11월 20일 14:33, Chanwoo Choi wrote: >>> Hi Felipe, >>> >>> Looks good to me. But I have one comment. >>> >>> On 2015년 11월 13일 02:57, Felipe

Re: [PATCH] extcon: palmas: add support for using VBUSDET output

2015-11-20 Thread Chanwoo Choi
Hi, On Sat, Nov 21, 2015 at 12:05 AM, Chanwoo Choi wrote: > Hi Felipe, > > On Fri, Nov 20, 2015 at 11:37 PM, Felipe Balbi wrote: >> >> Hi Chanwoo, >> >> Chanwoo Choi writes: >>> Hi Felipe, >>> >>> On 2015년 11월 20일 14:33, Chanwoo Choi

Re: [PATCH] extcon: palmas: add support for using VBUSDET output

2015-11-19 Thread Chanwoo Choi
Hi Felipe, On 2015년 11월 20일 14:33, Chanwoo Choi wrote: > Hi Felipe, > > Looks good to me. But I have one comment. > > On 2015년 11월 13일 02:57, Felipe Balbi wrote: >> TPS659038 can remux its GPIO_1 as VBUSDET output, >> which can be tied to a SoC GPIO and used as a VBUS >> interrupt. >> >> Beagle

Re: [PATCH] extcon: palmas: add support for using VBUSDET output

2015-11-19 Thread Chanwoo Choi
Hi Felipe, Looks good to me. But I have one comment. On 2015년 11월 13일 02:57, Felipe Balbi wrote: > TPS659038 can remux its GPIO_1 as VBUSDET output, > which can be tied to a SoC GPIO and used as a VBUS > interrupt. > > Beagle X15 uses that, in fact, and without it, I > could not get USB

Re: [PATCH] extcon: palmas: add support for using VBUSDET output

2015-11-19 Thread Chanwoo Choi
Hi Felipe, Looks good to me. But I have one comment. On 2015년 11월 13일 02:57, Felipe Balbi wrote: > TPS659038 can remux its GPIO_1 as VBUSDET output, > which can be tied to a SoC GPIO and used as a VBUS > interrupt. > > Beagle X15 uses that, in fact, and without it, I > could not get USB

Re: [PATCH] extcon: palmas: add support for using VBUSDET output

2015-11-19 Thread Chanwoo Choi
Hi Felipe, On 2015년 11월 20일 14:33, Chanwoo Choi wrote: > Hi Felipe, > > Looks good to me. But I have one comment. > > On 2015년 11월 13일 02:57, Felipe Balbi wrote: >> TPS659038 can remux its GPIO_1 as VBUSDET output, >> which can be tied to a SoC GPIO and used as a VBUS >> interrupt. >> >> Beagle

[PATCH] extcon: palmas: add support for using VBUSDET output

2015-11-12 Thread Felipe Balbi
TPS659038 can remux its GPIO_1 as VBUSDET output, which can be tied to a SoC GPIO and used as a VBUS interrupt. Beagle X15 uses that, in fact, and without it, I could not get USB peripheral working with that board. Signed-off-by: Felipe Balbi --- drivers/extcon/extcon-palmas.c | 22

[PATCH] extcon: palmas: add support for using VBUSDET output

2015-11-12 Thread Felipe Balbi
TPS659038 can remux its GPIO_1 as VBUSDET output, which can be tied to a SoC GPIO and used as a VBUS interrupt. Beagle X15 uses that, in fact, and without it, I could not get USB peripheral working with that board. Signed-off-by: Felipe Balbi --- drivers/extcon/extcon-palmas.c |