Re: [PATCH] fs/dax: Fix pmd vs pte conflict detection

2019-10-21 Thread Dan Williams
On Mon, Oct 21, 2019 at 5:07 AM Jeff Moyer wrote: > > Dan Williams writes: > > > Check for NULL entries before checking the entry order, otherwise NULL > > is misinterpreted as a present pte conflict. The 'order' check needs to > > happen before the locked check as an unlocked entry at the wrong

Re: [PATCH] fs/dax: Fix pmd vs pte conflict detection

2019-10-21 Thread Jeff Moyer
Dan Williams writes: > Check for NULL entries before checking the entry order, otherwise NULL > is misinterpreted as a present pte conflict. The 'order' check needs to > happen before the locked check as an unlocked entry at the wrong order > must fallback to lookup the correct order. Please

Re: [PATCH] fs/dax: Fix pmd vs pte conflict detection

2019-10-21 Thread Jan Kara
On Sat 19-10-19 09:26:19, Dan Williams wrote: > Check for NULL entries before checking the entry order, otherwise NULL > is misinterpreted as a present pte conflict. The 'order' check needs to > happen before the locked check as an unlocked entry at the wrong order > must fallback to lookup the

Re: [PATCH] fs/dax: Fix pmd vs pte conflict detection

2019-10-19 Thread Dan Williams
On Sat, Oct 19, 2019 at 4:09 PM Dan Williams wrote: > > On Sat, Oct 19, 2019 at 1:50 PM Matthew Wilcox wrote: > > > > On Sat, Oct 19, 2019 at 09:26:19AM -0700, Dan Williams wrote: > > > Check for NULL entries before checking the entry order, otherwise NULL > > > is misinterpreted as a present

Re: [PATCH] fs/dax: Fix pmd vs pte conflict detection

2019-10-19 Thread Dan Williams
On Sat, Oct 19, 2019 at 1:50 PM Matthew Wilcox wrote: > > On Sat, Oct 19, 2019 at 09:26:19AM -0700, Dan Williams wrote: > > Check for NULL entries before checking the entry order, otherwise NULL > > is misinterpreted as a present pte conflict. The 'order' check needs to > > happen before the

Re: [PATCH] fs/dax: Fix pmd vs pte conflict detection

2019-10-19 Thread Matthew Wilcox
On Sat, Oct 19, 2019 at 09:26:19AM -0700, Dan Williams wrote: > Check for NULL entries before checking the entry order, otherwise NULL > is misinterpreted as a present pte conflict. The 'order' check needs to > happen before the locked check as an unlocked entry at the wrong order > must fallback

[PATCH] fs/dax: Fix pmd vs pte conflict detection

2019-10-19 Thread Dan Williams
Check for NULL entries before checking the entry order, otherwise NULL is misinterpreted as a present pte conflict. The 'order' check needs to happen before the locked check as an unlocked entry at the wrong order must fallback to lookup the correct order. Reported-by: Jeff Smits Reported-by: