Re: [PATCH] gpio-tz1090: fix error handling of irq_of_parse_and_map

2014-11-27 Thread Linus Walleij
On Fri, Nov 14, 2014 at 10:32 PM, Dmitry Torokhov wrote: > irq_of_parse_and_map() returns 0 on error, so testing for negative > result never works. > > Signed-off-by: Dmitry Torokhov Patch applied with James' ACK. Yours, Linus Walleij -- To unsubscribe from this list: send the line

Re: [PATCH] gpio-tz1090: fix error handling of irq_of_parse_and_map

2014-11-27 Thread Linus Walleij
On Fri, Nov 14, 2014 at 10:32 PM, Dmitry Torokhov d...@chromium.org wrote: irq_of_parse_and_map() returns 0 on error, so testing for negative result never works. Signed-off-by: Dmitry Torokhov d...@chromium.org Patch applied with James' ACK. Yours, Linus Walleij -- To unsubscribe from this

Re: [PATCH] gpio-tz1090: fix error handling of irq_of_parse_and_map

2014-11-14 Thread Dmitry Torokhov
On Friday, November 14, 2014 11:53:07 PM James Hogan wrote: > On Fri, Nov 14, 2014 at 01:32:56PM -0800, Dmitry Torokhov wrote: > > irq_of_parse_and_map() returns 0 on error, so testing for negative > > result never works. > > > > Signed-off-by: Dmitry Torokhov > > Good catch, thanks! > >

Re: [PATCH] gpio-tz1090: fix error handling of irq_of_parse_and_map

2014-11-14 Thread James Hogan
On Fri, Nov 14, 2014 at 01:32:56PM -0800, Dmitry Torokhov wrote: > irq_of_parse_and_map() returns 0 on error, so testing for negative > result never works. > > Signed-off-by: Dmitry Torokhov Good catch, thanks! Acked-by: James Hogan A quick coccinelle script shows up numerous other cases of

[PATCH] gpio-tz1090: fix error handling of irq_of_parse_and_map

2014-11-14 Thread Dmitry Torokhov
irq_of_parse_and_map() returns 0 on error, so testing for negative result never works. Signed-off-by: Dmitry Torokhov --- Not tested, found by casual inspection of the code. drivers/gpio/gpio-tz1090.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH] gpio-tz1090: fix error handling of irq_of_parse_and_map

2014-11-14 Thread Dmitry Torokhov
irq_of_parse_and_map() returns 0 on error, so testing for negative result never works. Signed-off-by: Dmitry Torokhov d...@chromium.org --- Not tested, found by casual inspection of the code. drivers/gpio/gpio-tz1090.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [PATCH] gpio-tz1090: fix error handling of irq_of_parse_and_map

2014-11-14 Thread James Hogan
On Fri, Nov 14, 2014 at 01:32:56PM -0800, Dmitry Torokhov wrote: irq_of_parse_and_map() returns 0 on error, so testing for negative result never works. Signed-off-by: Dmitry Torokhov d...@chromium.org Good catch, thanks! Acked-by: James Hogan james.ho...@imgtec.com A quick coccinelle

Re: [PATCH] gpio-tz1090: fix error handling of irq_of_parse_and_map

2014-11-14 Thread Dmitry Torokhov
On Friday, November 14, 2014 11:53:07 PM James Hogan wrote: On Fri, Nov 14, 2014 at 01:32:56PM -0800, Dmitry Torokhov wrote: irq_of_parse_and_map() returns 0 on error, so testing for negative result never works. Signed-off-by: Dmitry Torokhov d...@chromium.org Good catch, thanks!