Re: [PATCH] lib/genalloc.c: rename addr_in_gen_pool to gen_pool_has_addr

2018-12-28 Thread Andrew Morton
On Fri, 28 Dec 2018 09:48:34 +0100 Christoph Hellwig wrote: > On Fri, Dec 28, 2018 at 04:39:50PM +0800, Huang Shijie wrote: > > Follow the kernel conventions, rename addr_in_gen_pool to > > gen_pool_has_addr. > > Which convention? That symbols from subsystem foo should be called foo_*. Not

Re: [PATCH] lib/genalloc.c: rename addr_in_gen_pool to gen_pool_has_addr

2018-12-28 Thread Huang Shijie
On Fri, Dec 28, 2018 at 09:48:34AM +0100, Christoph Hellwig wrote: > On Fri, Dec 28, 2018 at 04:39:50PM +0800, Huang Shijie wrote: > > Follow the kernel conventions, rename addr_in_gen_pool to > > gen_pool_has_addr. > > Which convention? The old name certainly looks more sensible to me. I

Re: [PATCH] lib/genalloc.c: rename addr_in_gen_pool to gen_pool_has_addr

2018-12-28 Thread Christoph Hellwig
On Fri, Dec 28, 2018 at 04:39:50PM +0800, Huang Shijie wrote: > Follow the kernel conventions, rename addr_in_gen_pool to > gen_pool_has_addr. Which convention? The old name certainly looks more sensible to me. If we really want to change anything about this function I'd suggest to drop the

[PATCH] lib/genalloc.c: rename addr_in_gen_pool to gen_pool_has_addr

2018-12-28 Thread Huang Shijie
Follow the kernel conventions, rename addr_in_gen_pool to gen_pool_has_addr. Signed-off-by: Huang Shijie --- arch/arm/mm/dma-mapping.c | 2 +- drivers/misc/sram-exec.c | 2 +- include/linux/genalloc.h | 2 +- kernel/dma/remap.c| 2 +- lib/genalloc.c| 6 +++--- 5 files