Re: [PATCH] mm: migrate: Return false instead of -EAGAIN for dummy functions

2016-09-25 Thread Chen Gang
Firstly, excuse me for replying late -- since I also agree, this patch is not urgent ;-) On 9/21/16 16:11, Michal Hocko wrote: > On Wed 21-09-16 06:06:44, Chen Gang wrote: >> On 9/20/16 16:09, Michal Hocko wrote: > [...] > > skipping the large part of the email because I do not have a spare tim

Re: [PATCH] mm: migrate: Return false instead of -EAGAIN for dummy functions

2016-09-21 Thread Michal Hocko
On Wed 21-09-16 06:06:44, Chen Gang wrote: > On 9/20/16 16:09, Michal Hocko wrote: [...] skipping the large part of the email because I do not have a spare time to discuss this. > > So what is the point of this whole exercise? Do not take me wrong, this > > area could see some improvements but I

Re: [PATCH] mm: migrate: Return false instead of -EAGAIN for dummy functions

2016-09-21 Thread Vlastimil Babka
On 09/21/2016 10:11 AM, Michal Hocko wrote: On Wed 21-09-16 06:06:44, Chen Gang wrote: On 9/20/16 16:09, Michal Hocko wrote: [...] skipping the large part of the email because I do not have a spare time to discuss this. So what is the point of this whole exercise? Do not take me wrong, this

Re: [PATCH] mm: migrate: Return false instead of -EAGAIN for dummy functions

2016-09-20 Thread Chen Gang
On 9/20/16 16:09, Michal Hocko wrote: > On Tue 20-09-16 05:46:58, Chen Gang wrote: >> >> For me, it really need return false: >> >> - For real implementation, when do nothing, it will return false. >> >> - I assume that the input page already is in a node (although maybe my >>assumption incor

Re: [PATCH] mm: migrate: Return false instead of -EAGAIN for dummy functions

2016-09-20 Thread Michal Hocko
On Tue 20-09-16 05:46:58, Chen Gang wrote: > On 9/17/16 23:46, Michal Hocko wrote: > > On Sat 17-09-16 15:20:36, cheng...@emindsoft.com.cn wrote: > > > >> Also change their related pure Boolean function numamigrate_isolate_page. > > > > this is not true. Just look at the current usage > > > >

Re: [PATCH] mm: migrate: Return false instead of -EAGAIN for dummy functions

2016-09-19 Thread Chen Gang
On 9/17/16 23:46, Michal Hocko wrote: > On Sat 17-09-16 15:20:36, cheng...@emindsoft.com.cn wrote: > >> Also change their related pure Boolean function numamigrate_isolate_page. > > this is not true. Just look at the current usage > > migrated = migrate_misplaced_page(page, vma, target_nid

Re: [PATCH] mm: migrate: Return false instead of -EAGAIN for dummy functions

2016-09-17 Thread Michal Hocko
On Sat 17-09-16 15:20:36, cheng...@emindsoft.com.cn wrote: > From: Chen Gang > > For migrate_misplaced_page and migrate_misplaced_transhuge_page, they > are pure Boolean functions and are also used as pure Boolean functions, > but the related dummy functions return -EAGAIN. I agree that their re

[PATCH] mm: migrate: Return false instead of -EAGAIN for dummy functions

2016-09-17 Thread chengang
From: Chen Gang For migrate_misplaced_page and migrate_misplaced_transhuge_page, they are pure Boolean functions and are also used as pure Boolean functions, but the related dummy functions return -EAGAIN. Also change their related pure Boolean function numamigrate_isolate_page. For variable is