Re: [PATCH] mmc: wmt-sdmmc: fix unmatched release_mem_region

2014-11-25 Thread lautriv
On 11/24/2014 09:34 AM, Ulf Hansson wrote: > On 20 November 2014 at 15:45, lautriv wrote: >> From b0509e27e33326e6dccd67d8ebe67e2bdb0cfdde Mon Sep 17 00:00:00 2001 >> From: Helmut Stengele >> Date: Thu, 20 Nov 2014 15:27:40 +0100 >> Subject: [PATCH] mm

Re: [PATCH] mmc: wmt-sdmmc: fix unmatched release_mem_region

2014-11-25 Thread lautriv
On 11/24/2014 09:34 AM, Ulf Hansson wrote: On 20 November 2014 at 15:45, lautriv laut...@coldplug.net wrote: From b0509e27e33326e6dccd67d8ebe67e2bdb0cfdde Mon Sep 17 00:00:00 2001 From: Helmut Stengele laut...@coldplug.net Date: Thu, 20 Nov 2014 15:27:40 +0100 Subject: [PATCH] mmc: wmt-sdmmc

Re: [PATCH] mmc: wmt-sdmmc: fix unmatched release_mem_region

2014-11-24 Thread Ulf Hansson
On 20 November 2014 at 15:45, lautriv wrote: > From b0509e27e33326e6dccd67d8ebe67e2bdb0cfdde Mon Sep 17 00:00:00 2001 > From: Helmut Stengele > Date: Thu, 20 Nov 2014 15:27:40 +0100 > Subject: [PATCH] mmc: wmt-sdmmc: fix unmatched release_mem_region > > Current code calls relea

Re: [PATCH] mmc: wmt-sdmmc: fix unmatched release_mem_region

2014-11-24 Thread Ulf Hansson
On 20 November 2014 at 15:45, lautriv laut...@coldplug.net wrote: From b0509e27e33326e6dccd67d8ebe67e2bdb0cfdde Mon Sep 17 00:00:00 2001 From: Helmut Stengele laut...@coldplug.net Date: Thu, 20 Nov 2014 15:27:40 +0100 Subject: [PATCH] mmc: wmt-sdmmc: fix unmatched release_mem_region Current

Re: [PATCH] mmc: wmt-sdmmc: fix unmatched release_mem_region

2014-11-20 Thread lautriv
From b0509e27e33326e6dccd67d8ebe67e2bdb0cfdde Mon Sep 17 00:00:00 2001 From: Helmut Stengele Date: Thu, 20 Nov 2014 15:27:40 +0100 Subject: [PATCH] mmc: wmt-sdmmc: fix unmatched release_mem_region Current code calls release_mem_region upon module unload without requesting the region first

Re: [PATCH] mmc: wmt-sdmmc: fix unmatched release_mem_region

2014-11-20 Thread lautriv
From b0509e27e33326e6dccd67d8ebe67e2bdb0cfdde Mon Sep 17 00:00:00 2001 From: Helmut Stengele laut...@coldplug.net Date: Thu, 20 Nov 2014 15:27:40 +0100 Subject: [PATCH] mmc: wmt-sdmmc: fix unmatched release_mem_region Current code calls release_mem_region upon module unload without requesting

Re: [PATCH] mmc: wmt-sdmmc: fix unmatched release_mem_region

2014-11-10 Thread lautriv
On 11/10/2014 06:15 AM, Alexey Charkov wrote: 2014-11-10 1:18 GMT+03:00 lautriv : On 11/09/2014 10:55 PM, Fabio Estevam wrote: On Sun, Nov 9, 2014 at 7:12 PM, Alexey Charkov wrote: + res = platform_get_resource(pdev, IORESOURCE_MEM, 0); + if (!res) { + ret =

Re: [PATCH] mmc: wmt-sdmmc: fix unmatched release_mem_region

2014-11-10 Thread lautriv
On 11/10/2014 06:15 AM, Alexey Charkov wrote: 2014-11-10 1:18 GMT+03:00 lautriv laut...@coldplug.net: On 11/09/2014 10:55 PM, Fabio Estevam wrote: On Sun, Nov 9, 2014 at 7:12 PM, Alexey Charkov alch...@gmail.com wrote: + res = platform_get_resource(pdev, IORESOURCE_MEM, 0); + if

Re: [PATCH] mmc: wmt-sdmmc: fix unmatched release_mem_region

2014-11-09 Thread Alexey Charkov
2014-11-10 1:18 GMT+03:00 lautriv : > On 11/09/2014 10:55 PM, Fabio Estevam wrote: >> >> On Sun, Nov 9, 2014 at 7:12 PM, Alexey Charkov wrote: >> >>> + res = platform_get_resource(pdev, IORESOURCE_MEM, 0); >>> + if (!res) { >>> + ret = -ENODEV; >>> + goto

Re: [PATCH] mmc: wmt-sdmmc: fix unmatched release_mem_region

2014-11-09 Thread lautriv
On 11/09/2014 10:55 PM, Fabio Estevam wrote: On Sun, Nov 9, 2014 at 7:12 PM, Alexey Charkov wrote: + res = platform_get_resource(pdev, IORESOURCE_MEM, 0); + if (!res) { + ret = -ENODEV; + goto fail1; You could save this NULL check... + }

Re: [PATCH] mmc: wmt-sdmmc: fix unmatched release_mem_region

2014-11-09 Thread Fabio Estevam
On Sun, Nov 9, 2014 at 7:12 PM, Alexey Charkov wrote: > + res = platform_get_resource(pdev, IORESOURCE_MEM, 0); > + if (!res) { > + ret = -ENODEV; > + goto fail1; You could save this NULL check... > + } > mmc = mmc_alloc_host(sizeof(struct

[PATCH] mmc: wmt-sdmmc: fix unmatched release_mem_region

2014-11-09 Thread Alexey Charkov
From: Helmut Stengele Current code calls release_mem_region upon module unload without requesting the region first. This patch fixes it by moving to a devres-based ioremap implementation, which handles requesting and releasing memory region internally. This also makes the error/unload paths a

[PATCH] mmc: wmt-sdmmc: fix unmatched release_mem_region

2014-11-09 Thread Alexey Charkov
From: Helmut Stengele laut...@coldplug.net Current code calls release_mem_region upon module unload without requesting the region first. This patch fixes it by moving to a devres-based ioremap implementation, which handles requesting and releasing memory region internally. This also makes the

Re: [PATCH] mmc: wmt-sdmmc: fix unmatched release_mem_region

2014-11-09 Thread Fabio Estevam
On Sun, Nov 9, 2014 at 7:12 PM, Alexey Charkov alch...@gmail.com wrote: + res = platform_get_resource(pdev, IORESOURCE_MEM, 0); + if (!res) { + ret = -ENODEV; + goto fail1; You could save this NULL check... + } mmc =

Re: [PATCH] mmc: wmt-sdmmc: fix unmatched release_mem_region

2014-11-09 Thread lautriv
On 11/09/2014 10:55 PM, Fabio Estevam wrote: On Sun, Nov 9, 2014 at 7:12 PM, Alexey Charkov alch...@gmail.com wrote: + res = platform_get_resource(pdev, IORESOURCE_MEM, 0); + if (!res) { + ret = -ENODEV; + goto fail1; You could save this NULL check...

Re: [PATCH] mmc: wmt-sdmmc: fix unmatched release_mem_region

2014-11-09 Thread Alexey Charkov
2014-11-10 1:18 GMT+03:00 lautriv laut...@coldplug.net: On 11/09/2014 10:55 PM, Fabio Estevam wrote: On Sun, Nov 9, 2014 at 7:12 PM, Alexey Charkov alch...@gmail.com wrote: + res = platform_get_resource(pdev, IORESOURCE_MEM, 0); + if (!res) { + ret = -ENODEV; +