"Peer Chen" <[EMAIL PROTECTED]> writes:
> Eric,
> Any decision for this patch, if not, currently we prefer to add all our
> code to quirks.c.
Sorry. I think adding the code to quirks.c is fine.
For bisection and code inspection purposes I would prefer the code
to come as a patchset of two
Peer Chen [EMAIL PROTECTED] writes:
Eric,
Any decision for this patch, if not, currently we prefer to add all our
code to quirks.c.
Sorry. I think adding the code to quirks.c is fine.
For bisection and code inspection purposes I would prefer the code
to come as a patchset of two patches.
Currid
Subject: Re: [PATCH] msi: set 'En' bit of MSI Mapping Capability
"Peer Chen" <[EMAIL PROTECTED]> writes:
> I feel it's dangerous to set the En bit on Intel platform, If the HT
MSI
> En is set, the MSI should be expected to transform to HT INT message
> format. It
Currid
Subject: Re: [PATCH] msi: set 'En' bit of MSI Mapping Capability
Peer Chen [EMAIL PROTECTED] writes:
I feel it's dangerous to set the En bit on Intel platform, If the HT
MSI
En is set, the MSI should be expected to transform to HT INT message
format. It may cause interrupt lost or hardware
'En' bit of MSI Mapping Capability
"Peer Chen" <[EMAIL PROTECTED]> writes:
> I feel it's dangerous to set the En bit on Intel platform, If the HT
MSI
> En is set, the MSI should be expected to transform to HT INT message
> format. It may cause interrupt lost or hardwa
'En' bit of MSI Mapping Capability
Peer Chen [EMAIL PROTECTED] writes:
I feel it's dangerous to set the En bit on Intel platform, If the HT
MSI
En is set, the MSI should be expected to transform to HT INT message
format. It may cause interrupt lost or hardware internal state machine
failed
"Peer Chen" <[EMAIL PROTECTED]> writes:
> I feel it's dangerous to set the En bit on Intel platform, If the HT MSI
> En is set, the MSI should be expected to transform to HT INT message
> format. It may cause interrupt lost or hardware internal state machine
> failed depend on the hardware
: Eric W. Biederman [mailto:[EMAIL PROTECTED]
Sent: Friday, December 21, 2007 6:48 AM
To: Peer Chen
Cc: peerchen; linux-kernel; akpm; Andy Currid
Subject: Re: [PATCH] msi: set 'En' bit of MSI Mapping Capability
"Peer Chen" <[EMAIL PROTECTED]> writes:
> The quirk is for our
: Eric W. Biederman [mailto:[EMAIL PROTECTED]
Sent: Friday, December 21, 2007 6:48 AM
To: Peer Chen
Cc: peerchen; linux-kernel; akpm; Andy Currid
Subject: Re: [PATCH] msi: set 'En' bit of MSI Mapping Capability
Peer Chen [EMAIL PROTECTED] writes:
The quirk is for our Intel platform, we don't
Peer Chen [EMAIL PROTECTED] writes:
I feel it's dangerous to set the En bit on Intel platform, If the HT MSI
En is set, the MSI should be expected to transform to HT INT message
format. It may cause interrupt lost or hardware internal state machine
failed depend on the hardware design.
Andrew Morton <[EMAIL PROTECTED]> writes:
> On Wed, 19 Dec 2007 16:41:25 -0800
> Andrew Morton <[EMAIL PROTECTED]> wrote:
>
>> It would be better to just add a stub implementation of
>> ht_enable_msi_mapping() for all the other architectures - avoid fancy cpp
>> tricks.
>
>
> And by this I really
"Peer Chen" <[EMAIL PROTECTED]> writes:
> The quirk is for our Intel platform, we don't want HT MSI mapping
> enabled in any of our devices.
Why is this a problem? I seem to recall a real hypertransport bus
downstream of the Intel cpu.
If there is a real hypertransport bus in the middle then
Subject: Re: [PATCH] msi: set 'En' bit of MSI Mapping Capability
"peerchen" <[EMAIL PROTECTED]> writes:
> According to the HyperTransport spec, 'En' indicate if the MSI Mapping
is
> active.
> Set the 'En' bit when setup pci and add the quirk for some nvidia
devices.
>
Subject: Re: [PATCH] msi: set 'En' bit of MSI Mapping Capability
peerchen [EMAIL PROTECTED] writes:
According to the HyperTransport spec, 'En' indicate if the MSI Mapping
is
active.
Set the 'En' bit when setup pci and add the quirk for some nvidia
devices.
The patch base on kernel 2.6.24-rc5
Ok
Peer Chen [EMAIL PROTECTED] writes:
The quirk is for our Intel platform, we don't want HT MSI mapping
enabled in any of our devices.
Why is this a problem? I seem to recall a real hypertransport bus
downstream of the Intel cpu.
If there is a real hypertransport bus in the middle then what
Andrew Morton [EMAIL PROTECTED] writes:
On Wed, 19 Dec 2007 16:41:25 -0800
Andrew Morton [EMAIL PROTECTED] wrote:
It would be better to just add a stub implementation of
ht_enable_msi_mapping() for all the other architectures - avoid fancy cpp
tricks.
And by this I really do mean going
On Wed, 19 Dec 2007 16:41:25 -0800
Andrew Morton <[EMAIL PROTECTED]> wrote:
> It would be better to just add a stub implementation of
> ht_enable_msi_mapping() for all the other architectures - avoid fancy cpp
> tricks.
And by this I really do mean going into each include/asm-*/pci.h and adding
On Tue, 18 Dec 2007 23:00:52 +0800
"peerchen" <[EMAIL PROTECTED]> wrote:
> According to the HyperTransport spec, 'En' indicate if the MSI Mapping is
> active.
> Set the 'En' bit when setup pci and add the quirk for some nvidia devices.
>
> The patch base on kernel 2.6.24-rc5
>
>
On Tue, 18 Dec 2007 23:00:52 +0800
peerchen [EMAIL PROTECTED] wrote:
According to the HyperTransport spec, 'En' indicate if the MSI Mapping is
active.
Set the 'En' bit when setup pci and add the quirk for some nvidia devices.
The patch base on kernel 2.6.24-rc5
Signed-off-by: Andy
On Wed, 19 Dec 2007 16:41:25 -0800
Andrew Morton [EMAIL PROTECTED] wrote:
It would be better to just add a stub implementation of
ht_enable_msi_mapping() for all the other architectures - avoid fancy cpp
tricks.
And by this I really do mean going into each include/asm-*/pci.h and adding
"peerchen" <[EMAIL PROTECTED]> writes:
> According to the HyperTransport spec, 'En' indicate if the MSI Mapping is
> active.
> Set the 'En' bit when setup pci and add the quirk for some nvidia devices.
>
> The patch base on kernel 2.6.24-rc5
Ok. This is starting to look good.
> Signed-off-by:
According to the HyperTransport spec, 'En' indicate if the MSI Mapping is
active.
Set the 'En' bit when setup pci and add the quirk for some nvidia devices.
The patch base on kernel 2.6.24-rc5
Signed-off-by: Andy Currid <[EMAIL PROTECTED]>
Signed-off-by: Peer Chen <[EMAIL PROTECTED]>
---
diff
According to the HyperTransport spec, 'En' indicate if the MSI Mapping is
active.
Set the 'En' bit when setup pci and add the quirk for some nvidia devices.
The patch base on kernel 2.6.24-rc5
Signed-off-by: Andy Currid [EMAIL PROTECTED]
Signed-off-by: Peer Chen [EMAIL PROTECTED]
---
diff
peerchen [EMAIL PROTECTED] writes:
According to the HyperTransport spec, 'En' indicate if the MSI Mapping is
active.
Set the 'En' bit when setup pci and add the quirk for some nvidia devices.
The patch base on kernel 2.6.24-rc5
Ok. This is starting to look good.
Signed-off-by: Andy
24 matches
Mail list logo