Re: [PATCH] openrisc: irq: use irqchip framework

2014-05-20 Thread Stefan Kristiansson
On Tue, May 20, 2014 at 08:45:44AM +0200, Jonas Bonn wrote: > On 05/19/2014 09:54 PM, Stefan Kristiansson wrote: > > On Mon, May 19, 2014 at 04:44:57PM +0200, Jonas Bonn wrote: > > > >> ii) Put a Depends on CONFIG_ARCH_OPENRISC in the Kconfig > > > > Hmm, do we really need that? > > The irqchip

Re: [PATCH] openrisc: irq: use irqchip framework

2014-05-20 Thread Jonas Bonn
On 05/19/2014 09:54 PM, Stefan Kristiansson wrote: > On Mon, May 19, 2014 at 04:44:57PM +0200, Jonas Bonn wrote: > >> ii) Put a Depends on CONFIG_ARCH_OPENRISC in the Kconfig > > Hmm, do we really need that? > The irqchip driver will picked by 'select'ing it from arch/openrisc/Kconfig > So, it

Re: [PATCH] openrisc: irq: use irqchip framework

2014-05-20 Thread Jonas Bonn
On 05/19/2014 09:54 PM, Stefan Kristiansson wrote: On Mon, May 19, 2014 at 04:44:57PM +0200, Jonas Bonn wrote: ii) Put a Depends on CONFIG_ARCH_OPENRISC in the Kconfig Hmm, do we really need that? The irqchip driver will picked by 'select'ing it from arch/openrisc/Kconfig So, it won't

Re: [PATCH] openrisc: irq: use irqchip framework

2014-05-20 Thread Stefan Kristiansson
On Tue, May 20, 2014 at 08:45:44AM +0200, Jonas Bonn wrote: On 05/19/2014 09:54 PM, Stefan Kristiansson wrote: On Mon, May 19, 2014 at 04:44:57PM +0200, Jonas Bonn wrote: ii) Put a Depends on CONFIG_ARCH_OPENRISC in the Kconfig Hmm, do we really need that? The irqchip driver will

Re: [PATCH] openrisc: irq: use irqchip framework

2014-05-19 Thread Stefan Kristiansson
On Mon, May 19, 2014 at 04:44:57PM +0200, Jonas Bonn wrote: > This looks good. Let's complete the the cleanup of this driver while > we're at it: > > i) Move this file to drivers/irqchip/ Sure, that sounds like a good idea. > ii) Put a Depends on CONFIG_ARCH_OPENRISC in the Kconfig Hmm, do we

Re: [PATCH] openrisc: irq: use irqchip framework

2014-05-19 Thread Jonas Bonn
Hi Stefan, This looks good. Let's complete the the cleanup of this driver while we're at it: i) Move this file to drivers/irqchip/ ii) Put a Depends on CONFIG_ARCH_OPENRISC in the Kconfig iii) Provide documentation for the binding at Documentation/devicetree/bindings/interrupt-controller/ Copy

[PATCH] openrisc: irq: use irqchip framework

2014-05-19 Thread Stefan Kristiansson
In addition to consolidating the or1k-pic initialization with how other interrupt controllers are initialized, this makes OpenRISC less tied to its on-cpu interrupt controller. Signed-off-by: Stefan Kristiansson --- arch/openrisc/kernel/irq.c | 17 + 1 file changed, 9

[PATCH] openrisc: irq: use irqchip framework

2014-05-19 Thread Stefan Kristiansson
In addition to consolidating the or1k-pic initialization with how other interrupt controllers are initialized, this makes OpenRISC less tied to its on-cpu interrupt controller. Signed-off-by: Stefan Kristiansson stefan.kristians...@saunalahti.fi --- arch/openrisc/kernel/irq.c | 17

Re: [PATCH] openrisc: irq: use irqchip framework

2014-05-19 Thread Jonas Bonn
Hi Stefan, This looks good. Let's complete the the cleanup of this driver while we're at it: i) Move this file to drivers/irqchip/ ii) Put a Depends on CONFIG_ARCH_OPENRISC in the Kconfig iii) Provide documentation for the binding at Documentation/devicetree/bindings/interrupt-controller/ Copy

Re: [PATCH] openrisc: irq: use irqchip framework

2014-05-19 Thread Stefan Kristiansson
On Mon, May 19, 2014 at 04:44:57PM +0200, Jonas Bonn wrote: This looks good. Let's complete the the cleanup of this driver while we're at it: i) Move this file to drivers/irqchip/ Sure, that sounds like a good idea. ii) Put a Depends on CONFIG_ARCH_OPENRISC in the Kconfig Hmm, do we