On Tue, Jan 29, 2019 at 09:48:51AM +0100, Arnaldo Carvalho de Melo wrote:
> Em Mon, Jan 28, 2019 at 09:00:37AM -0800, Andi Kleen escreveu:
> > > > also now it won't make sample for slave events
> > > > with zero value/period read
> > > >
> > > > note the patch needs to be split into more patches,
Em Mon, Jan 28, 2019 at 09:00:37AM -0800, Andi Kleen escreveu:
> > > also now it won't make sample for slave events
> > > with zero value/period read
> > >
> > > note the patch needs to be split into more patches,
> > > sending it all together for discussion over the solution
> >
> > any
> > also now it won't make sample for slave events
> > with zero value/period read
> >
> > note the patch needs to be split into more patches,
> > sending it all together for discussion over the solution
>
> any feedback on this one?
Looks good to me.
Reviewed-by: Andi Kleen
-Andi
On Sat, Jan 19, 2019 at 04:37:45PM +0100, Jiri Olsa wrote:
> On Fri, Jan 18, 2019 at 08:11:42AM -0800, Andi Kleen wrote:
> > > +static bool perf_evsel__should_skip(struct perf_evsel *evsel)
> > > +{
> > > + struct perf_event_attr *attr = >attr;
> > > + struct perf_evsel *leader = evsel->leader;
>
On Fri, Jan 18, 2019 at 08:11:42AM -0800, Andi Kleen wrote:
> > +static bool perf_evsel__should_skip(struct perf_evsel *evsel)
> > +{
> > + struct perf_event_attr *attr = >attr;
> > + struct perf_evsel *leader = evsel->leader;
> > +
> > + return (leader != evsel) && !attr->freq &&
On Fri, Jan 18, 2019 at 08:11:42AM -0800, Andi Kleen wrote:
> > +static bool perf_evsel__should_skip(struct perf_evsel *evsel)
> > +{
> > + struct perf_event_attr *attr = >attr;
> > + struct perf_evsel *leader = evsel->leader;
> > +
> > + return (leader != evsel) && !attr->freq &&
> +static bool perf_evsel__should_skip(struct perf_evsel *evsel)
> +{
> + struct perf_event_attr *attr = >attr;
> + struct perf_evsel *leader = evsel->leader;
> +
> + return (leader != evsel) && !attr->freq && !attr->sample_freq;
> +}
> +
> static int process_sample_event(struct
On Fri, Jan 18, 2019 at 10:42:05AM -0300, Arnaldo Carvalho de Melo wrote:
> Em Fri, Jan 18, 2019 at 10:01:06AM -0300, Arnaldo Carvalho de Melo escreveu:
> > Em Fri, Jan 18, 2019 at 09:59:20AM -0300, Arnaldo Carvalho de Melo escreveu:
> > > Thanks, tested and applied.
>
> > > While testing I found
Em Fri, Jan 18, 2019 at 10:01:06AM -0300, Arnaldo Carvalho de Melo escreveu:
> Em Fri, Jan 18, 2019 at 09:59:20AM -0300, Arnaldo Carvalho de Melo escreveu:
> > Thanks, tested and applied.
> > While testing I found something odd, the cycles events are not showing
> > the CPU and the probe events
Em Fri, Jan 18, 2019 at 09:59:20AM -0300, Arnaldo Carvalho de Melo escreveu:
> Em Fri, Jan 18, 2019 at 10:49:19AM +0100, Jiri Olsa escreveu:
> > On Thu, Jan 17, 2019 at 11:48:34AM -0800, Andi Kleen wrote:
> > > From: Andi Kleen
>
> > > perf script crashes currently when printing mixed trace
Em Fri, Jan 18, 2019 at 10:49:19AM +0100, Jiri Olsa escreveu:
> On Thu, Jan 17, 2019 at 11:48:34AM -0800, Andi Kleen wrote:
> > From: Andi Kleen
> > perf script crashes currently when printing mixed trace points and other
> > events because the trace format does not handle events without trace
>
On Thu, Jan 17, 2019 at 11:48:34AM -0800, Andi Kleen wrote:
> From: Andi Kleen
>
> perf script crashes currently when printing mixed trace points and other
> events because the trace format does not handle events without trace
> meta data. Add a simple check to avoid that.
>
> % cat > test.c
>
From: Andi Kleen
perf script crashes currently when printing mixed trace points and other
events because the trace format does not handle events without trace
meta data. Add a simple check to avoid that.
% cat > test.c
main()
{
printf("Hello world\n");
}
^D
% gcc -g -o test test.c
% sudo
13 matches
Mail list logo