Re: [PATCH] perf ui/gtk: Ensure not to call gtk_main_quit() twice

2012-08-19 Thread Pekka Enberg
On Mon, Aug 20, 2012 at 4:59 AM, Namhyung Kim wrote: > Forgot to add the #ifdefery to the below code also. :-/ Anyway, it needs > to expose gtk specifics to general code with the #ifdef's. So I'd still > prefer the original patch. Fair enough. Acked-by: Pekka Enberg -- To unsubscribe from

Re: [PATCH] perf ui/gtk: Ensure not to call gtk_main_quit() twice

2012-08-19 Thread Namhyung Kim
On Mon, 20 Aug 2012 10:55:24 +0900, Namhyung Kim wrote: > On Mon, 20 Aug 2012 10:50:21 +0900, Namhyung Kim wrote: >> On Sat, 18 Aug 2012 10:52:03 +0300, Pekka Enberg wrote: >>> Wouldn't it be nicer to rearrange the callers so that perf_gtk__exit() >>> is not called twice? >> >> You mean this? >>

Re: [PATCH] perf ui/gtk: Ensure not to call gtk_main_quit() twice

2012-08-19 Thread Namhyung Kim
On Mon, 20 Aug 2012 10:50:21 +0900, Namhyung Kim wrote: > On Sat, 18 Aug 2012 10:52:03 +0300, Pekka Enberg wrote: >> Wouldn't it be nicer to rearrange the callers so that perf_gtk__exit() >> is not called twice? > > You mean this? > > > diff --git a/tools/perf/ui/setup.c b/tools/perf/ui/setup.c >

Re: [PATCH] perf ui/gtk: Ensure not to call gtk_main_quit() twice

2012-08-19 Thread Namhyung Kim
On Sat, 18 Aug 2012 10:52:03 +0300, Pekka Enberg wrote: > On Fri, Aug 17, 2012 at 7:56 PM, Namhyung Kim wrote: >> Currently the gtk_main_quit() is called twice when perf exits so the >> following warning is emitted: >> >> [penberg@tux perf]$ ./perf report --gtk >> ^Cperf: Interrupt >> >>

Re: [PATCH] perf ui/gtk: Ensure not to call gtk_main_quit() twice

2012-08-19 Thread Namhyung Kim
On Sat, 18 Aug 2012 10:52:03 +0300, Pekka Enberg wrote: On Fri, Aug 17, 2012 at 7:56 PM, Namhyung Kim namhy...@kernel.org wrote: Currently the gtk_main_quit() is called twice when perf exits so the following warning is emitted: [penberg@tux perf]$ ./perf report --gtk ^Cperf: Interrupt

Re: [PATCH] perf ui/gtk: Ensure not to call gtk_main_quit() twice

2012-08-19 Thread Namhyung Kim
On Mon, 20 Aug 2012 10:50:21 +0900, Namhyung Kim wrote: On Sat, 18 Aug 2012 10:52:03 +0300, Pekka Enberg wrote: Wouldn't it be nicer to rearrange the callers so that perf_gtk__exit() is not called twice? You mean this? diff --git a/tools/perf/ui/setup.c b/tools/perf/ui/setup.c index

Re: [PATCH] perf ui/gtk: Ensure not to call gtk_main_quit() twice

2012-08-19 Thread Namhyung Kim
On Mon, 20 Aug 2012 10:55:24 +0900, Namhyung Kim wrote: On Mon, 20 Aug 2012 10:50:21 +0900, Namhyung Kim wrote: On Sat, 18 Aug 2012 10:52:03 +0300, Pekka Enberg wrote: Wouldn't it be nicer to rearrange the callers so that perf_gtk__exit() is not called twice? You mean this? diff --git

Re: [PATCH] perf ui/gtk: Ensure not to call gtk_main_quit() twice

2012-08-19 Thread Pekka Enberg
On Mon, Aug 20, 2012 at 4:59 AM, Namhyung Kim namhy...@kernel.org wrote: Forgot to add the #ifdefery to the below code also. :-/ Anyway, it needs to expose gtk specifics to general code with the #ifdef's. So I'd still prefer the original patch. Fair enough. Acked-by: Pekka Enberg

Re: [PATCH] perf ui/gtk: Ensure not to call gtk_main_quit() twice

2012-08-18 Thread Pekka Enberg
On Fri, Aug 17, 2012 at 7:56 PM, Namhyung Kim wrote: > Currently the gtk_main_quit() is called twice when perf exits so the > following warning is emitted: > > [penberg@tux perf]$ ./perf report --gtk > ^Cperf: Interrupt > > (perf:4048): Gtk-CRITICAL **: IA__gtk_main_quit: assertion

Re: [PATCH] perf ui/gtk: Ensure not to call gtk_main_quit() twice

2012-08-18 Thread Pekka Enberg
On Fri, Aug 17, 2012 at 7:56 PM, Namhyung Kim namhy...@kernel.org wrote: Currently the gtk_main_quit() is called twice when perf exits so the following warning is emitted: [penberg@tux perf]$ ./perf report --gtk ^Cperf: Interrupt (perf:4048): Gtk-CRITICAL **: IA__gtk_main_quit:

[PATCH] perf ui/gtk: Ensure not to call gtk_main_quit() twice

2012-08-17 Thread Namhyung Kim
Currently the gtk_main_quit() is called twice when perf exits so the following warning is emitted: [penberg@tux perf]$ ./perf report --gtk ^Cperf: Interrupt (perf:4048): Gtk-CRITICAL **: IA__gtk_main_quit: assertion `main_loops != NULL' failed Fix it by not to call it unnecessarily.

[PATCH] perf ui/gtk: Ensure not to call gtk_main_quit() twice

2012-08-17 Thread Namhyung Kim
Currently the gtk_main_quit() is called twice when perf exits so the following warning is emitted: [penberg@tux perf]$ ./perf report --gtk ^Cperf: Interrupt (perf:4048): Gtk-CRITICAL **: IA__gtk_main_quit: assertion `main_loops != NULL' failed Fix it by not to call it unnecessarily.