Re: [PATCH] perf x86_64: Fix rsp register for system call fast path

2012-10-02 Thread Peter Zijlstra
On Mon, 2012-10-01 at 19:31 +0200, Jiri Olsa wrote: > @@ -696,7 +696,7 @@ struct perf_branch_stack { > > struct perf_regs_user { > __u64 abi; > - struct pt_regs *regs; > + struct pt_regs regs; > }; That's somewhat unfortunate but unavoidable I guess, can't go

Re: [PATCH] perf x86_64: Fix rsp register for system call fast path

2012-10-02 Thread Peter Zijlstra
On Mon, 2012-10-01 at 19:31 +0200, Jiri Olsa wrote: @@ -696,7 +696,7 @@ struct perf_branch_stack { struct perf_regs_user { __u64 abi; - struct pt_regs *regs; + struct pt_regs regs; }; That's somewhat unfortunate but unavoidable I guess, can't go modify

[PATCH] perf x86_64: Fix rsp register for system call fast path

2012-10-01 Thread Jiri Olsa
The user level rsp register value attached to the sample is crucial for proper user stack dump and for proper dwarf backtrace post unwind. But currently, if the event happens within the system call fast path, we don't store proper rsp register value in the event sample. The reason is that the

[PATCH] perf x86_64: Fix rsp register for system call fast path

2012-10-01 Thread Jiri Olsa
The user level rsp register value attached to the sample is crucial for proper user stack dump and for proper dwarf backtrace post unwind. But currently, if the event happens within the system call fast path, we don't store proper rsp register value in the event sample. The reason is that the