Re: [PATCH] scripts/mod/modpost.c: Fix bug in number_prefix

2014-07-09 Thread Sam Ravnborg
On Wed, Jul 09, 2014 at 09:28:43AM +0930, Rusty Russell wrote: > Rasmus Villemoes writes: > > Paul Gortmaker writes: > > > >> On 14-06-25 04:46 AM, Rasmus Villemoes wrote: > >>> The function number_prefix() can currently only return 1 if its > >>> argument is the empty string: If line 3 is reache

Re: [PATCH] scripts/mod/modpost.c: Fix bug in number_prefix

2014-07-08 Thread Rusty Russell
Rasmus Villemoes writes: > Paul Gortmaker writes: > >> On 14-06-25 04:46 AM, Rasmus Villemoes wrote: >>> The function number_prefix() can currently only return 1 if its >>> argument is the empty string: If line 3 is reached and *sym (now the >>> second character in the argument) is not '.', 0 is

Re: [PATCH] scripts/mod/modpost.c: Fix bug in number_prefix

2014-06-25 Thread Rasmus Villemoes
Paul Gortmaker writes: > On 14-06-25 04:46 AM, Rasmus Villemoes wrote: >> The function number_prefix() can currently only return 1 if its >> argument is the empty string: If line 3 is reached and *sym (now the >> second character in the argument) is not '.', 0 is returned. However, >> if that cha

Re: [PATCH] scripts/mod/modpost.c: Fix bug in number_prefix

2014-06-25 Thread Paul Gortmaker
On 14-06-25 04:46 AM, Rasmus Villemoes wrote: > The function number_prefix() can currently only return 1 if its > argument is the empty string: If line 3 is reached and *sym (now the > second character in the argument) is not '.', 0 is returned. However, > if that character is '.', the first assign

[PATCH] scripts/mod/modpost.c: Fix bug in number_prefix

2014-06-25 Thread Rasmus Villemoes
The function number_prefix() can currently only return 1 if its argument is the empty string: If line 3 is reached and *sym (now the second character in the argument) is not '.', 0 is returned. However, if that character is '.', the first assignment to c is that same '.', which obviously fails to b