Re: [PATCH] staging: rtl8188eu: replace goto with direct return

2021-04-04 Thread Deborah Brouwer
On Sun, Apr 04, 2021 at 11:54:40AM +0200, Greg KH wrote: > On Sat, Apr 03, 2021 at 10:40:08PM -0700, Deborah Brouwer wrote: > > To conform with Linux kernel coding style, replace goto statement that > > does no cleanup with a direct return. To preserve meaning, copy comments > > from the original

Re: [PATCH] staging: rtl8188eu: replace goto with direct return

2021-04-04 Thread Greg KH
On Sat, Apr 03, 2021 at 10:40:08PM -0700, Deborah Brouwer wrote: > To conform with Linux kernel coding style, replace goto statement that > does no cleanup with a direct return. To preserve meaning, copy comments > from the original goto statement to the return statement. Identified by > the

Re: [Outreachy kernel] [PATCH] staging: rtl8188eu: replace goto with direct return

2021-04-04 Thread Julia Lawall
On Sat, 3 Apr 2021, Deborah Brouwer wrote: > To conform with Linux kernel coding style, replace goto statement that > does no cleanup with a direct return. To preserve meaning, copy comments > from the original goto statement to the return statement. Identified by > the checkpatch warning:

[PATCH] staging: rtl8188eu: replace goto with direct return

2021-04-03 Thread Deborah Brouwer
To conform with Linux kernel coding style, replace goto statement that does no cleanup with a direct return. To preserve meaning, copy comments from the original goto statement to the return statement. Identified by the checkpatch warning: WARNING: void function return statements are not