Re: [PATCH] treewide: Convert macro and uses of __section(foo) to __section("foo")

2020-10-26 Thread Guenter Roeck
On Mon, Oct 26, 2020 at 01:33:48PM -0700, Linus Torvalds wrote: > On Mon, Oct 26, 2020 at 12:41 PM Guenter Roeck wrote: > > > > make ARCH=um SUBARCH=x86_64 defconfig: > > > > Building um:defconfig ... failed > > -- > > Error log: > > arch/um/kernel/skas/clone.c:24:16: error: expected

Re: [PATCH] treewide: Convert macro and uses of __section(foo) to __section("foo")

2020-10-26 Thread Linus Torvalds
On Mon, Oct 26, 2020 at 12:41 PM Guenter Roeck wrote: > > make ARCH=um SUBARCH=x86_64 defconfig: > > Building um:defconfig ... failed > -- > Error log: > arch/um/kernel/skas/clone.c:24:16: error: expected declaration specifiers or > '...' before string constant >

Re: [PATCH] treewide: Convert macro and uses of __section(foo) to __section("foo")

2020-10-26 Thread Nathan Chancellor
On Mon, Oct 26, 2020 at 12:36:52PM -0700, Guenter Roeck wrote: > On Wed, Oct 21, 2020 at 07:36:07PM -0700, Joe Perches wrote: > > Use a more generic form for __section that requires quotes to avoid > > complications with clang and gcc differences. > > > > Remove the quote operator # from

Re: [PATCH] treewide: Convert macro and uses of __section(foo) to __section("foo")

2020-10-26 Thread Guenter Roeck
On Wed, Oct 21, 2020 at 07:36:07PM -0700, Joe Perches wrote: > Use a more generic form for __section that requires quotes to avoid > complications with clang and gcc differences. > > Remove the quote operator # from compiler_attributes.h __section macro. > > Convert all unquoted __section(foo)

Re: [PATCH] treewide: Convert macro and uses of __section(foo) to __section("foo")

2020-10-26 Thread Guenter Roeck
On Wed, Oct 21, 2020 at 07:36:07PM -0700, Joe Perches wrote: > Use a more generic form for __section that requires quotes to avoid > complications with clang and gcc differences. > > Remove the quote operator # from compiler_attributes.h __section macro. > > Convert all unquoted __section(foo)

Re: [PATCH] treewide: Convert macro and uses of __section(foo) to __section("foo")

2020-10-23 Thread Miguel Ojeda
On Fri, Oct 23, 2020 at 10:03 AM Joe Perches wrote: > > Thanks Miguel, but IMO it doesn't need time in next. You're welcome! It never hurts to keep things for a bit there. > Applying it just before an rc1 minimizes conflicts. There shouldn't be many conflicts after -rc1. The amount of changes

Re: [PATCH] treewide: Convert macro and uses of __section(foo) to __section("foo")

2020-10-23 Thread Joe Perches
On Fri, 2020-10-23 at 08:08 +0200, Miguel Ojeda wrote: > On Thu, Oct 22, 2020 at 4:36 AM Joe Perches wrote: > > > > Use a more generic form for __section that requires quotes to avoid > > complications with clang and gcc differences. > > I performed visual inspection (one by one...) and the

Re: [PATCH] treewide: Convert macro and uses of __section(foo) to __section("foo")

2020-10-23 Thread Miguel Ojeda
On Thu, Oct 22, 2020 at 4:36 AM Joe Perches wrote: > > Use a more generic form for __section that requires quotes to avoid > complications with clang and gcc differences. I performed visual inspection (one by one...) and the only thing I saw is that sometimes the `__attribute__` has a whitespace

Re: [PATCH] treewide: Convert macro and uses of __section(foo) to __section("foo")

2020-10-22 Thread Joe Perches
On Thu, 2020-10-22 at 13:42 -0700, Nick Desaulniers wrote: > .On Wed, Oct 21, 2020 at 7:36 PM Joe Perches wrote: > > Use a more generic form for __section that requires quotes to avoid > > complications with clang and gcc differences. [] > > a quick test of x86_64 and s390 would be good. x86_64

Re: [PATCH] treewide: Convert macro and uses of __section(foo) to __section("foo")

2020-10-22 Thread Nick Desaulniers
.On Wed, Oct 21, 2020 at 7:36 PM Joe Perches wrote: > > Use a more generic form for __section that requires quotes to avoid > complications with clang and gcc differences. > > Remove the quote operator # from compiler_attributes.h __section macro. > > Convert all unquoted __section(foo) uses to

[PATCH] treewide: Convert macro and uses of __section(foo) to __section("foo")

2020-10-21 Thread Joe Perches
Use a more generic form for __section that requires quotes to avoid complications with clang and gcc differences. Remove the quote operator # from compiler_attributes.h __section macro. Convert all unquoted __section(foo) uses to quoted __section("foo"). Also convert