Re: [PATCH] userfaultfd: avoid the duplicated release for userfaultfd_ctx

2020-07-21 Thread Suren Baghdasaryan
On Sun, Jul 19, 2020 at 6:34 PM Xu, Yanfei wrote: > > > > On 7/20/20 12:57 AM, Al Viro wrote: > > On Sun, Jul 19, 2020 at 09:58:34PM +0800, Xu, Yanfei wrote: > >> ping Al Viro > >> > >> Could you please help to review this patch? Thanks a lot. > > > > That's -next, right? As for the patch

Re: [PATCH] userfaultfd: avoid the duplicated release for userfaultfd_ctx

2020-07-19 Thread Xu, Yanfei
On 7/20/20 12:57 AM, Al Viro wrote: On Sun, Jul 19, 2020 at 09:58:34PM +0800, Xu, Yanfei wrote: ping Al Viro Could you please help to review this patch? Thanks a lot. That's -next, right? As for the patch itself... Frankly, Yes, it's -next. Daniel's patch looks seriously wrong. Get

Re: [PATCH] userfaultfd: avoid the duplicated release for userfaultfd_ctx

2020-07-19 Thread Al Viro
On Sun, Jul 19, 2020 at 09:58:34PM +0800, Xu, Yanfei wrote: > ping Al Viro > > Could you please help to review this patch? Thanks a lot. That's -next, right? As for the patch itself... Frankly, Daniel's patch looks seriously wrong. * why has O_CLOEXEC been quietly smuggled in? It's a

Re: [PATCH] userfaultfd: avoid the duplicated release for userfaultfd_ctx

2020-07-19 Thread Xu, Yanfei
ping Al Viro Could you please help to review this patch? Thanks a lot. Yanfei On 7/15/20 12:12 AM, yanfei...@windriver.com wrote: From: Yanfei Xu when get_unused_fd_flags gets failure, userfaultfd_ctx_cachep will be freed by userfaultfd_fops's release function which is the

Re: [PATCH] userfaultfd: avoid the duplicated release for userfaultfd_ctx

2020-07-14 Thread Xu, Yanfei
Add maintainer Alexander Viro :) On 7/15/20 12:12 AM, yanfei...@windriver.com wrote: From: Yanfei Xu when get_unused_fd_flags gets failure, userfaultfd_ctx_cachep will be freed by userfaultfd_fops's release function which is the userfaultfd_release. So we could return directly after fput().

[PATCH] userfaultfd: avoid the duplicated release for userfaultfd_ctx

2020-07-14 Thread yanfei.xu
From: Yanfei Xu when get_unused_fd_flags gets failure, userfaultfd_ctx_cachep will be freed by userfaultfd_fops's release function which is the userfaultfd_release. So we could return directly after fput(). userfaultfd_release()->userfaultfd_ctx_put(ctx) Fixes: d08ac70b1e0d (Wire UFFD up to