Re: [PATCH] video: ARM CLCD: Added dt support to set tim2 register

On 2/16/2016 11:32 AM, Dmitry Torokhov wrote: On Mon, Feb 15, 2016 at 5:25 AM, Linus Walleij > wrote: On Wed, Feb 10, 2016 at 6:48 PM, Ray Jui > wrote: > Could you

Re: [PATCH] video: ARM CLCD: Added dt support to set tim2 register

On 2/16/2016 11:32 AM, Dmitry Torokhov wrote: On Mon, Feb 15, 2016 at 5:25 AM, Linus Walleij mailto:linus.wall...@linaro.org>> wrote: On Wed, Feb 10, 2016 at 6:48 PM, Ray Jui mailto:ray@broadcom.com>> wrote: > Could you please add me to the email thread and I can review it

Re: [PATCH] video: ARM CLCD: Added dt support to set tim2 register

On Wed, Feb 10, 2016 at 6:48 PM, Ray Jui wrote: > Could you please add me to the email thread and I can review it there (I > won't have time to test, but I can help to review the code and find time to > test later)? OK I will add you to subsequent postings, if any. > This

Re: [PATCH] video: ARM CLCD: Added dt support to set tim2 register

On Wed, Feb 10, 2016 at 6:48 PM, Ray Jui wrote: > Could you please add me to the email thread and I can review it there (I > won't have time to test, but I can help to review the code and find time to > test later)? OK I will add you to subsequent postings, if any. > This may be a dumb

Re: [PATCH] video: ARM CLCD: Added dt support to set tim2 register

Hi Linus, On 2/10/2016 5:58 AM, Linus Walleij wrote: On Wed, Feb 25, 2015 at 10:01 PM, Arun Ramamurthy wrote: Added code based on linaro tree: http://git.linaro.org/kernel/linux-linaro-stable.git with commit id:6846e7822c4cab5a84672baace3b768c2d0db142 at drivers/video/amba-clcd.c. This lets

Re: [PATCH] video: ARM CLCD: Added dt support to set tim2 register

On Wed, Feb 25, 2015 at 10:01 PM, Arun Ramamurthy wrote: > Added code based on linaro tree: > http://git.linaro.org/kernel/linux-linaro-stable.git > with commit id:6846e7822c4cab5a84672baace3b768c2d0db142 > at drivers/video/amba-clcd.c. This lets the driver set > certain tim2 register bits after

Re: [PATCH] video: ARM CLCD: Added dt support to set tim2 register

On Wed, Feb 25, 2015 at 10:01 PM, Arun Ramamurthy wrote: > Added code based on linaro tree: > http://git.linaro.org/kernel/linux-linaro-stable.git > with commit id:6846e7822c4cab5a84672baace3b768c2d0db142 > at drivers/video/amba-clcd.c. This lets the driver set >

Re: [PATCH] video: ARM CLCD: Added dt support to set tim2 register

Hi Linus, On 2/10/2016 5:58 AM, Linus Walleij wrote: On Wed, Feb 25, 2015 at 10:01 PM, Arun Ramamurthy wrote: Added code based on linaro tree: http://git.linaro.org/kernel/linux-linaro-stable.git with commit id:6846e7822c4cab5a84672baace3b768c2d0db142 at

Re: [PATCH] video: ARM CLCD: Added dt support to set tim2 register

On Tue, Mar 03, 2015 at 10:22:07AM +, Pawel Moll wrote: > On Tue, 2015-03-03 at 10:02 +, Pawel Moll wrote: > > On Mon, 2015-03-02 at 19:09 +, Arun Ramamurthy wrote: > > > > The existing bindings intentionally avoided quoting internal registers - > > > > they are supposed to describe

Re: [PATCH] video: ARM CLCD: Added dt support to set tim2 register

On Tue, Mar 03, 2015 at 10:22:07AM +, Pawel Moll wrote: On Tue, 2015-03-03 at 10:02 +, Pawel Moll wrote: On Mon, 2015-03-02 at 19:09 +, Arun Ramamurthy wrote: The existing bindings intentionally avoided quoting internal registers - they are supposed to describe how the

Re: [PATCH] video: ARM CLCD: Added dt support to set tim2 register

On Wed, 2015-03-04 at 00:37 +, Arun Ramamurthy wrote: > > That way you're precisely describing the way the hardware is wired up. > > And the driver simply tries to get clcdclk first, if it's defined - > > cool, set clksel to 1, if not - try hclk and set clksel to 0. If neither > > of them is

Re: [PATCH] video: ARM CLCD: Added dt support to set tim2 register

On Wed, 2015-03-04 at 00:37 +, Arun Ramamurthy wrote: That way you're precisely describing the way the hardware is wired up. And the driver simply tries to get clcdclk first, if it's defined - cool, set clksel to 1, if not - try hclk and set clksel to 0. If neither of them is present -

Re: [PATCH] video: ARM CLCD: Added dt support to set tim2 register

On 15-03-03 02:22 AM, Pawel Moll wrote: On Tue, 2015-03-03 at 10:02 +, Pawel Moll wrote: On Mon, 2015-03-02 at 19:09 +, Arun Ramamurthy wrote: The existing bindings intentionally avoided quoting internal registers - they are supposed to describe how the hardware is wired up... So

Re: [PATCH] video: ARM CLCD: Added dt support to set tim2 register

On Tue, 2015-03-03 at 10:02 +, Pawel Moll wrote: > On Mon, 2015-03-02 at 19:09 +, Arun Ramamurthy wrote: > > > The existing bindings intentionally avoided quoting internal registers - > > > they are supposed to describe how the hardware is wired up... > > > > > > So how about something

Re: [PATCH] video: ARM CLCD: Added dt support to set tim2 register

On Mon, 2015-03-02 at 19:09 +, Arun Ramamurthy wrote: > > The existing bindings intentionally avoided quoting internal registers - > > they are supposed to describe how the hardware is wired up... > > > > So how about something like "arm,pl11x,tft-invert-clac"? Then the driver > > sets the bit

Re: [PATCH] video: ARM CLCD: Added dt support to set tim2 register

On Mon, 2015-03-02 at 19:09 +, Arun Ramamurthy wrote: The existing bindings intentionally avoided quoting internal registers - they are supposed to describe how the hardware is wired up... So how about something like arm,pl11x,tft-invert-clac? Then the driver sets the bit or not,

Re: [PATCH] video: ARM CLCD: Added dt support to set tim2 register

On 15-03-03 02:22 AM, Pawel Moll wrote: On Tue, 2015-03-03 at 10:02 +, Pawel Moll wrote: On Mon, 2015-03-02 at 19:09 +, Arun Ramamurthy wrote: The existing bindings intentionally avoided quoting internal registers - they are supposed to describe how the hardware is wired up... So

Re: [PATCH] video: ARM CLCD: Added dt support to set tim2 register

On Tue, 2015-03-03 at 10:02 +, Pawel Moll wrote: On Mon, 2015-03-02 at 19:09 +, Arun Ramamurthy wrote: The existing bindings intentionally avoided quoting internal registers - they are supposed to describe how the hardware is wired up... So how about something like

Re: [PATCH] video: ARM CLCD: Added dt support to set tim2 register

On 15-03-02 08:11 AM, Pawel Moll wrote: On Wed, 2015-02-25 at 21:01 +, Arun Ramamurthy wrote: Added code based on linaro tree: http://git.linaro.org/kernel/linux-linaro-stable.git with commit id:6846e7822c4cab5a84672baace3b768c2d0db142 at drivers/video/amba-clcd.c. This lets the driver

Re: [PATCH] video: ARM CLCD: Added dt support to set tim2 register

On Wed, 2015-02-25 at 21:01 +, Arun Ramamurthy wrote: > Added code based on linaro tree: > http://git.linaro.org/kernel/linux-linaro-stable.git > with commit id:6846e7822c4cab5a84672baace3b768c2d0db142 > at drivers/video/amba-clcd.c. This lets the driver set > certain tim2 register bits after

Re: [PATCH] video: ARM CLCD: Added dt support to set tim2 register

On Wed, 2015-02-25 at 21:01 +, Arun Ramamurthy wrote: Added code based on linaro tree: http://git.linaro.org/kernel/linux-linaro-stable.git with commit id:6846e7822c4cab5a84672baace3b768c2d0db142 at drivers/video/amba-clcd.c. This lets the driver set certain tim2 register bits after

Re: [PATCH] video: ARM CLCD: Added dt support to set tim2 register

On 15-03-02 08:11 AM, Pawel Moll wrote: On Wed, 2015-02-25 at 21:01 +, Arun Ramamurthy wrote: Added code based on linaro tree: http://git.linaro.org/kernel/linux-linaro-stable.git with commit id:6846e7822c4cab5a84672baace3b768c2d0db142 at drivers/video/amba-clcd.c. This lets the driver

[PATCH] video: ARM CLCD: Added dt support to set tim2 register

Added code based on linaro tree: http://git.linaro.org/kernel/linux-linaro-stable.git with commit id:6846e7822c4cab5a84672baace3b768c2d0db142 at drivers/video/amba-clcd.c. This lets the driver set certain tim2 register bits after reading them from device tree. Reviewed-by: Ray Jui Reviewed-by:

[PATCH] video: ARM CLCD: Added dt support to set tim2 register

Added code based on linaro tree: http://git.linaro.org/kernel/linux-linaro-stable.git with commit id:6846e7822c4cab5a84672baace3b768c2d0db142 at drivers/video/amba-clcd.c. This lets the driver set certain tim2 register bits after reading them from device tree. Reviewed-by: Ray Jui