Re: [PATCH 0/14] v2 multi-die/package topology support

2019-04-30 Thread Len Brown
On Tue, Apr 30, 2019 at 5:33 AM Borislav Petkov wrote: > So that die thing has only small relevance to some software, as you say: > > "These topology changes primarily impact parts of the kernel and some > applciations that care about package MSR scope." > > So if there's no real need to add it

Re: [PATCH 0/14] v2 multi-die/package topology support

2019-04-30 Thread Borislav Petkov
On Tue, Apr 30, 2019 at 02:50:58AM -0400, Len Brown wrote: > If one were to make a change here, I'd consider adding the (physical) die_id, > though it is already in sysfs topology as an attribute. From: Documentation/x86/topology.txt "The kernel does not care about the concept of physical

Re: [PATCH 0/14] v2 multi-die/package topology support

2019-04-30 Thread Len Brown
On Tue, Feb 26, 2019 at 2:05 PM Peter Zijlstra wrote: > > On Tue, Feb 26, 2019 at 01:19:58AM -0500, Len Brown wrote: > > Documentation/cputopology.txt| 72 ++- > > Documentation/x86/topology.txt | 6 +- > > arch/x86/include/asm/processor.h

Re: [PATCH 0/14] v2 multi-die/package topology support

2019-04-12 Thread Brice Goglin
Le 12/04/2019 à 21:52, Len Brown a écrit : I think I prefer 's/threads/cpus/g' on that. Threads makes me think SMT, and I don't think there's any guarantee the part in question will have SMT on. >>> I think 'threads' is a bit confusing as well. We seem to be using 'cpu' >>>

Re: [PATCH 0/14] v2 multi-die/package topology support

2019-04-12 Thread Len Brown
> > > I think I prefer 's/threads/cpus/g' on that. Threads makes me think SMT, > > > and I don't think there's any guarantee the part in question will have > > > SMT on. > > > > I think 'threads' is a bit confusing as well. We seem to be using 'cpu' > > everywhere for something we can schedule

Re: [PATCH 0/14] v2 multi-die/package topology support

2019-04-12 Thread Len Brown
On Tue, Feb 26, 2019 at 1:51 PM Peter Zijlstra wrote: > > On Tue, Feb 26, 2019 at 01:19:58AM -0500, Len Brown wrote: > > Restored sysfs core_siblings, core_siblings_list > > > > v1 proposed re-defining this existing attribute to > > be the threads in a die, rather than in a package. >

Re: [PATCH 0/14] v2 multi-die/package topology support

2019-04-05 Thread Thomas Gleixner
On Thu, 7 Mar 2019, Morten Rasmussen wrote: > On Tue, Feb 26, 2019 at 07:53:58PM +0100, Peter Zijlstra wrote: > > On Tue, Feb 26, 2019 at 01:19:58AM -0500, Len Brown wrote: > > > Added sysfs core_threads, core_threads_list > > > > > > Added this attribute to show which threads siblings in a

Re: [PATCH 0/14] v2 multi-die/package topology support

2019-04-05 Thread Thomas Gleixner
On Tue, 26 Feb 2019, Len Brown wrote: > This patch series does 4 things. > > 1. Parses the new CPUID.1F leaf to discover multi-die/package topology > > 2. Export multi-die topology inside the kernel > > 3. Update 3 places (coretemp, pkgtemp, rapl) that that need to know >the difference

Re: [PATCH 0/14] v2 multi-die/package topology support

2019-03-07 Thread Morten Rasmussen
On Tue, Feb 26, 2019 at 07:53:58PM +0100, Peter Zijlstra wrote: > On Tue, Feb 26, 2019 at 01:19:58AM -0500, Len Brown wrote: > > Added sysfs package_threads, package_threads_list > > > > Added this attribute to show threads siblings in a package. > > Exactly same as "core_siblings above",

Re: [PATCH 0/14] v2 multi-die/package topology support

2019-02-26 Thread Peter Zijlstra
On Tue, Feb 26, 2019 at 01:19:58AM -0500, Len Brown wrote: > Documentation/cputopology.txt| 72 ++- > Documentation/x86/topology.txt | 6 +- > arch/x86/include/asm/processor.h | 5 +- > arch/x86/include/asm/smp.h |

Re: [PATCH 0/14] v2 multi-die/package topology support

2019-02-26 Thread Peter Zijlstra
On Tue, Feb 26, 2019 at 01:19:58AM -0500, Len Brown wrote: > Added sysfs package_threads, package_threads_list > > Added this attribute to show threads siblings in a package. > Exactly same as "core_siblings above", a name now deprecated. > This attribute name and definition is

Re: [PATCH 0/14] v2 multi-die/package topology support

2019-02-26 Thread Peter Zijlstra
On Tue, Feb 26, 2019 at 01:19:58AM -0500, Len Brown wrote: > Restored sysfs core_siblings, core_siblings_list > > v1 proposed re-defining this existing attribute to > be the threads in a die, rather than in a package. > > For compatibility, decided rather to keep this >

[PATCH 0/14] v2 multi-die/package topology support

2019-02-25 Thread Len Brown
This patch series does 4 things. 1. Parses the new CPUID.1F leaf to discover multi-die/package topology 2. Export multi-die topology inside the kernel 3. Update 3 places (coretemp, pkgtemp, rapl) that that need to know the difference between die and package-scope MSR. (Note: Kan Liang