Re: [PATCH 0/2] [GIT PULL][3.9] tracing: Fix in snapshot API

2013-03-08 Thread Ingo Molnar
* Hiraku Toyooka wrote: > Steven, > > (03/08/2013 12:34 AM), Steven Rostedt wrote: > >The second patch, returns success on a reset of the buffer even if > >the buffer wasn't allocated. Returning -EINVAL is just confusing. > > I realized we should update the snapshot documentation together

Re: [PATCH 0/2] [GIT PULL][3.9] tracing: Fix in snapshot API

2013-03-08 Thread Ingo Molnar
* Hiraku Toyooka hiraku.toyooka...@hitachi.com wrote: Steven, (03/08/2013 12:34 AM), Steven Rostedt wrote: The second patch, returns success on a reset of the buffer even if the buffer wasn't allocated. Returning -EINVAL is just confusing. I realized we should update the snapshot

Re: [PATCH 0/2] [GIT PULL][3.9] tracing: Fix in snapshot API

2013-03-07 Thread Hiraku Toyooka
Steven, (03/08/2013 12:34 AM), Steven Rostedt wrote: The second patch, returns success on a reset of the buffer even if the buffer wasn't allocated. Returning -EINVAL is just confusing. I realized we should update the snapshot documentation together with this change. I attached a patch to

[PATCH 0/2] [GIT PULL][3.9] tracing: Fix in snapshot API

2013-03-07 Thread Steven Rostedt
Ingo, The snapshot feature has been added in the 3.9 merge window. But after playing with it some more, I've come to realize that it needs a self documenting help (I had to look at the code a few times to remember how to use it, or look in Documentation), and it also gives an awkward error code

Re: [PATCH 0/2] [GIT PULL][3.9] tracing: Fix in snapshot API

2013-03-07 Thread Hiraku Toyooka
Steven, (03/08/2013 12:34 AM), Steven Rostedt wrote: The second patch, returns success on a reset of the buffer even if the buffer wasn't allocated. Returning -EINVAL is just confusing. I realized we should update the snapshot documentation together with this change. I attached a patch to

[PATCH 0/2] [GIT PULL][3.9] tracing: Fix in snapshot API

2013-03-07 Thread Steven Rostedt
Ingo, The snapshot feature has been added in the 3.9 merge window. But after playing with it some more, I've come to realize that it needs a self documenting help (I had to look at the code a few times to remember how to use it, or look in Documentation), and it also gives an awkward error code