Re: [PATCH 0/5] I8K driver facelift

2005-04-13 Thread Greg KH
On Wed, Apr 13, 2005 at 01:33:31AM -0500, Dmitry Torokhov wrote: > On Thursday 24 March 2005 02:24, Greg KH wrote: > > On Thu, Mar 17, 2005 at 03:16:24AM -0500, [EMAIL PROTECTED] wrote: > > > On Wed, 16 Mar 2005 14:38:50 MST, Frank Sorenson said: > > > > Okay, I replaced the sysfs_ops with ops of m

Re: [PATCH 0/5] I8K driver facelift

2005-04-12 Thread Dmitry Torokhov
On Thursday 24 March 2005 02:24, Greg KH wrote: > On Thu, Mar 17, 2005 at 03:16:24AM -0500, [EMAIL PROTECTED] wrote: > > On Wed, 16 Mar 2005 14:38:50 MST, Frank Sorenson said: > > > Okay, I replaced the sysfs_ops with ops of my own, and now all the show > > > and store functions also accept the nam

Re: [PATCH 0/5] I8K driver facelift

2005-03-24 Thread Dmitry Torokhov
On Thu, 24 Mar 2005 00:00:48 -0800, Greg KH <[EMAIL PROTECTED]> wrote: > On Thu, Mar 24, 2005 at 02:39:32AM -0500, Dmitry Torokhov wrote: > > On Thursday 24 March 2005 02:25, Greg KH wrote: > > > On Thu, Mar 17, 2005 at 01:40:48AM -0500, Dmitry Torokhov wrote: > > > > On Wednesday 16 March 2005 16:

Re: [PATCH 0/5] I8K driver facelift

2005-03-24 Thread Greg KH
On Thu, Mar 24, 2005 at 02:39:32AM -0500, Dmitry Torokhov wrote: > On Thursday 24 March 2005 02:25, Greg KH wrote: > > On Thu, Mar 17, 2005 at 01:40:48AM -0500, Dmitry Torokhov wrote: > > > On Wednesday 16 March 2005 16:38, Frank Sorenson wrote: > > > > Okay, I replaced the sysfs_ops with ops of my

Re: [PATCH 0/5] I8K driver facelift

2005-03-23 Thread Dmitry Torokhov
On Thursday 24 March 2005 02:25, Greg KH wrote: > On Thu, Mar 17, 2005 at 01:40:48AM -0500, Dmitry Torokhov wrote: > > On Wednesday 16 March 2005 16:38, Frank Sorenson wrote: > > > Okay, I replaced the sysfs_ops with ops of my own, and now all the show > > > and store functions also accept the name

Re: [PATCH 0/5] I8K driver facelift

2005-03-23 Thread Greg KH
On Thu, Mar 17, 2005 at 01:40:48AM -0500, Dmitry Torokhov wrote: > On Wednesday 16 March 2005 16:38, Frank Sorenson wrote: > > Okay, I replaced the sysfs_ops with ops of my own, and now all the show > > and store functions also accept the name of the attribute as a parameter. > > This lets the func

Re: [PATCH 0/5] I8K driver facelift

2005-03-23 Thread Greg KH
On Thu, Mar 17, 2005 at 03:16:24AM -0500, [EMAIL PROTECTED] wrote: > On Wed, 16 Mar 2005 14:38:50 MST, Frank Sorenson said: > > Okay, I replaced the sysfs_ops with ops of my own, and now all the show > > and store functions also accept the name of the attribute as a parameter. > > This lets the fun

Re: [PATCH 0/5] I8K driver facelift

2005-03-21 Thread Dmitry Torokhov
On Monday 21 March 2005 17:53, Frank Sorenson wrote: > Dmitry Torokhov wrote: > > I have implemented arrays of groups of attributes: > > Works great here. The i8k-cumulative patch claimed to be malformed, but > I merged it in just fine by hand. In arch/i386/kernel/dmi_scan.c, I had > to EXPORT d

Re: [PATCH 0/5] I8K driver facelift

2005-03-21 Thread Frank Sorenson
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Dmitry Torokhov wrote: > I have implemented arrays of groups of attributes: Works great here. The i8k-cumulative patch claimed to be malformed, but I merged it in just fine by hand. In arch/i386/kernel/dmi_scan.c, I had to EXPORT dmi_get_system_info

Re: [PATCH 0/5] I8K driver facelift

2005-03-20 Thread Dmitry Torokhov
Hi, On Thursday 17 March 2005 04:46, Frank Sorenson wrote: > Dmitry Torokhov wrote: > | Hrm, can we be a little more explicit and not poke in the sysfs guts right > | in the driver? What do you think about the patch below athat implements > | "attribute arrays"? And I am attaching cumulative i8k p

Re: [PATCH 0/5] I8K driver facelift

2005-03-17 Thread Dmitry Torokhov
On Thu, 17 Mar 2005 02:37:56 -0700, Frank Sorenson <[EMAIL PROTECTED]> wrote: > 1: My Inspiron 9200 (and perhaps others) doesn't seem to respond to the > I8K_SMM_BIOS_VERSION function call, so it fails the check in i8k_probe. > ~ The check of i8k_get_bios_version doesn't seem critical, and removin

Re: [PATCH 0/5] I8K driver facelift

2005-03-17 Thread Valdis . Kletnieks
On Wed, 16 Mar 2005 14:38:50 MST, Frank Sorenson said: > Okay, I replaced the sysfs_ops with ops of my own, and now all the show > and store functions also accept the name of the attribute as a parameter. > This lets the functions know what attribute is being accessed, and allows > us to create att

Re: [PATCH 0/5] I8K driver facelift

2005-03-17 Thread Frank Sorenson
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Dmitry Torokhov wrote: | Hrm, can we be a little more explicit and not poke in the sysfs guts right | in the driver? What do you think about the patch below athat implements | "attribute arrays"? And I am attaching cumulative i8k patch using these | arr

Re: [PATCH 0/5] I8K driver facelift

2005-03-17 Thread Frank Sorenson
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Dmitry Torokhov wrote: | Hrm, can we be a little more explicit and not poke in the sysfs guts right | in the driver? What do you think about the patch below athat implements | "attribute arrays"? And I am attaching cumulative i8k patch using these | arr

Re: [PATCH 0/5] I8K driver facelift

2005-03-16 Thread Dmitry Torokhov
On Wednesday 16 March 2005 16:38, Frank Sorenson wrote: > Okay, I replaced the sysfs_ops with ops of my own, and now all the show > and store functions also accept the name of the attribute as a parameter. > This lets the functions know what attribute is being accessed, and allows > us to create at

Re: [PATCH 0/5] I8K driver facelift

2005-03-16 Thread Frank Sorenson
Okay, I replaced the sysfs_ops with ops of my own, and now all the show and store functions also accept the name of the attribute as a parameter. This lets the functions know what attribute is being accessed, and allows us to create attributes that share show and store functions, so things don't ne

Re: [PATCH 0/5] I8K driver facelift

2005-03-15 Thread Frank Sorenson
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 [EMAIL PROTECTED] wrote: > Well, (a) the next rev of the patch will hopefully provide more access to the > second thermal probe than just detecting its existence (it still doesn't do > the sysfs or whatever magic to make the actual value accessible), a

Re: [PATCH 0/5] I8K driver facelift

2005-03-15 Thread Valdis . Kletnieks
On Tue, 15 Mar 2005 11:59:22 +0100, Giuseppe Bilotta said: > > According to your patch, the C840 has 2 temp sensors. I'll have to figure > > out what the second one is (prob either the GPU or the disk drive?) > > If it runs over 40 C easily it's probably the GPU :) Well, (a) the next rev of the p

Re: [PATCH 0/5] I8K driver facelift

2005-03-15 Thread Giuseppe Bilotta
> According to your patch, the C840 has 2 temp sensors. I'll have to figure > out what the second one is (prob either the GPU or the disk drive?) If it runs over 40 C easily it's probably the GPU :) -- Giuseppe "Oblomov" Bilotta Can't you see It all makes perfect sense Expressed in dollar and c

Re: [PATCH 0/5] I8K driver facelift

2005-03-15 Thread Valdis . Kletnieks
On Sat, 12 Mar 2005 20:41:14 MST, Frank Sorenson said: > These patches look pretty good. A few comments (with a patch--tested on > my Inspiron 9200): I tested your patch on top of Dmitry's on a Dell Latitude C840, seems to work. > - - Some of the Dell motherboards provide more than 1 temperatur

Re: [PATCH 0/5] I8K driver facelift

2005-03-12 Thread Dmitry Torokhov
On Saturday 12 March 2005 22:41, Frank Sorenson wrote: > Dmitry Torokhov wrote: > | Hi, > | > | here are some changes that freshen I8K driver (Dell Inspiron/Latitude > | platform driver). The patches have been tested on Inspiron 8100. > > | Please consider for inclusion. > | > | Thanks! > > These

Re: [PATCH 0/5] I8K driver facelift

2005-03-12 Thread Frank Sorenson
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Dmitry Torokhov wrote: | Hi, | | here are some changes that freshen I8K driver (Dell Inspiron/Latitude | platform driver). The patches have been tested on Inspiron 8100. | Please consider for inclusion. | | Thanks! These patches look pretty good. A fe

[PATCH 0/5] I8K driver facelift

2005-02-23 Thread Dmitry Torokhov
Hi, here are some changes that freshen I8K driver (Dell Inspiron/Latitude platform driver). The patches have been tested on Inspiron 8100. i8k-lindent.patch - pass the driver through Lindent to comply with CondingStyle requirements (4 spaces vs. TAB indentation) i8k-use-dmi.patch - use standar