Re: [PATCH 0/8] make some functions return bool

2017-12-12 Thread Yaowei Bai
On Tue, Dec 12, 2017 at 07:47:09PM -0800, David Rientjes wrote: > On Tue, 12 Dec 2017, Randy Dunlap wrote: > > > Sure, but I didn't keep the patch emails. > > > > Acked-by: Randy Dunlap > > > > You may have noticed changing functions like is_file_lru() to bool when it > is used to index into

Re: [PATCH 0/8] make some functions return bool

2017-12-12 Thread David Rientjes
On Tue, 12 Dec 2017, Randy Dunlap wrote: > Sure, but I didn't keep the patch emails. > > Acked-by: Randy Dunlap > You may have noticed changing functions like is_file_lru() to bool when it is used to index into an array or as part of an arithmetic operation for ZVC stats. I'm not sure why y

Re: [PATCH 0/8] make some functions return bool

2017-12-12 Thread Yaowei Bai
On Tue, Dec 12, 2017 at 06:32:32PM -0800, Randy Dunlap wrote: > On 12/12/2017 06:14 PM, Yaowei Bai wrote: > > On Tue, Dec 12, 2017 at 09:20:56AM -0800, Randy Dunlap wrote: > >> On 12/11/2017 11:21 PM, Yaowei Bai wrote: > >>> On Mon, Dec 11, 2017 at 09:50:03PM -0800, David Rientjes wrote: > On

Re: [PATCH 0/8] make some functions return bool

2017-12-12 Thread Randy Dunlap
On 12/12/2017 06:14 PM, Yaowei Bai wrote: > On Tue, Dec 12, 2017 at 09:20:56AM -0800, Randy Dunlap wrote: >> On 12/11/2017 11:21 PM, Yaowei Bai wrote: >>> On Mon, Dec 11, 2017 at 09:50:03PM -0800, David Rientjes wrote: On Mon, 11 Dec 2017, Yaowei Bai wrote: > This patchset makes some

Re: [PATCH 0/8] make some functions return bool

2017-12-12 Thread Yaowei Bai
On Tue, Dec 12, 2017 at 09:20:56AM -0800, Randy Dunlap wrote: > On 12/11/2017 11:21 PM, Yaowei Bai wrote: > > On Mon, Dec 11, 2017 at 09:50:03PM -0800, David Rientjes wrote: > >> On Mon, 11 Dec 2017, Yaowei Bai wrote: > >> > >>> This patchset makes some *_is_* like functions return bool because > >

Re: [PATCH 0/8] make some functions return bool

2017-12-12 Thread Randy Dunlap
On 12/11/2017 11:21 PM, Yaowei Bai wrote: > On Mon, Dec 11, 2017 at 09:50:03PM -0800, David Rientjes wrote: >> On Mon, 11 Dec 2017, Yaowei Bai wrote: >> >>> This patchset makes some *_is_* like functions return bool because >>> these functions only use true or false as their return values. >>> >>>

Re: [PATCH 0/8] make some functions return bool

2017-12-12 Thread Nikolay Borisov
On 12.12.2017 09:21, Yaowei Bai wrote: > On Mon, Dec 11, 2017 at 09:50:03PM -0800, David Rientjes wrote: >> On Mon, 11 Dec 2017, Yaowei Bai wrote: >> >>> This patchset makes some *_is_* like functions return bool because >>> these functions only use true or false as their return values. >>> >>> N

Re: [PATCH 0/8] make some functions return bool

2017-12-11 Thread Yaowei Bai
On Mon, Dec 11, 2017 at 09:50:03PM -0800, David Rientjes wrote: > On Mon, 11 Dec 2017, Yaowei Bai wrote: > > > This patchset makes some *_is_* like functions return bool because > > these functions only use true or false as their return values. > > > > No functional changes. > > > > I think the

Re: [PATCH 0/8] make some functions return bool

2017-12-11 Thread David Rientjes
On Mon, 11 Dec 2017, Yaowei Bai wrote: > This patchset makes some *_is_* like functions return bool because > these functions only use true or false as their return values. > > No functional changes. > I think the concern about this type of patchset in the past is that it is unnecessary churn

[PATCH 0/8] make some functions return bool

2017-12-11 Thread Yaowei Bai
This patchset makes some *_is_* like functions return bool because these functions only use true or false as their return values. No functional changes. Yaowei Bai (8): mm/memblock: memblock_is_map/region_memory can be boolean mm/mmzone: mm/lru: is_file/active_lru can be boolean lib/lockref