Re: [PATCH 01/15] clk: sunxi-ng: Add check for minimal rate to NM PLLs

2018-02-26 Thread Jernej Škrabec
Hi, Dne ponedeljek, 26. februar 2018 ob 10:38:00 CET je Maxime Ripard napisal(a): > Hi, > > On Sat, Feb 24, 2018 at 10:45:31PM +0100, Jernej Skrabec wrote: > > Some NM PLLs doesn't work well when their output clock rate is set below > > certain rate. > > > > Add support for that constrain. > >

Re: [PATCH 01/15] clk: sunxi-ng: Add check for minimal rate to NM PLLs

2018-02-26 Thread Chen-Yu Tsai
On Mon, Feb 26, 2018 at 6:25 PM, Maxime Ripard wrote: > On Mon, Feb 26, 2018 at 05:43:01PM +0800, Chen-Yu Tsai wrote: >> On Mon, Feb 26, 2018 at 5:38 PM, Maxime Ripard >> wrote: >> > Hi, >> > >> > On Sat, Feb 24, 2018 at 10:45:31PM +0100, Jernej Skrabec wrote: >> >> Some NM PLLs doesn't work well

Re: [PATCH 01/15] clk: sunxi-ng: Add check for minimal rate to NM PLLs

2018-02-26 Thread Maxime Ripard
On Mon, Feb 26, 2018 at 05:43:01PM +0800, Chen-Yu Tsai wrote: > On Mon, Feb 26, 2018 at 5:38 PM, Maxime Ripard > wrote: > > Hi, > > > > On Sat, Feb 24, 2018 at 10:45:31PM +0100, Jernej Skrabec wrote: > >> Some NM PLLs doesn't work well when their output clock rate is set below > >> certain rate. >

Re: [PATCH 01/15] clk: sunxi-ng: Add check for minimal rate to NM PLLs

2018-02-26 Thread Chen-Yu Tsai
On Mon, Feb 26, 2018 at 5:38 PM, Maxime Ripard wrote: > Hi, > > On Sat, Feb 24, 2018 at 10:45:31PM +0100, Jernej Skrabec wrote: >> Some NM PLLs doesn't work well when their output clock rate is set below >> certain rate. >> >> Add support for that constrain. > > In such a case, you should round th

Re: [PATCH 01/15] clk: sunxi-ng: Add check for minimal rate to NM PLLs

2018-02-26 Thread Maxime Ripard
Hi, On Sat, Feb 24, 2018 at 10:45:31PM +0100, Jernej Skrabec wrote: > Some NM PLLs doesn't work well when their output clock rate is set below > certain rate. > > Add support for that constrain. In such a case, you should round the rate to the minimum the clock can operate at, and not return an

[PATCH 01/15] clk: sunxi-ng: Add check for minimal rate to NM PLLs

2018-02-24 Thread Jernej Skrabec
Some NM PLLs doesn't work well when their output clock rate is set below certain rate. Add support for that constrain. Signed-off-by: Jernej Skrabec --- drivers/clk/sunxi-ng/ccu_nm.c | 11 +++ drivers/clk/sunxi-ng/ccu_nm.h | 27 +++ 2 files changed, 34 insertions