Re: [PATCH 01/27] perf tools: Add automated make test suite

2013-04-01 Thread Jiri Olsa
On Mon, Apr 01, 2013 at 09:53:18PM +0200, Sam Ravnborg wrote: SNIP > > + > > +MAKE_DEBUG := DEBUG=1 > > +MAKE_NO_LIBPERL := NO_LIBPERL=1 > > Why all these ugly UPPERCASE names? > In kbuild files the unwritten rule is that variables > with global scope are upper-case. > And

Re: [PATCH 01/27] perf tools: Add automated make test suite

2013-04-01 Thread Sam Ravnborg
On Mon, Apr 01, 2013 at 09:18:24PM +0200, Jiri Olsa wrote: > Adding automatd test for testing the build process. > To run it you needto be in perf directory or specify > one with PERF variable. It's also possible to specify > optional Makefile to test via MK variable. > > Whole suite is executed

[PATCH 01/27] perf tools: Add automated make test suite

2013-04-01 Thread Jiri Olsa
Adding automatd test for testing the build process. To run it you needto be in perf directory or specify one with PERF variable. It's also possible to specify optional Makefile to test via MK variable. Whole suite is executed twice, the second time with O=/tmp/xxx option added. To run the whole

[PATCH 01/27] perf tools: Add automated make test suite

2013-04-01 Thread Jiri Olsa
Adding automatd test for testing the build process. To run it you needto be in perf directory or specify one with PERF variable. It's also possible to specify optional Makefile to test via MK variable. Whole suite is executed twice, the second time with O=/tmp/xxx option added. To run the whole

Re: [PATCH 01/27] perf tools: Add automated make test suite

2013-04-01 Thread Sam Ravnborg
On Mon, Apr 01, 2013 at 09:18:24PM +0200, Jiri Olsa wrote: Adding automatd test for testing the build process. To run it you needto be in perf directory or specify one with PERF variable. It's also possible to specify optional Makefile to test via MK variable. Whole suite is executed twice,

Re: [PATCH 01/27] perf tools: Add automated make test suite

2013-04-01 Thread Jiri Olsa
On Mon, Apr 01, 2013 at 09:53:18PM +0200, Sam Ravnborg wrote: SNIP + +MAKE_DEBUG := DEBUG=1 +MAKE_NO_LIBPERL := NO_LIBPERL=1 Why all these ugly UPPERCASE names? In kbuild files the unwritten rule is that variables with global scope are upper-case. And variables with