[PATCH 02/14] mm/hmm: fix header file if/else/endif maze v2

2018-03-16 Thread jglisse
From: Jérôme Glisse The #if/#else/#endif for IS_ENABLED(CONFIG_HMM) were wrong. Because of this after multiple include there was multiple definition of both hmm_mm_init() and hmm_mm_destroy() leading to build failure if HMM was enabled (CONFIG_HMM set). Changed since v1: -

[PATCH 02/14] mm/hmm: fix header file if/else/endif maze v2

2018-03-16 Thread jglisse
From: Jérôme Glisse The #if/#else/#endif for IS_ENABLED(CONFIG_HMM) were wrong. Because of this after multiple include there was multiple definition of both hmm_mm_init() and hmm_mm_destroy() leading to build failure if HMM was enabled (CONFIG_HMM set). Changed since v1: - Fix the maze when

Re: [PATCH 02/14] mm/hmm: fix header file if/else/endif maze

2018-03-16 Thread John Hubbard
On 03/16/2018 02:35 PM, Andrew Morton wrote: > On Fri, 16 Mar 2018 17:18:02 -0400 Jerome Glisse wrote: > >> On Fri, Mar 16, 2018 at 02:09:59PM -0700, Andrew Morton wrote: >>> On Fri, 16 Mar 2018 15:14:07 -0400 jgli...@redhat.com wrote: >>> From: Jérôme Glisse

Re: [PATCH 02/14] mm/hmm: fix header file if/else/endif maze

2018-03-16 Thread John Hubbard
On 03/16/2018 02:35 PM, Andrew Morton wrote: > On Fri, 16 Mar 2018 17:18:02 -0400 Jerome Glisse wrote: > >> On Fri, Mar 16, 2018 at 02:09:59PM -0700, Andrew Morton wrote: >>> On Fri, 16 Mar 2018 15:14:07 -0400 jgli...@redhat.com wrote: >>> From: Jérôme Glisse The #if/#else/#endif

Re: [PATCH 02/14] mm/hmm: fix header file if/else/endif maze

2018-03-16 Thread Andrew Morton
On Fri, 16 Mar 2018 17:18:02 -0400 Jerome Glisse wrote: > On Fri, Mar 16, 2018 at 02:09:59PM -0700, Andrew Morton wrote: > > On Fri, 16 Mar 2018 15:14:07 -0400 jgli...@redhat.com wrote: > > > > > From: Jérôme Glisse > > > > > > The #if/#else/#endif for

Re: [PATCH 02/14] mm/hmm: fix header file if/else/endif maze

2018-03-16 Thread Andrew Morton
On Fri, 16 Mar 2018 17:18:02 -0400 Jerome Glisse wrote: > On Fri, Mar 16, 2018 at 02:09:59PM -0700, Andrew Morton wrote: > > On Fri, 16 Mar 2018 15:14:07 -0400 jgli...@redhat.com wrote: > > > > > From: Jérôme Glisse > > > > > > The #if/#else/#endif for IS_ENABLED(CONFIG_HMM) were wrong. > >

Re: [PATCH 02/14] mm/hmm: fix header file if/else/endif maze

2018-03-16 Thread Jerome Glisse
On Fri, Mar 16, 2018 at 02:09:59PM -0700, Andrew Morton wrote: > On Fri, 16 Mar 2018 15:14:07 -0400 jgli...@redhat.com wrote: > > > From: Jérôme Glisse > > > > The #if/#else/#endif for IS_ENABLED(CONFIG_HMM) were wrong. > > "were wrong" is not a sufficient explanation of

Re: [PATCH 02/14] mm/hmm: fix header file if/else/endif maze

2018-03-16 Thread Jerome Glisse
On Fri, Mar 16, 2018 at 02:09:59PM -0700, Andrew Morton wrote: > On Fri, 16 Mar 2018 15:14:07 -0400 jgli...@redhat.com wrote: > > > From: Jérôme Glisse > > > > The #if/#else/#endif for IS_ENABLED(CONFIG_HMM) were wrong. > > "were wrong" is not a sufficient explanation of the problem,

Re: [PATCH 02/14] mm/hmm: fix header file if/else/endif maze

2018-03-16 Thread Andrew Morton
On Fri, 16 Mar 2018 15:14:07 -0400 jgli...@redhat.com wrote: > From: Jérôme Glisse > > The #if/#else/#endif for IS_ENABLED(CONFIG_HMM) were wrong. "were wrong" is not a sufficient explanation of the problem, especially if we're requesting a -stable backport. Please fully

Re: [PATCH 02/14] mm/hmm: fix header file if/else/endif maze

2018-03-16 Thread Andrew Morton
On Fri, 16 Mar 2018 15:14:07 -0400 jgli...@redhat.com wrote: > From: Jérôme Glisse > > The #if/#else/#endif for IS_ENABLED(CONFIG_HMM) were wrong. "were wrong" is not a sufficient explanation of the problem, especially if we're requesting a -stable backport. Please fully describe the effects

[PATCH 02/14] mm/hmm: fix header file if/else/endif maze

2018-03-16 Thread jglisse
From: Jérôme Glisse The #if/#else/#endif for IS_ENABLED(CONFIG_HMM) were wrong. Signed-off-by: Jérôme Glisse Acked-by: Balbir Singh Cc: sta...@vger.kernel.org Cc: Andrew Morton Cc: Ralph Campbell

[PATCH 02/14] mm/hmm: fix header file if/else/endif maze

2018-03-16 Thread jglisse
From: Jérôme Glisse The #if/#else/#endif for IS_ENABLED(CONFIG_HMM) were wrong. Signed-off-by: Jérôme Glisse Acked-by: Balbir Singh Cc: sta...@vger.kernel.org Cc: Andrew Morton Cc: Ralph Campbell Cc: John Hubbard Cc: Evgeny Baskakov --- include/linux/hmm.h | 7 +++ 1 file changed, 3