Re: [PATCH 04/27] perf tools: Move programs check into config/Makefile
On Tue, 2 Apr 2013 00:27:03 +0200, Jiri Olsa wrote: > On Tue, Apr 02, 2013 at 07:09:50AM +0900, Namhyung Kim wrote: >> 2013-04-01 (월), 21:18 +0200, Jiri Olsa: >> > Moving programs check into config/Makefile. >> >> [SNIP] >> >> > +RM = rm -f >> > +MKDIR = mkdir >> > +FIND= find >> > +INSTALL = install >> > +FLEX= flex >> > +BISON = bison >> > +STRIP ?= strip >> >> Why does STRIP use "?=" form? >> >> I know you just moved the line, but AFAICS it can be converted to a >> normal variable assignment, right? > > not sure, I guess someone found usefull to use custom strip AFAIK one can override those variables on a cmdline even if it's set via normal variable assignment. Thanks, Namhyung -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 04/27] perf tools: Move programs check into config/Makefile
On Tue, Apr 02, 2013 at 07:09:50AM +0900, Namhyung Kim wrote: > 2013-04-01 (월), 21:18 +0200, Jiri Olsa: > > Moving programs check into config/Makefile. > > [SNIP] > > > +RM = rm -f > > +MKDIR = mkdir > > +FIND= find > > +INSTALL = install > > +FLEX= flex > > +BISON = bison > > +STRIP ?= strip > > Why does STRIP use "?=" form? > > I know you just moved the line, but AFAICS it can be converted to a > normal variable assignment, right? not sure, I guess someone found usefull to use custom strip > > > > @@ -140,14 +140,6 @@ ifneq ($(MAKECMDGOALS),clean) > > ifneq ($(MAKECMDGOALS),tags) > > -include config/feature-tests.mak > > > > -ifeq ($(call get-executable,$(FLEX)),) > > - dummy := $(error Error: $(FLEX) is missing on this system, please > > install it) > > -endif > > - > > -ifeq ($(call get-executable,$(BISON)),) > > - dummy := $(error Error: $(BISON) is missing on this system, please > > install it) > > -endif > > - > > ifeq ($(call try-cc,$(SOURCE_HELLO),$(CFLAGS) -Werror > > -fstack-protector-all,-fstack-protector-all),y) > > CFLAGS := $(CFLAGS) -fstack-protector-all > > endif > > diff --git a/tools/perf/config/Makefile b/tools/perf/config/Makefile > > index fe317c2..04bf8ac 100644 > > --- a/tools/perf/config/Makefile > > +++ b/tools/perf/config/Makefile > > @@ -32,3 +32,13 @@ endif > > ifeq ($(NO_PERF_REGS),0) > > BASIC_CFLAGS += -DHAVE_PERF_REGS > > endif > > + > > +-include config/feature-tests.mak > > It seems now it's redundant to include this file? The 'config/feature-tests.mak' stuff is still needed for the rest of the Makefile at this point. Althought all the checking stuff is moved with final patch into config/Makefile, I wanted middle commit to stay functional. Now I wonder if I include 'config/feature-tests.mak' from 'config/Makefile' wether it afects top level Makefile environment or not (my initial thought). I'll double check that and remove if necessary. thanks, jirka -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 04/27] perf tools: Move programs check into config/Makefile
2013-04-01 (월), 21:18 +0200, Jiri Olsa: > Moving programs check into config/Makefile. [SNIP] > +RM = rm -f > +MKDIR = mkdir > +FIND= find > +INSTALL = install > +FLEX= flex > +BISON = bison > +STRIP ?= strip Why does STRIP use "?=" form? I know you just moved the line, but AFAICS it can be converted to a normal variable assignment, right? > @@ -140,14 +140,6 @@ ifneq ($(MAKECMDGOALS),clean) > ifneq ($(MAKECMDGOALS),tags) > -include config/feature-tests.mak > > -ifeq ($(call get-executable,$(FLEX)),) > - dummy := $(error Error: $(FLEX) is missing on this system, please > install it) > -endif > - > -ifeq ($(call get-executable,$(BISON)),) > - dummy := $(error Error: $(BISON) is missing on this system, please > install it) > -endif > - > ifeq ($(call try-cc,$(SOURCE_HELLO),$(CFLAGS) -Werror > -fstack-protector-all,-fstack-protector-all),y) > CFLAGS := $(CFLAGS) -fstack-protector-all > endif > diff --git a/tools/perf/config/Makefile b/tools/perf/config/Makefile > index fe317c2..04bf8ac 100644 > --- a/tools/perf/config/Makefile > +++ b/tools/perf/config/Makefile > @@ -32,3 +32,13 @@ endif > ifeq ($(NO_PERF_REGS),0) > BASIC_CFLAGS += -DHAVE_PERF_REGS > endif > + > +-include config/feature-tests.mak It seems now it's redundant to include this file? Thanks, Namhyung -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH 04/27] perf tools: Move programs check into config/Makefile
Moving programs check into config/Makefile. Signed-off-by: Jiri Olsa Cc: Arnaldo Carvalho de Melo Cc: Peter Zijlstra Cc: Ingo Molnar Cc: Paul Mackerras Cc: Corey Ashford Cc: Frederic Weisbecker Cc: Namhyung Kim Cc: Borislav Petkov Cc: Stephane Eranian --- tools/perf/Makefile| 24 tools/perf/config/Makefile | 10 ++ 2 files changed, 18 insertions(+), 16 deletions(-) diff --git a/tools/perf/Makefile b/tools/perf/Makefile index 032e099..8dd3320 100644 --- a/tools/perf/Makefile +++ b/tools/perf/Makefile @@ -58,6 +58,14 @@ $(OUTPUT)PERF-VERSION-FILE: .FORCE-PERF-VERSION-FILE CC = $(CROSS_COMPILE)gcc AR = $(CROSS_COMPILE)ar +RM = rm -f +MKDIR = mkdir +FIND= find +INSTALL = install +FLEX= flex +BISON = bison +STRIP ?= strip + ifeq ($(filter clean tags,$(MAKECMDGOALS)),) include config/Makefile endif @@ -88,7 +96,6 @@ CFLAGS = -fno-omit-frame-pointer -ggdb3 -funwind-tables -Wall -Wextra -std=gnu99 EXTLIBS = -lpthread -lrt -lelf -lm ALL_CFLAGS = $(CFLAGS) -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64 -D_GNU_SOURCE ALL_LDFLAGS = $(LDFLAGS) -STRIP ?= strip # Among the variables below, these: # perfexecdir @@ -125,13 +132,6 @@ lib = lib export prefix bindir sharedir sysconfdir -RM = rm -f -MKDIR = mkdir -FIND = find -INSTALL = install -FLEX = flex -BISON= bison - # sparse is architecture-neutral, which means that we need to tell it # explicitly what architecture to check for. Fix this up for yours.. SPARSE_FLAGS = -D__BIG_ENDIAN__ -D__powerpc__ @@ -140,14 +140,6 @@ ifneq ($(MAKECMDGOALS),clean) ifneq ($(MAKECMDGOALS),tags) -include config/feature-tests.mak -ifeq ($(call get-executable,$(FLEX)),) - dummy := $(error Error: $(FLEX) is missing on this system, please install it) -endif - -ifeq ($(call get-executable,$(BISON)),) - dummy := $(error Error: $(BISON) is missing on this system, please install it) -endif - ifeq ($(call try-cc,$(SOURCE_HELLO),$(CFLAGS) -Werror -fstack-protector-all,-fstack-protector-all),y) CFLAGS := $(CFLAGS) -fstack-protector-all endif diff --git a/tools/perf/config/Makefile b/tools/perf/config/Makefile index fe317c2..04bf8ac 100644 --- a/tools/perf/config/Makefile +++ b/tools/perf/config/Makefile @@ -32,3 +32,13 @@ endif ifeq ($(NO_PERF_REGS),0) BASIC_CFLAGS += -DHAVE_PERF_REGS endif + +-include config/feature-tests.mak + +ifeq ($(call get-executable,$(FLEX)),) + dummy := $(error Error: $(FLEX) is missing on this system, please install it) +endif + +ifeq ($(call get-executable,$(BISON)),) + dummy := $(error Error: $(BISON) is missing on this system, please install it) +endif -- 1.7.11.7 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH 04/27] perf tools: Move programs check into config/Makefile
Moving programs check into config/Makefile. Signed-off-by: Jiri Olsa jo...@redhat.com Cc: Arnaldo Carvalho de Melo a...@ghostprotocols.net Cc: Peter Zijlstra a.p.zijls...@chello.nl Cc: Ingo Molnar mi...@elte.hu Cc: Paul Mackerras pau...@samba.org Cc: Corey Ashford cjash...@linux.vnet.ibm.com Cc: Frederic Weisbecker fweis...@gmail.com Cc: Namhyung Kim namhy...@kernel.org Cc: Borislav Petkov b...@alien8.de Cc: Stephane Eranian eran...@google.com --- tools/perf/Makefile| 24 tools/perf/config/Makefile | 10 ++ 2 files changed, 18 insertions(+), 16 deletions(-) diff --git a/tools/perf/Makefile b/tools/perf/Makefile index 032e099..8dd3320 100644 --- a/tools/perf/Makefile +++ b/tools/perf/Makefile @@ -58,6 +58,14 @@ $(OUTPUT)PERF-VERSION-FILE: .FORCE-PERF-VERSION-FILE CC = $(CROSS_COMPILE)gcc AR = $(CROSS_COMPILE)ar +RM = rm -f +MKDIR = mkdir +FIND= find +INSTALL = install +FLEX= flex +BISON = bison +STRIP ?= strip + ifeq ($(filter clean tags,$(MAKECMDGOALS)),) include config/Makefile endif @@ -88,7 +96,6 @@ CFLAGS = -fno-omit-frame-pointer -ggdb3 -funwind-tables -Wall -Wextra -std=gnu99 EXTLIBS = -lpthread -lrt -lelf -lm ALL_CFLAGS = $(CFLAGS) -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64 -D_GNU_SOURCE ALL_LDFLAGS = $(LDFLAGS) -STRIP ?= strip # Among the variables below, these: # perfexecdir @@ -125,13 +132,6 @@ lib = lib export prefix bindir sharedir sysconfdir -RM = rm -f -MKDIR = mkdir -FIND = find -INSTALL = install -FLEX = flex -BISON= bison - # sparse is architecture-neutral, which means that we need to tell it # explicitly what architecture to check for. Fix this up for yours.. SPARSE_FLAGS = -D__BIG_ENDIAN__ -D__powerpc__ @@ -140,14 +140,6 @@ ifneq ($(MAKECMDGOALS),clean) ifneq ($(MAKECMDGOALS),tags) -include config/feature-tests.mak -ifeq ($(call get-executable,$(FLEX)),) - dummy := $(error Error: $(FLEX) is missing on this system, please install it) -endif - -ifeq ($(call get-executable,$(BISON)),) - dummy := $(error Error: $(BISON) is missing on this system, please install it) -endif - ifeq ($(call try-cc,$(SOURCE_HELLO),$(CFLAGS) -Werror -fstack-protector-all,-fstack-protector-all),y) CFLAGS := $(CFLAGS) -fstack-protector-all endif diff --git a/tools/perf/config/Makefile b/tools/perf/config/Makefile index fe317c2..04bf8ac 100644 --- a/tools/perf/config/Makefile +++ b/tools/perf/config/Makefile @@ -32,3 +32,13 @@ endif ifeq ($(NO_PERF_REGS),0) BASIC_CFLAGS += -DHAVE_PERF_REGS endif + +-include config/feature-tests.mak + +ifeq ($(call get-executable,$(FLEX)),) + dummy := $(error Error: $(FLEX) is missing on this system, please install it) +endif + +ifeq ($(call get-executable,$(BISON)),) + dummy := $(error Error: $(BISON) is missing on this system, please install it) +endif -- 1.7.11.7 -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 04/27] perf tools: Move programs check into config/Makefile
2013-04-01 (월), 21:18 +0200, Jiri Olsa: Moving programs check into config/Makefile. [SNIP] +RM = rm -f +MKDIR = mkdir +FIND= find +INSTALL = install +FLEX= flex +BISON = bison +STRIP ?= strip Why does STRIP use ?= form? I know you just moved the line, but AFAICS it can be converted to a normal variable assignment, right? @@ -140,14 +140,6 @@ ifneq ($(MAKECMDGOALS),clean) ifneq ($(MAKECMDGOALS),tags) -include config/feature-tests.mak -ifeq ($(call get-executable,$(FLEX)),) - dummy := $(error Error: $(FLEX) is missing on this system, please install it) -endif - -ifeq ($(call get-executable,$(BISON)),) - dummy := $(error Error: $(BISON) is missing on this system, please install it) -endif - ifeq ($(call try-cc,$(SOURCE_HELLO),$(CFLAGS) -Werror -fstack-protector-all,-fstack-protector-all),y) CFLAGS := $(CFLAGS) -fstack-protector-all endif diff --git a/tools/perf/config/Makefile b/tools/perf/config/Makefile index fe317c2..04bf8ac 100644 --- a/tools/perf/config/Makefile +++ b/tools/perf/config/Makefile @@ -32,3 +32,13 @@ endif ifeq ($(NO_PERF_REGS),0) BASIC_CFLAGS += -DHAVE_PERF_REGS endif + +-include config/feature-tests.mak It seems now it's redundant to include this file? Thanks, Namhyung -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 04/27] perf tools: Move programs check into config/Makefile
On Tue, Apr 02, 2013 at 07:09:50AM +0900, Namhyung Kim wrote: 2013-04-01 (월), 21:18 +0200, Jiri Olsa: Moving programs check into config/Makefile. [SNIP] +RM = rm -f +MKDIR = mkdir +FIND= find +INSTALL = install +FLEX= flex +BISON = bison +STRIP ?= strip Why does STRIP use ?= form? I know you just moved the line, but AFAICS it can be converted to a normal variable assignment, right? not sure, I guess someone found usefull to use custom strip @@ -140,14 +140,6 @@ ifneq ($(MAKECMDGOALS),clean) ifneq ($(MAKECMDGOALS),tags) -include config/feature-tests.mak -ifeq ($(call get-executable,$(FLEX)),) - dummy := $(error Error: $(FLEX) is missing on this system, please install it) -endif - -ifeq ($(call get-executable,$(BISON)),) - dummy := $(error Error: $(BISON) is missing on this system, please install it) -endif - ifeq ($(call try-cc,$(SOURCE_HELLO),$(CFLAGS) -Werror -fstack-protector-all,-fstack-protector-all),y) CFLAGS := $(CFLAGS) -fstack-protector-all endif diff --git a/tools/perf/config/Makefile b/tools/perf/config/Makefile index fe317c2..04bf8ac 100644 --- a/tools/perf/config/Makefile +++ b/tools/perf/config/Makefile @@ -32,3 +32,13 @@ endif ifeq ($(NO_PERF_REGS),0) BASIC_CFLAGS += -DHAVE_PERF_REGS endif + +-include config/feature-tests.mak It seems now it's redundant to include this file? The 'config/feature-tests.mak' stuff is still needed for the rest of the Makefile at this point. Althought all the checking stuff is moved with final patch into config/Makefile, I wanted middle commit to stay functional. Now I wonder if I include 'config/feature-tests.mak' from 'config/Makefile' wether it afects top level Makefile environment or not (my initial thought). I'll double check that and remove if necessary. thanks, jirka -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 04/27] perf tools: Move programs check into config/Makefile
On Tue, 2 Apr 2013 00:27:03 +0200, Jiri Olsa wrote: On Tue, Apr 02, 2013 at 07:09:50AM +0900, Namhyung Kim wrote: 2013-04-01 (월), 21:18 +0200, Jiri Olsa: Moving programs check into config/Makefile. [SNIP] +RM = rm -f +MKDIR = mkdir +FIND= find +INSTALL = install +FLEX= flex +BISON = bison +STRIP ?= strip Why does STRIP use ?= form? I know you just moved the line, but AFAICS it can be converted to a normal variable assignment, right? not sure, I guess someone found usefull to use custom strip AFAIK one can override those variables on a cmdline even if it's set via normal variable assignment. Thanks, Namhyung -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
