Re: [PATCH 06/12] i2c: qup: proper error handling for i2c error in BAM mode

2018-03-12 Thread Abhishek Sahu
On 2018-02-28 04:28, Andy Gross wrote: On Sat, Feb 03, 2018 at 01:28:11PM +0530, Abhishek Sahu wrote: @@ -841,20 +856,12 @@ static int qup_i2c_bam_do_xfer(struct qup_i2c_dev *qup, struct i2c_msg *msg, goto desc_err; } - if (rx_buf) -

Re: [PATCH 06/12] i2c: qup: proper error handling for i2c error in BAM mode

2018-03-12 Thread Abhishek Sahu
On 2018-02-28 04:28, Andy Gross wrote: On Sat, Feb 03, 2018 at 01:28:11PM +0530, Abhishek Sahu wrote: @@ -841,20 +856,12 @@ static int qup_i2c_bam_do_xfer(struct qup_i2c_dev *qup, struct i2c_msg *msg, goto desc_err; } - if (rx_buf) -

Re: [PATCH 06/12] i2c: qup: proper error handling for i2c error in BAM mode

2018-02-27 Thread Andy Gross
On Sat, Feb 03, 2018 at 01:28:11PM +0530, Abhishek Sahu wrote: > @@ -841,20 +856,12 @@ static int qup_i2c_bam_do_xfer(struct qup_i2c_dev *qup, > struct i2c_msg *msg, > goto desc_err; > } > > - if (rx_buf) > -

Re: [PATCH 06/12] i2c: qup: proper error handling for i2c error in BAM mode

2018-02-27 Thread Andy Gross
On Sat, Feb 03, 2018 at 01:28:11PM +0530, Abhishek Sahu wrote: > @@ -841,20 +856,12 @@ static int qup_i2c_bam_do_xfer(struct qup_i2c_dev *qup, > struct i2c_msg *msg, > goto desc_err; > } > > - if (rx_buf) > -

Re: [PATCH 06/12] i2c: qup: proper error handling for i2c error in BAM mode

2018-02-27 Thread Christ, Austin
Tested on Centriq 2400 Reviewed-by: Austin Christ On 2/3/2018 12:58 AM, Abhishek Sahu wrote: Currently the i2c error handling in BAM mode is not working properly in stress condition. 1. After an error, the FIFO are being written with FLUSH and EOT tags which

Re: [PATCH 06/12] i2c: qup: proper error handling for i2c error in BAM mode

2018-02-27 Thread Christ, Austin
Tested on Centriq 2400 Reviewed-by: Austin Christ On 2/3/2018 12:58 AM, Abhishek Sahu wrote: Currently the i2c error handling in BAM mode is not working properly in stress condition. 1. After an error, the FIFO are being written with FLUSH and EOT tags which should not be required since

Re: [PATCH 06/12] i2c: qup: proper error handling for i2c error in BAM mode

2018-02-15 Thread Sricharan R
On 2/3/2018 1:28 PM, Abhishek Sahu wrote: > Currently the i2c error handling in BAM mode is not working > properly in stress condition. > > 1. After an error, the FIFO are being written with FLUSH and >EOT tags which should not be required since already these tags >have been written in

Re: [PATCH 06/12] i2c: qup: proper error handling for i2c error in BAM mode

2018-02-15 Thread Sricharan R
On 2/3/2018 1:28 PM, Abhishek Sahu wrote: > Currently the i2c error handling in BAM mode is not working > properly in stress condition. > > 1. After an error, the FIFO are being written with FLUSH and >EOT tags which should not be required since already these tags >have been written in

[PATCH 06/12] i2c: qup: proper error handling for i2c error in BAM mode

2018-02-03 Thread Abhishek Sahu
Currently the i2c error handling in BAM mode is not working properly in stress condition. 1. After an error, the FIFO are being written with FLUSH and EOT tags which should not be required since already these tags have been written in BAM descriptor itself. 2. QUP state is being moved to

[PATCH 06/12] i2c: qup: proper error handling for i2c error in BAM mode

2018-02-03 Thread Abhishek Sahu
Currently the i2c error handling in BAM mode is not working properly in stress condition. 1. After an error, the FIFO are being written with FLUSH and EOT tags which should not be required since already these tags have been written in BAM descriptor itself. 2. QUP state is being moved to