Re: [PATCH 1/2] selftests/pstore: add pstore test script for pre-reboot

Hello, I'm sorry for my late reply. Mark Salyzyn wrote: Perfectly match is an issue, since something else might be using pmsg. For instance, one of the applications that uses this interface packetizes the messages so they can be picked out from other sources that do not comply with the header

Re: [PATCH 1/2] selftests/pstore: add pstore test script for pre-reboot

Hello, I'm sorry for my late reply. Mark Salyzyn wrote: Perfectly match is an issue, since something else might be using pmsg. For instance, one of the applications that uses this interface packetizes the messages so they can be picked out from other sources that do not comply with the header

Re: [PATCH 1/2] selftests/pstore: add pstore test script for pre-reboot

On 09/14/2015 07:30 PM, Hiraku Toyooka wrote: Hello Mark, Thank you for your advise. >> +prlog -n "Checking pmsg file contains TEST_STRING ... " > Mark this as 'wish to have' OK. I'll change it to "Checking pmsg file wishes to have TEST_STRING ... ". Should I change other messages in the same

Re: [PATCH 1/2] selftests/pstore: add pstore test script for pre-reboot

On 09/14/2015 07:30 PM, Hiraku Toyooka wrote: Hello Mark, Thank you for your advise. >> +prlog -n "Checking pmsg file contains TEST_STRING ... " > Mark this as 'wish to have' OK. I'll change it to "Checking pmsg file wishes to have TEST_STRING ... ". Should I change other messages in the same

Re: [PATCH 1/2] selftests/pstore: add pstore test script for pre-reboot

s Cook Cc: LKML; Tony Luck; Linux API; Anton Vorontsov; Shuah Khan; Mark Salyzyn; Colin Cross; 阿口誠司 / AGUCHI，SEIJI Subject: Re: [PATCH 1/2] selftests/pstore: add pstore test script for pre-reboot Hello, Kees, Thank you for your advise. >> +be_msg=`dmesg | grep "pstore: Registered [a-

RE: [PATCH 1/2] selftests/pstore: add pstore test script for pre-reboot

failure case. It makes debug easy. Seiji > >> +fi > -Original Message- > From: 豊岡拓 / Toyooka，Hiraku > Sent: Tuesday, September 15, 2015 11:31 AM > To: Kees Cook > Cc: LKML; Tony Luck; Linux API; Anton Vorontsov; Shuah Khan; Mark Salyzyn; > Colin Cross; 阿口誠司

RE: [PATCH 1/2] selftests/pstore: add pstore test script for pre-reboot

failure case. It makes debug easy. Seiji > >> +fi > -Original Message- > From: 豊岡拓 / Toyooka，Hiraku > Sent: Tuesday, September 15, 2015 11:31 AM > To: Kees Cook > Cc: LKML; Tony Luck; Linux API; Anton Vorontsov; Shuah Khan; Mark Salyzyn; > Colin Cross; 阿口誠司

Re: [PATCH 1/2] selftests/pstore: add pstore test script for pre-reboot

s Cook Cc: LKML; Tony Luck; Linux API; Anton Vorontsov; Shuah Khan; Mark Salyzyn; Colin Cross; 阿口誠司 / AGUCHI，SEIJI Subject: Re: [PATCH 1/2] selftests/pstore: add pstore test script for pre-reboot Hello, Kees, Thank you for your advise. >> +be_msg=`dmesg | grep "pstore: Registered [a-

Re: [PATCH 1/2] selftests/pstore: add pstore test script for pre-reboot

Hello, Kees, Thank you for your advise. >> +be_msg=`dmesg | grep "pstore: Registered [a-zA-Z0-9]\+ as persistent store backend$"` ... > This seems unstable if the system hasn't booted recently or if stuff > is spamming dmesg. What about examining /sys/module/pstore instead? OK, I'll update

Re: [PATCH 1/2] selftests/pstore: add pstore test script for pre-reboot

Hello Mark, Thank you for your advise. >> +prlog -n "Checking pmsg file contains TEST_STRING ... " > Mark this as 'wish to have' OK. I'll change it to "Checking pmsg file wishes to have TEST_STRING ... ". Should I change other messages in the same way? > Can TEST_STRING be given an unique

Re: [PATCH 1/2] selftests/pstore: add pstore test script for pre-reboot

Hello, Kees, Thank you for your advise. >> +be_msg=`dmesg | grep "pstore: Registered [a-zA-Z0-9]\+ as persistent store backend$"` ... > This seems unstable if the system hasn't booted recently or if stuff > is spamming dmesg. What about examining /sys/module/pstore instead? OK, I'll update

Re: [PATCH 1/2] selftests/pstore: add pstore test script for pre-reboot

Hello Mark, Thank you for your advise. >> +prlog -n "Checking pmsg file contains TEST_STRING ... " > Mark this as 'wish to have' OK. I'll change it to "Checking pmsg file wishes to have TEST_STRING ... ". Should I change other messages in the same way? > Can TEST_STRING be given an unique

Re: [PATCH 1/2] selftests/pstore: add pstore test script for pre-reboot

On Tue, Sep 8, 2015 at 4:06 AM, Hiraku Toyooka wrote: > The pstore_tests script includes test cases which check pstore's > behavior before crash (and reboot). > > The test cases are currently following. > > - Check pstore backend is registered > - Check pstore console is registered > - Check

Re: [PATCH 1/2] selftests/pstore: add pstore test script for pre-reboot

On 09/08/2015 04:06 AM, Hiraku Toyooka wrote: The pstore_tests script includes test cases which check pstore's behavior before crash (and reboot). The test cases are currently following. - Check pstore backend is registered - Check pstore console is registered - Check /dev/pmsg0 exists - Write

[PATCH 1/2] selftests/pstore: add pstore test script for pre-reboot

The pstore_tests script includes test cases which check pstore's behavior before crash (and reboot). The test cases are currently following. - Check pstore backend is registered - Check pstore console is registered - Check /dev/pmsg0 exists - Write string to /dev/pmsg0 Example usage is

[PATCH 1/2] selftests/pstore: add pstore test script for pre-reboot

The pstore_tests script includes test cases which check pstore's behavior before crash (and reboot). The test cases are currently following. - Check pstore backend is registered - Check pstore console is registered - Check /dev/pmsg0 exists - Write string to /dev/pmsg0 Example usage is

Re: [PATCH 1/2] selftests/pstore: add pstore test script for pre-reboot

On 09/08/2015 04:06 AM, Hiraku Toyooka wrote: The pstore_tests script includes test cases which check pstore's behavior before crash (and reboot). The test cases are currently following. - Check pstore backend is registered - Check pstore console is registered - Check /dev/pmsg0 exists - Write

Re: [PATCH 1/2] selftests/pstore: add pstore test script for pre-reboot

On Tue, Sep 8, 2015 at 4:06 AM, Hiraku Toyooka wrote: > The pstore_tests script includes test cases which check pstore's > behavior before crash (and reboot). > > The test cases are currently following. > > - Check pstore backend is registered > - Check pstore