Re: [PATCH 1/2] slip: Fix deadlock in write_wakeup

2014-06-23 Thread Alexander Stein
On Monday 16 June 2014 19:55:04, Oliver Hartkopp wrote: > Hello Tyler, > > On 16.06.2014 04:23, Tyler Hall wrote: > > Use schedule_work() to avoid potentially taking the spinlock in > > interrupt context. > > > (..) > > > > > To deal with these issues, don't grab the lock in the wakeup

Re: [PATCH 1/2] slip: Fix deadlock in write_wakeup

2014-06-23 Thread Alexander Stein
On Monday 16 June 2014 19:55:04, Oliver Hartkopp wrote: Hello Tyler, On 16.06.2014 04:23, Tyler Hall wrote: Use schedule_work() to avoid potentially taking the spinlock in interrupt context. (..) To deal with these issues, don't grab the lock in the wakeup function by

Re: [PATCH 1/2] slip: Fix deadlock in write_wakeup

2014-06-16 Thread David Miller
From: Tyler Hall Date: Sun, 15 Jun 2014 22:23:16 -0400 > Use schedule_work() to avoid potentially taking the spinlock in > interrupt context. > > Commit cc9fa74e2a ("slip/slcan: added locking in wakeup function") added > necessary locking to the wakeup function and 367525c8c2/ddcde142be ("can:

Re: [PATCH 1/2] slip: Fix deadlock in write_wakeup

2014-06-16 Thread Oliver Hartkopp
Hello Tyler, On 16.06.2014 04:23, Tyler Hall wrote: > Use schedule_work() to avoid potentially taking the spinlock in > interrupt context. > (..) > > To deal with these issues, don't grab the lock in the wakeup function by > deferring the writeout to a workqueue. Also hold the lock during

Re: [PATCH 1/2] slip: Fix deadlock in write_wakeup

2014-06-16 Thread Oliver Hartkopp
Hello Tyler, On 16.06.2014 04:23, Tyler Hall wrote: Use schedule_work() to avoid potentially taking the spinlock in interrupt context. (..) To deal with these issues, don't grab the lock in the wakeup function by deferring the writeout to a workqueue. Also hold the lock during close

Re: [PATCH 1/2] slip: Fix deadlock in write_wakeup

2014-06-16 Thread David Miller
From: Tyler Hall tylerwh...@gmail.com Date: Sun, 15 Jun 2014 22:23:16 -0400 Use schedule_work() to avoid potentially taking the spinlock in interrupt context. Commit cc9fa74e2a (slip/slcan: added locking in wakeup function) added necessary locking to the wakeup function and

[PATCH 1/2] slip: Fix deadlock in write_wakeup

2014-06-15 Thread Tyler Hall
Use schedule_work() to avoid potentially taking the spinlock in interrupt context. Commit cc9fa74e2a ("slip/slcan: added locking in wakeup function") added necessary locking to the wakeup function and 367525c8c2/ddcde142be ("can: slcan: Fix spinlock variant") converted it to spin_lock_bh()

[PATCH 1/2] slip: Fix deadlock in write_wakeup

2014-06-15 Thread Tyler Hall
Use schedule_work() to avoid potentially taking the spinlock in interrupt context. Commit cc9fa74e2a (slip/slcan: added locking in wakeup function) added necessary locking to the wakeup function and 367525c8c2/ddcde142be (can: slcan: Fix spinlock variant) converted it to spin_lock_bh() because