Re: [PATCH 2/2] clk: pxa: fix pxa2xx_determine_rate return

2016-11-09 Thread Stephen Boyd
On 11/08, Arnd Bergmann wrote: > The new pxa2xx_determine_rate() function seems lacking in a few > regards: > > - For an exact match or no match at all, the rate is uninitialized > as reported by gcc -Wmaybe-unintialized: >drivers/clk/pxa/clk-pxa.c: In function 'pxa2xx_determine_rate': >

Re: [PATCH 2/2] clk: pxa: fix pxa2xx_determine_rate return

2016-11-09 Thread Stephen Boyd
On 11/08, Arnd Bergmann wrote: > The new pxa2xx_determine_rate() function seems lacking in a few > regards: > > - For an exact match or no match at all, the rate is uninitialized > as reported by gcc -Wmaybe-unintialized: >drivers/clk/pxa/clk-pxa.c: In function 'pxa2xx_determine_rate': >

Re: [PATCH 2/2] clk: pxa: fix pxa2xx_determine_rate return

2016-11-08 Thread Robert Jarzmik
Arnd Bergmann writes: > On Tuesday, November 8, 2016 7:01:57 PM CET Robert Jarzmik wrote: >> Arnd Bergmann writes: >> If a non-exact match is found, either by closest_below or closest_above, >> rate is >> set (rate = freqs[closest_xxx].cpll). And a couple of lines

Re: [PATCH 2/2] clk: pxa: fix pxa2xx_determine_rate return

2016-11-08 Thread Robert Jarzmik
Arnd Bergmann writes: > On Tuesday, November 8, 2016 7:01:57 PM CET Robert Jarzmik wrote: >> Arnd Bergmann writes: >> If a non-exact match is found, either by closest_below or closest_above, >> rate is >> set (rate = freqs[closest_xxx].cpll). And a couple of lines later after the >> if/else,

Re: [PATCH 2/2] clk: pxa: fix pxa2xx_determine_rate return

2016-11-08 Thread Arnd Bergmann
On Tuesday, November 8, 2016 7:01:57 PM CET Robert Jarzmik wrote: > Arnd Bergmann writes: > > > The new pxa2xx_determine_rate() function seems lacking in a few > > regards: > > > > - For an exact match or no match at all, the rate is uninitialized > > as reported by gcc

Re: [PATCH 2/2] clk: pxa: fix pxa2xx_determine_rate return

2016-11-08 Thread Arnd Bergmann
On Tuesday, November 8, 2016 7:01:57 PM CET Robert Jarzmik wrote: > Arnd Bergmann writes: > > > The new pxa2xx_determine_rate() function seems lacking in a few > > regards: > > > > - For an exact match or no match at all, the rate is uninitialized > > as reported by gcc -Wmaybe-unintialized: >

Re: [PATCH 2/2] clk: pxa: fix pxa2xx_determine_rate return

2016-11-08 Thread Robert Jarzmik
Arnd Bergmann writes: > The new pxa2xx_determine_rate() function seems lacking in a few > regards: > > - For an exact match or no match at all, the rate is uninitialized > as reported by gcc -Wmaybe-unintialized: >drivers/clk/pxa/clk-pxa.c: In function

Re: [PATCH 2/2] clk: pxa: fix pxa2xx_determine_rate return

2016-11-08 Thread Robert Jarzmik
Arnd Bergmann writes: > The new pxa2xx_determine_rate() function seems lacking in a few > regards: > > - For an exact match or no match at all, the rate is uninitialized > as reported by gcc -Wmaybe-unintialized: >drivers/clk/pxa/clk-pxa.c: In function 'pxa2xx_determine_rate': >

[PATCH 2/2] clk: pxa: fix pxa2xx_determine_rate return

2016-11-08 Thread Arnd Bergmann
The new pxa2xx_determine_rate() function seems lacking in a few regards: - For an exact match or no match at all, the rate is uninitialized as reported by gcc -Wmaybe-unintialized: drivers/clk/pxa/clk-pxa.c: In function 'pxa2xx_determine_rate': drivers/clk/pxa/clk-pxa.c:243:5: error:

[PATCH 2/2] clk: pxa: fix pxa2xx_determine_rate return

2016-11-08 Thread Arnd Bergmann
The new pxa2xx_determine_rate() function seems lacking in a few regards: - For an exact match or no match at all, the rate is uninitialized as reported by gcc -Wmaybe-unintialized: drivers/clk/pxa/clk-pxa.c: In function 'pxa2xx_determine_rate': drivers/clk/pxa/clk-pxa.c:243:5: error: