Re: [PATCH 2/2] docs: add Co-Developed-by docs
On Wed, Mar 07, 2018 at 10:16:14AM -0700, Jonathan Corbet wrote: > On Mon, 5 Mar 2018 14:58:21 +1100 > "Tobin C. Harding"wrote: > > > When Co-Developed-by tag was added, docs were only added to > > Documention/process/5.Posting.rst and were not added to > > Documention/process/submitting-patches.rst > > > > Add documentation to Documention/process/submitting-patches.rst > > Someday we should really pull those documents together into a coherent > whole so we don't have these weird synchronization issues. But it's much > easier to just apply this, so that's what I've done for now, with Willy's > comma tweak. In case you still have my patch to Documentation/process/5.Posting.rst pending, we'll have a mismatch between Co-developed-by there (which has been used a number of times in the past), and Co-Developed-by in submitting-patches.rst and checkpatch and Co-developed-by (which was used exactly once in Linus' tree). That should be coherent at least... Thanks, Dominik
Re: [PATCH 2/2] docs: add Co-Developed-by docs
On Wed, Mar 07, 2018 at 10:16:14AM -0700, Jonathan Corbet wrote: > On Mon, 5 Mar 2018 14:58:21 +1100 > "Tobin C. Harding" wrote: > > > When Co-Developed-by tag was added, docs were only added to > > Documention/process/5.Posting.rst and were not added to > > Documention/process/submitting-patches.rst > > > > Add documentation to Documention/process/submitting-patches.rst > > Someday we should really pull those documents together into a coherent > whole so we don't have these weird synchronization issues. But it's much > easier to just apply this, so that's what I've done for now, with Willy's > comma tweak. In case you still have my patch to Documentation/process/5.Posting.rst pending, we'll have a mismatch between Co-developed-by there (which has been used a number of times in the past), and Co-Developed-by in submitting-patches.rst and checkpatch and Co-developed-by (which was used exactly once in Linus' tree). That should be coherent at least... Thanks, Dominik
Re: [PATCH 2/2] docs: add Co-Developed-by docs
On Mon, 5 Mar 2018 14:58:21 +1100 "Tobin C. Harding"wrote: > When Co-Developed-by tag was added, docs were only added to > Documention/process/5.Posting.rst and were not added to > Documention/process/submitting-patches.rst > > Add documentation to Documention/process/submitting-patches.rst Someday we should really pull those documents together into a coherent whole so we don't have these weird synchronization issues. But it's much easier to just apply this, so that's what I've done for now, with Willy's comma tweak. I'll leave the checkpatch part to Joe. Thanks, jon
Re: [PATCH 2/2] docs: add Co-Developed-by docs
On Mon, 5 Mar 2018 14:58:21 +1100 "Tobin C. Harding" wrote: > When Co-Developed-by tag was added, docs were only added to > Documention/process/5.Posting.rst and were not added to > Documention/process/submitting-patches.rst > > Add documentation to Documention/process/submitting-patches.rst Someday we should really pull those documents together into a coherent whole so we don't have these weird synchronization issues. But it's much easier to just apply this, so that's what I've done for now, with Willy's comma tweak. I'll leave the checkpatch part to Joe. Thanks, jon
Re: [PATCH 2/2] docs: add Co-Developed-by docs
On Mon, Mar 05, 2018 at 04:11:35AM -0800, Matthew Wilcox wrote: > On Mon, Mar 05, 2018 at 02:58:21PM +1100, Tobin C. Harding wrote: > > -12) When to use Acked-by: and Cc: > > -- > > +12) When to use Acked-by: and Cc:, and Co-Developed-by: > > +--- > > +12) When to use Acked-by:, Cc:, and Co-Developed-by: thanks, sloppy work by me :) Tobin
Re: [PATCH 2/2] docs: add Co-Developed-by docs
On Mon, Mar 05, 2018 at 04:11:35AM -0800, Matthew Wilcox wrote: > On Mon, Mar 05, 2018 at 02:58:21PM +1100, Tobin C. Harding wrote: > > -12) When to use Acked-by: and Cc: > > -- > > +12) When to use Acked-by: and Cc:, and Co-Developed-by: > > +--- > > +12) When to use Acked-by:, Cc:, and Co-Developed-by: thanks, sloppy work by me :) Tobin
Re: [PATCH 2/2] docs: add Co-Developed-by docs
On Mon, Mar 05, 2018 at 02:58:21PM +1100, Tobin C. Harding wrote: > -12) When to use Acked-by: and Cc: > -- > +12) When to use Acked-by: and Cc:, and Co-Developed-by: > +--- +12) When to use Acked-by:, Cc:, and Co-Developed-by:
Re: [PATCH 2/2] docs: add Co-Developed-by docs
On Mon, Mar 05, 2018 at 02:58:21PM +1100, Tobin C. Harding wrote: > -12) When to use Acked-by: and Cc: > -- > +12) When to use Acked-by: and Cc:, and Co-Developed-by: > +--- +12) When to use Acked-by:, Cc:, and Co-Developed-by:
[PATCH 2/2] docs: add Co-Developed-by docs
When Co-Developed-by tag was added, docs were only added to Documention/process/5.Posting.rst and were not added to Documention/process/submitting-patches.rst Add documentation to Documention/process/submitting-patches.rst Signed-off-by: Tobin C. Harding--- The text in this patch is copied basically verbatim from Documentation/process/submitting-patches.rst Documentation/process/submitting-patches.rst | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/Documentation/process/submitting-patches.rst b/Documentation/process/submitting-patches.rst index 1ef19d3a3eee..698360641ecd 100644 --- a/Documentation/process/submitting-patches.rst +++ b/Documentation/process/submitting-patches.rst @@ -510,8 +510,8 @@ tracking your trees, and to people trying to troubleshoot bugs in your tree. -12) When to use Acked-by: and Cc: -- +12) When to use Acked-by: and Cc:, and Co-Developed-by: +--- The Signed-off-by: tag indicates that the signer was involved in the development of the patch, or that he/she was in the patch's delivery path. @@ -543,6 +543,11 @@ person it names - but it should indicate that this person was copied on the patch. This tag documents that potentially interested parties have been included in the discussion. +A Co-Developed-by: states that the patch was also created by another developer +along with the original author. This is useful at times when multiple people +work on a single patch. Note, this person also needs to have a Signed-off-by: +line in the patch as well. + 13) Using Reported-by:, Tested-by:, Reviewed-by:, Suggested-by: and Fixes: -- -- 2.7.4
[PATCH 2/2] docs: add Co-Developed-by docs
When Co-Developed-by tag was added, docs were only added to Documention/process/5.Posting.rst and were not added to Documention/process/submitting-patches.rst Add documentation to Documention/process/submitting-patches.rst Signed-off-by: Tobin C. Harding --- The text in this patch is copied basically verbatim from Documentation/process/submitting-patches.rst Documentation/process/submitting-patches.rst | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/Documentation/process/submitting-patches.rst b/Documentation/process/submitting-patches.rst index 1ef19d3a3eee..698360641ecd 100644 --- a/Documentation/process/submitting-patches.rst +++ b/Documentation/process/submitting-patches.rst @@ -510,8 +510,8 @@ tracking your trees, and to people trying to troubleshoot bugs in your tree. -12) When to use Acked-by: and Cc: -- +12) When to use Acked-by: and Cc:, and Co-Developed-by: +--- The Signed-off-by: tag indicates that the signer was involved in the development of the patch, or that he/she was in the patch's delivery path. @@ -543,6 +543,11 @@ person it names - but it should indicate that this person was copied on the patch. This tag documents that potentially interested parties have been included in the discussion. +A Co-Developed-by: states that the patch was also created by another developer +along with the original author. This is useful at times when multiple people +work on a single patch. Note, this person also needs to have a Signed-off-by: +line in the patch as well. + 13) Using Reported-by:, Tested-by:, Reviewed-by:, Suggested-by: and Fixes: -- -- 2.7.4