Re: [PATCH 2.6.11-rc3] IBM Trackpoint support

2005-02-13 Thread Dmitry Torokhov
On Sunday 13 February 2005 14:13, Stephen Evanchik wrote: > On Thu, 3 Feb 2005 22:52:44 -0500, Dmitry Torokhov > <[EMAIL PROTECTED]> wrote: > > OK, I have read the code once again, and saw that you have special > > handling within PS/2 protocol based on model constant. Please set > > psmouse type

Re: [PATCH 2.6.11-rc3] IBM Trackpoint support

2005-02-13 Thread Stephen Evanchik
On Sun, 13 Feb 2005 20:31:49 +0100, Vojtech Pavlik <[EMAIL PROTECTED]> wrote: > > You're right. The IBM trackpoints unfortunately don't have a 'native' > mode, they always do full processing and send classic PS/2 packets. > > I think we shouldn't need a handler, since we can use the PS/2 protocol

Re: [PATCH 2.6.11-rc3] IBM Trackpoint support

2005-02-13 Thread Vojtech Pavlik
On Sun, Feb 13, 2005 at 02:13:15PM -0500, Stephen Evanchik wrote: > On Thu, 3 Feb 2005 22:52:44 -0500, Dmitry Torokhov > <[EMAIL PROTECTED]> wrote: > > OK, I have read the code once again, and saw that you have special > > handling within PS/2 protocol based on model constant. Please set > >

Re: [PATCH 2.6.11-rc3] IBM Trackpoint support

2005-02-13 Thread Stephen Evanchik
On Thu, 3 Feb 2005 22:52:44 -0500, Dmitry Torokhov <[EMAIL PROTECTED]> wrote: > OK, I have read the code once again, and saw that you have special > handling within PS/2 protocol based on model constant. Please set > psmouse type to PSMOUSE_TRACKPOINT instead of model and provide full > protocol

Re: [PATCH 2.6.11-rc3] IBM Trackpoint support

2005-02-13 Thread Vojtech Pavlik
On Sun, Feb 13, 2005 at 02:07:39PM -0500, Stephen Evanchik wrote: > > > Perhaps this should be done in userspace? It is probably usable on > > > non-trackpoint devices, too... > > > > For a big part it's not possible to do in userspace, because the > > touchpoint doesn't give the pressure

Re: [PATCH 2.6.11-rc3] IBM Trackpoint support

2005-02-13 Thread Stephen Evanchik
On Mon, 7 Feb 2005 11:14:17 +0100, Vojtech Pavlik <[EMAIL PROTECTED]> wrote: > > Perhaps this should be done in userspace? It is probably usable on > > non-trackpoint devices, too... > > For a big part it's not possible to do in userspace, because the > touchpoint doesn't give the pressure

Re: [PATCH 2.6.11-rc3] IBM Trackpoint support

2005-02-13 Thread Stephen Evanchik
On Mon, 7 Feb 2005 11:14:17 +0100, Vojtech Pavlik [EMAIL PROTECTED] wrote: Perhaps this should be done in userspace? It is probably usable on non-trackpoint devices, too... For a big part it's not possible to do in userspace, because the touchpoint doesn't give the pressure information, it

Re: [PATCH 2.6.11-rc3] IBM Trackpoint support

2005-02-13 Thread Vojtech Pavlik
On Sun, Feb 13, 2005 at 02:07:39PM -0500, Stephen Evanchik wrote: Perhaps this should be done in userspace? It is probably usable on non-trackpoint devices, too... For a big part it's not possible to do in userspace, because the touchpoint doesn't give the pressure information, it

Re: [PATCH 2.6.11-rc3] IBM Trackpoint support

2005-02-13 Thread Stephen Evanchik
On Thu, 3 Feb 2005 22:52:44 -0500, Dmitry Torokhov [EMAIL PROTECTED] wrote: OK, I have read the code once again, and saw that you have special handling within PS/2 protocol based on model constant. Please set psmouse type to PSMOUSE_TRACKPOINT instead of model and provide full protocol

Re: [PATCH 2.6.11-rc3] IBM Trackpoint support

2005-02-13 Thread Vojtech Pavlik
On Sun, Feb 13, 2005 at 02:13:15PM -0500, Stephen Evanchik wrote: On Thu, 3 Feb 2005 22:52:44 -0500, Dmitry Torokhov [EMAIL PROTECTED] wrote: OK, I have read the code once again, and saw that you have special handling within PS/2 protocol based on model constant. Please set psmouse type

Re: [PATCH 2.6.11-rc3] IBM Trackpoint support

2005-02-13 Thread Stephen Evanchik
On Sun, 13 Feb 2005 20:31:49 +0100, Vojtech Pavlik [EMAIL PROTECTED] wrote: You're right. The IBM trackpoints unfortunately don't have a 'native' mode, they always do full processing and send classic PS/2 packets. I think we shouldn't need a handler, since we can use the PS/2 protocol one.

Re: [PATCH 2.6.11-rc3] IBM Trackpoint support

2005-02-13 Thread Dmitry Torokhov
On Sunday 13 February 2005 14:13, Stephen Evanchik wrote: On Thu, 3 Feb 2005 22:52:44 -0500, Dmitry Torokhov [EMAIL PROTECTED] wrote: OK, I have read the code once again, and saw that you have special handling within PS/2 protocol based on model constant. Please set psmouse type to

Re: [PATCH 2.6.11-rc3] IBM Trackpoint support

2005-02-07 Thread Vojtech Pavlik
On Sat, Feb 05, 2005 at 11:44:05AM +0100, Pavel Machek wrote: > > Here is a patch that exposes the IBM TrackPoint's extended properties > > as well as scroll wheel emulation. > > > > > > I would appreciate comments and suggestions to make this more acceptable. > > > > Perhaps this should be

Re: [PATCH 2.6.11-rc3] IBM Trackpoint support

2005-02-07 Thread Vojtech Pavlik
On Sat, Feb 05, 2005 at 11:44:05AM +0100, Pavel Machek wrote: Here is a patch that exposes the IBM TrackPoint's extended properties as well as scroll wheel emulation. I would appreciate comments and suggestions to make this more acceptable. Perhaps this should be done in

Re: [PATCH 2.6.11-rc3] IBM Trackpoint support

2005-02-06 Thread Domen Puncer
I'm a bit late, sorry. Haven't seen these mentioned in replies: On 03/02/05 17:43 -0500, Stephen Evanchik wrote: > +int tp_sens = TP_DEF_SENS; > +module_param_named(sens, tp_sens, uint, 0); > +MODULE_PARM_DESC(sens, "Sensitivity"); I don't see out-of-file usages... these could be static. ... >

Re: [PATCH 2.6.11-rc3] IBM Trackpoint support

2005-02-06 Thread Domen Puncer
I'm a bit late, sorry. Haven't seen these mentioned in replies: On 03/02/05 17:43 -0500, Stephen Evanchik wrote: +int tp_sens = TP_DEF_SENS; +module_param_named(sens, tp_sens, uint, 0); +MODULE_PARM_DESC(sens, Sensitivity); I don't see out-of-file usages... these could be static. ... +

Re: [PATCH 2.6.11-rc3] IBM Trackpoint support

2005-02-05 Thread Vojtech Pavlik
On Sat, Feb 05, 2005 at 01:56:07AM -0500, Dmitry Torokhov wrote: > On Friday 04 February 2005 09:45, Vojtech Pavlik wrote: > > On Fri, Feb 04, 2005 at 09:17:33AM -0500, Dmitry Torokhov wrote: > > > > > It is still a problem if driver is registered after the port has been > > > detected wich

Re: [PATCH 2.6.11-rc3] IBM Trackpoint support

2005-02-05 Thread Pavel Machek
Hi! > Here is a patch that exposes the IBM TrackPoint's extended properties > as well as scroll wheel emulation. > > > I would appreciate comments and suggestions to make this more acceptable. > > > Stephen > > > diff -uNr a/drivers/input/mouse/Makefile b/drivers/input/mouse/Makefile > ---

Re: [PATCH 2.6.11-rc3] IBM Trackpoint support

2005-02-05 Thread Pavel Machek
Hi! Here is a patch that exposes the IBM TrackPoint's extended properties as well as scroll wheel emulation. I would appreciate comments and suggestions to make this more acceptable. Stephen diff -uNr a/drivers/input/mouse/Makefile b/drivers/input/mouse/Makefile ---

Re: [PATCH 2.6.11-rc3] IBM Trackpoint support

2005-02-05 Thread Vojtech Pavlik
On Sat, Feb 05, 2005 at 01:56:07AM -0500, Dmitry Torokhov wrote: On Friday 04 February 2005 09:45, Vojtech Pavlik wrote: On Fri, Feb 04, 2005 at 09:17:33AM -0500, Dmitry Torokhov wrote: It is still a problem if driver is registered after the port has been detected wich quite often is

Re: [PATCH 2.6.11-rc3] IBM Trackpoint support

2005-02-04 Thread Dmitry Torokhov
On Friday 04 February 2005 09:45, Vojtech Pavlik wrote: > On Fri, Feb 04, 2005 at 09:17:33AM -0500, Dmitry Torokhov wrote: > > > It is still a problem if driver is registered after the port has been > > detected wich quite often is the case as many people have psmouse as a > > module. > > > > I

Re: [PATCH 2.6.11-rc3] IBM Trackpoint support

2005-02-04 Thread Vojtech Pavlik
On Fri, Feb 04, 2005 at 09:17:33AM -0500, Dmitry Torokhov wrote: > It is still a problem if driver is registered after the port has been > detected wich quite often is the case as many people have psmouse as a > module. > > I wonder if we should make driver registration asynchronous too.

Re: [PATCH 2.6.11-rc3] IBM Trackpoint support

2005-02-04 Thread Dmitry Torokhov
On Fri, 4 Feb 2005 07:54:54 +0100, Vojtech Pavlik <[EMAIL PROTECTED]> wrote: > On Fri, Feb 04, 2005 at 01:52:39AM -0500, Dmitry Torokhov wrote: > > On Friday 04 February 2005 01:35, Vojtech Pavlik wrote: > > > On Thu, Feb 03, 2005 at 07:34:16PM -0500, Dmitry Torokhov wrote: > > > > On Thursday 03

Re: [PATCH 2.6.11-rc3] IBM Trackpoint support

2005-02-04 Thread Dmitry Torokhov
On Fri, 4 Feb 2005 14:45:28 +0100, Vojtech Pavlik <[EMAIL PROTECTED]> wrote: > On Fri, Feb 04, 2005 at 08:17:43AM -0500, Stephen Evanchik wrote: > > On Fri, 4 Feb 2005 07:35:20 +0100, Vojtech Pavlik <[EMAIL PROTECTED]> wrote: > > > Indeed. IIRC this patch killed wheel mouse detection in ubuntu. >

Re: [PATCH 2.6.11-rc3] IBM Trackpoint support

2005-02-04 Thread Vojtech Pavlik
On Fri, Feb 04, 2005 at 08:17:43AM -0500, Stephen Evanchik wrote: > On Fri, 4 Feb 2005 07:35:20 +0100, Vojtech Pavlik <[EMAIL PROTECTED]> wrote: > > > > /* > > > > + * Try to initialize the IBM TrackPoint > > > > + */ > > > > + if (max_proto > PSMOUSE_PS2 && trackpoint_init(psmouse) == 0) { > >

Re: [PATCH 2.6.11-rc3] IBM Trackpoint support

2005-02-04 Thread Stephen Evanchik
On Fri, 4 Feb 2005 07:35:20 +0100, Vojtech Pavlik <[EMAIL PROTECTED]> wrote: > > > /* > > > + * Try to initialize the IBM TrackPoint > > > + */ > > > + if (max_proto > PSMOUSE_PS2 && trackpoint_init(psmouse) == 0) { > > > + psmouse->vendor = "IBM"; > > > + psmouse->name =

Re: [PATCH 2.6.11-rc3] IBM Trackpoint support

2005-02-04 Thread Dmitry Torokhov
On Friday 04 February 2005 09:45, Vojtech Pavlik wrote: On Fri, Feb 04, 2005 at 09:17:33AM -0500, Dmitry Torokhov wrote: It is still a problem if driver is registered after the port has been detected wich quite often is the case as many people have psmouse as a module. I wonder if

Re: [PATCH 2.6.11-rc3] IBM Trackpoint support

2005-02-04 Thread Stephen Evanchik
On Fri, 4 Feb 2005 07:35:20 +0100, Vojtech Pavlik [EMAIL PROTECTED] wrote: /* + * Try to initialize the IBM TrackPoint + */ + if (max_proto PSMOUSE_PS2 trackpoint_init(psmouse) == 0) { + psmouse-vendor = IBM; + psmouse-name = TrackPoint; + +

Re: [PATCH 2.6.11-rc3] IBM Trackpoint support

2005-02-04 Thread Vojtech Pavlik
On Fri, Feb 04, 2005 at 08:17:43AM -0500, Stephen Evanchik wrote: On Fri, 4 Feb 2005 07:35:20 +0100, Vojtech Pavlik [EMAIL PROTECTED] wrote: /* + * Try to initialize the IBM TrackPoint + */ + if (max_proto PSMOUSE_PS2 trackpoint_init(psmouse) == 0) { +

Re: [PATCH 2.6.11-rc3] IBM Trackpoint support

2005-02-04 Thread Dmitry Torokhov
On Fri, 4 Feb 2005 14:45:28 +0100, Vojtech Pavlik [EMAIL PROTECTED] wrote: On Fri, Feb 04, 2005 at 08:17:43AM -0500, Stephen Evanchik wrote: On Fri, 4 Feb 2005 07:35:20 +0100, Vojtech Pavlik [EMAIL PROTECTED] wrote: Indeed. IIRC this patch killed wheel mouse detection in ubuntu. Earlier

Re: [PATCH 2.6.11-rc3] IBM Trackpoint support

2005-02-04 Thread Dmitry Torokhov
On Fri, 4 Feb 2005 07:54:54 +0100, Vojtech Pavlik [EMAIL PROTECTED] wrote: On Fri, Feb 04, 2005 at 01:52:39AM -0500, Dmitry Torokhov wrote: On Friday 04 February 2005 01:35, Vojtech Pavlik wrote: On Thu, Feb 03, 2005 at 07:34:16PM -0500, Dmitry Torokhov wrote: On Thursday 03 February

Re: [PATCH 2.6.11-rc3] IBM Trackpoint support

2005-02-04 Thread Vojtech Pavlik
On Fri, Feb 04, 2005 at 09:17:33AM -0500, Dmitry Torokhov wrote: It is still a problem if driver is registered after the port has been detected wich quite often is the case as many people have psmouse as a module. I wonder if we should make driver registration asynchronous too. Probably

Re: [PATCH 2.6.11-rc3] IBM Trackpoint support

2005-02-03 Thread Dmitry Torokhov
On Friday 04 February 2005 01:35, Vojtech Pavlik wrote: > On Thu, Feb 03, 2005 at 07:34:16PM -0500, Dmitry Torokhov wrote: > > On Thursday 03 February 2005 17:43, Stephen Evanchik wrote: > > > Vojtech, > > > > > > Here is a patch that exposes the IBM TrackPoint's extended properties > > > as well

Re: [PATCH 2.6.11-rc3] IBM Trackpoint support

2005-02-03 Thread Vojtech Pavlik
On Fri, Feb 04, 2005 at 01:52:39AM -0500, Dmitry Torokhov wrote: > On Friday 04 February 2005 01:35, Vojtech Pavlik wrote: > > On Thu, Feb 03, 2005 at 07:34:16PM -0500, Dmitry Torokhov wrote: > > > On Thursday 03 February 2005 17:43, Stephen Evanchik wrote: > > > > Vojtech, > > > > > > > > Here

Re: [PATCH 2.6.11-rc3] IBM Trackpoint support

2005-02-03 Thread Fabio Massimo Di Nitto
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Vojtech Pavlik wrote: | On Thu, Feb 03, 2005 at 07:34:16PM -0500, Dmitry Torokhov wrote: | |>On Thursday 03 February 2005 17:43, Stephen Evanchik wrote: |> |>>Vojtech, |>> |>>Here is a patch that exposes the IBM TrackPoint's extended properties |>>as

Re: [PATCH 2.6.11-rc3] IBM Trackpoint support

2005-02-03 Thread Vojtech Pavlik
On Thu, Feb 03, 2005 at 07:34:16PM -0500, Dmitry Torokhov wrote: > On Thursday 03 February 2005 17:43, Stephen Evanchik wrote: > > Vojtech, > > > > Here is a patch that exposes the IBM TrackPoint's extended properties > > as well as scroll wheel emulation. > > > > > > Hi, > > Very nice

Re: [PATCH 2.6.11-rc3] IBM Trackpoint support

2005-02-03 Thread Stephen Evanchik
On Thu, 3 Feb 2005 22:52:44 -0500, Dmitry Torokhov <[EMAIL PROTECTED]> wrote: > OK, I have read the code once again, and saw that you have special > handling within PS/2 protocol based on model constant. Please set > psmouse type to PSMOUSE_TRACKPOINT instead of model and provide full > protocol

Re: [PATCH 2.6.11-rc3] IBM Trackpoint support

2005-02-03 Thread Dmitry Torokhov
On Thursday 03 February 2005 19:34, Dmitry Torokhov wrote: > On Thursday 03 February 2005 17:43, Stephen Evanchik wrote: > > Vojtech, > > > > Here is a patch that exposes the IBM TrackPoint's extended properties > > as well as scroll wheel emulation. > > > > > > Hi, > > Very nice although I

Re: [PATCH 2.6.11-rc3] IBM Trackpoint support

2005-02-03 Thread Dmitry Torokhov
On Thursday 03 February 2005 17:43, Stephen Evanchik wrote: > Vojtech, > > Here is a patch that exposes the IBM TrackPoint's extended properties > as well as scroll wheel emulation. > > Hi, Very nice although I have a couple of comments. > /* > + * Try to initialize the IBM TrackPoint > +

[PATCH 2.6.11-rc3] IBM Trackpoint support

2005-02-03 Thread Stephen Evanchik
Vojtech, Here is a patch that exposes the IBM TrackPoint's extended properties as well as scroll wheel emulation. I would appreciate comments and suggestions to make this more acceptable. Stephen diff -uNr a/drivers/input/mouse/Makefile b/drivers/input/mouse/Makefile ---

[PATCH 2.6.11-rc3] IBM Trackpoint support

2005-02-03 Thread Stephen Evanchik
Vojtech, Here is a patch that exposes the IBM TrackPoint's extended properties as well as scroll wheel emulation. I would appreciate comments and suggestions to make this more acceptable. Stephen diff -uNr a/drivers/input/mouse/Makefile b/drivers/input/mouse/Makefile ---

Re: [PATCH 2.6.11-rc3] IBM Trackpoint support

2005-02-03 Thread Dmitry Torokhov
On Thursday 03 February 2005 17:43, Stephen Evanchik wrote: Vojtech, Here is a patch that exposes the IBM TrackPoint's extended properties as well as scroll wheel emulation. Hi, Very nice although I have a couple of comments. /* + * Try to initialize the IBM TrackPoint + */ +

Re: [PATCH 2.6.11-rc3] IBM Trackpoint support

2005-02-03 Thread Dmitry Torokhov
On Thursday 03 February 2005 19:34, Dmitry Torokhov wrote: On Thursday 03 February 2005 17:43, Stephen Evanchik wrote: Vojtech, Here is a patch that exposes the IBM TrackPoint's extended properties as well as scroll wheel emulation. Hi, Very nice although I have a couple of

Re: [PATCH 2.6.11-rc3] IBM Trackpoint support

2005-02-03 Thread Stephen Evanchik
On Thu, 3 Feb 2005 22:52:44 -0500, Dmitry Torokhov [EMAIL PROTECTED] wrote: OK, I have read the code once again, and saw that you have special handling within PS/2 protocol based on model constant. Please set psmouse type to PSMOUSE_TRACKPOINT instead of model and provide full protocol

Re: [PATCH 2.6.11-rc3] IBM Trackpoint support

2005-02-03 Thread Vojtech Pavlik
On Thu, Feb 03, 2005 at 07:34:16PM -0500, Dmitry Torokhov wrote: On Thursday 03 February 2005 17:43, Stephen Evanchik wrote: Vojtech, Here is a patch that exposes the IBM TrackPoint's extended properties as well as scroll wheel emulation. Hi, Very nice although I have a

Re: [PATCH 2.6.11-rc3] IBM Trackpoint support

2005-02-03 Thread Fabio Massimo Di Nitto
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Vojtech Pavlik wrote: | On Thu, Feb 03, 2005 at 07:34:16PM -0500, Dmitry Torokhov wrote: | |On Thursday 03 February 2005 17:43, Stephen Evanchik wrote: | |Vojtech, | |Here is a patch that exposes the IBM TrackPoint's extended properties |as well as

Re: [PATCH 2.6.11-rc3] IBM Trackpoint support

2005-02-03 Thread Vojtech Pavlik
On Fri, Feb 04, 2005 at 01:52:39AM -0500, Dmitry Torokhov wrote: On Friday 04 February 2005 01:35, Vojtech Pavlik wrote: On Thu, Feb 03, 2005 at 07:34:16PM -0500, Dmitry Torokhov wrote: On Thursday 03 February 2005 17:43, Stephen Evanchik wrote: Vojtech, Here is a patch that

Re: [PATCH 2.6.11-rc3] IBM Trackpoint support

2005-02-03 Thread Dmitry Torokhov
On Friday 04 February 2005 01:35, Vojtech Pavlik wrote: On Thu, Feb 03, 2005 at 07:34:16PM -0500, Dmitry Torokhov wrote: On Thursday 03 February 2005 17:43, Stephen Evanchik wrote: Vojtech, Here is a patch that exposes the IBM TrackPoint's extended properties as well as scroll