On Fri 2014-11-14 23:59:07, Steven Rostedt wrote:
> From: "Steven Rostedt (Red Hat)"
>
> Add a seq_buf_can_fit() helper function that removes the possible mistakes
> of comparing the seq_buf length plus added data compared to the size of
> the buffer.
>
> Signed-off-by: Steven Rostedt
On Fri 2014-11-14 23:59:07, Steven Rostedt wrote:
From: Steven Rostedt (Red Hat) rost...@goodmis.org
Add a seq_buf_can_fit() helper function that removes the possible mistakes
of comparing the seq_buf length plus added data compared to the size of
the buffer.
Signed-off-by: Steven Rostedt
On Mon, 17 Nov 2014 18:50:52 -0800
Joe Perches wrote:
> On Mon, 2014-11-17 at 21:37 -0500, Steven Rostedt wrote:
> > On Mon, 17 Nov 2014 17:48:37 -0800
> > Joe Perches wrote:
> > > On Mon, 2014-11-17 at 20:24 -0500, Steven Rostedt wrote:
> > > > On Mon, 17 Nov 2014 17:07:58 -0800
> > > > Joe
On Mon, 2014-11-17 at 21:37 -0500, Steven Rostedt wrote:
> On Mon, 17 Nov 2014 17:48:37 -0800
> Joe Perches wrote:
> > On Mon, 2014-11-17 at 20:24 -0500, Steven Rostedt wrote:
> > > On Mon, 17 Nov 2014 17:07:58 -0800
> > > Joe Perches wrote:
> > > > > Look at the next patch.
> > > > I don't have
On Mon, 17 Nov 2014 17:48:37 -0800
Joe Perches wrote:
> On Mon, 2014-11-17 at 20:24 -0500, Steven Rostedt wrote:
> > On Mon, 17 Nov 2014 17:07:58 -0800
> > Joe Perches wrote:
> > > > Look at the next patch.
> > > I don't have it and you are not cc'ing me.
> > It's on LKML.
>
> And? There's no
On Mon, 2014-11-17 at 20:24 -0500, Steven Rostedt wrote:
> On Mon, 17 Nov 2014 17:07:58 -0800
> Joe Perches wrote:
> > > Look at the next patch.
> > I don't have it and you are not cc'ing me.
> It's on LKML.
And? There's no convenient way to retrieve it.
> > I think you are getting carried
On Mon, 17 Nov 2014 17:07:58 -0800
Joe Perches wrote:
> > Look at the next patch.
>
> I don't have it and you are not cc'ing me.
It's on LKML.
> I think you are getting carried away with the helpers.
That's nice.
>
> > > I don't see it making mistakes more or less
> > > likely, I just see
On Mon, 2014-11-17 at 19:56 -0500, Steven Rostedt wrote:
> On Mon, 17 Nov 2014 16:35:32 -0800
> Joe Perches wrote:
>
>
> > What "logic" does it place in one place and
> > how does it matter?
>
> Look at the next patch.
I don't have it and you are not cc'ing me.
I think you are getting
On Mon, 17 Nov 2014 16:35:32 -0800
Joe Perches wrote:
> What "logic" does it place in one place and
> how does it matter?
Look at the next patch.
>
> I don't see it making mistakes more or less
> likely, I just see it being used to avoid
> setting the overflow state which seems like
> more
On Mon, 2014-11-17 at 19:27 -0500, Steven Rostedt wrote:
> On Mon, 17 Nov 2014 16:07:33 -0800
> Joe Perches wrote:
>
> > On Mon, 2014-11-17 at 12:36 -0500, Steven Rostedt wrote:
> > > On Fri, 14 Nov 2014 23:59:07 -0500
> > > Steven Rostedt wrote:
> > >
> > > > From: "Steven Rostedt (Red Hat)"
On Mon, 17 Nov 2014 16:07:33 -0800
Joe Perches wrote:
> On Mon, 2014-11-17 at 12:36 -0500, Steven Rostedt wrote:
> > On Fri, 14 Nov 2014 23:59:07 -0500
> > Steven Rostedt wrote:
> >
> > > From: "Steven Rostedt (Red Hat)"
> > >
> > > Add a seq_buf_can_fit() helper function that removes the
On Mon, 2014-11-17 at 12:36 -0500, Steven Rostedt wrote:
> On Fri, 14 Nov 2014 23:59:07 -0500
> Steven Rostedt wrote:
>
> > From: "Steven Rostedt (Red Hat)"
> >
> > Add a seq_buf_can_fit() helper function that removes the possible mistakes
> > of comparing the seq_buf length plus added data
On Fri, 14 Nov 2014 23:59:07 -0500
Steven Rostedt wrote:
> From: "Steven Rostedt (Red Hat)"
>
> Add a seq_buf_can_fit() helper function that removes the possible mistakes
> of comparing the seq_buf length plus added data compared to the size of
> the buffer.
>
> Signed-off-by: Steven Rostedt
On Fri, 14 Nov 2014 23:59:07 -0500
Steven Rostedt rost...@goodmis.org wrote:
From: Steven Rostedt (Red Hat) rost...@goodmis.org
Add a seq_buf_can_fit() helper function that removes the possible mistakes
of comparing the seq_buf length plus added data compared to the size of
the buffer.
On Mon, 2014-11-17 at 12:36 -0500, Steven Rostedt wrote:
On Fri, 14 Nov 2014 23:59:07 -0500
Steven Rostedt rost...@goodmis.org wrote:
From: Steven Rostedt (Red Hat) rost...@goodmis.org
Add a seq_buf_can_fit() helper function that removes the possible mistakes
of comparing the seq_buf
On Mon, 17 Nov 2014 16:07:33 -0800
Joe Perches j...@perches.com wrote:
On Mon, 2014-11-17 at 12:36 -0500, Steven Rostedt wrote:
On Fri, 14 Nov 2014 23:59:07 -0500
Steven Rostedt rost...@goodmis.org wrote:
From: Steven Rostedt (Red Hat) rost...@goodmis.org
Add a seq_buf_can_fit()
On Mon, 2014-11-17 at 19:27 -0500, Steven Rostedt wrote:
On Mon, 17 Nov 2014 16:07:33 -0800
Joe Perches j...@perches.com wrote:
On Mon, 2014-11-17 at 12:36 -0500, Steven Rostedt wrote:
On Fri, 14 Nov 2014 23:59:07 -0500
Steven Rostedt rost...@goodmis.org wrote:
From: Steven
On Mon, 17 Nov 2014 16:35:32 -0800
Joe Perches j...@perches.com wrote:
What logic does it place in one place and
how does it matter?
Look at the next patch.
I don't see it making mistakes more or less
likely, I just see it being used to avoid
setting the overflow state which seems like
On Mon, 2014-11-17 at 19:56 -0500, Steven Rostedt wrote:
On Mon, 17 Nov 2014 16:35:32 -0800
Joe Perches j...@perches.com wrote:
What logic does it place in one place and
how does it matter?
Look at the next patch.
I don't have it and you are not cc'ing me.
I think you are getting
On Mon, 17 Nov 2014 17:07:58 -0800
Joe Perches j...@perches.com wrote:
Look at the next patch.
I don't have it and you are not cc'ing me.
It's on LKML.
I think you are getting carried away with the helpers.
That's nice.
I don't see it making mistakes more or less
likely, I just
On Mon, 2014-11-17 at 20:24 -0500, Steven Rostedt wrote:
On Mon, 17 Nov 2014 17:07:58 -0800
Joe Perches j...@perches.com wrote:
Look at the next patch.
I don't have it and you are not cc'ing me.
It's on LKML.
And? There's no convenient way to retrieve it.
I think you are getting
On Mon, 17 Nov 2014 17:48:37 -0800
Joe Perches j...@perches.com wrote:
On Mon, 2014-11-17 at 20:24 -0500, Steven Rostedt wrote:
On Mon, 17 Nov 2014 17:07:58 -0800
Joe Perches j...@perches.com wrote:
Look at the next patch.
I don't have it and you are not cc'ing me.
It's on LKML.
On Mon, 2014-11-17 at 21:37 -0500, Steven Rostedt wrote:
On Mon, 17 Nov 2014 17:48:37 -0800
Joe Perches j...@perches.com wrote:
On Mon, 2014-11-17 at 20:24 -0500, Steven Rostedt wrote:
On Mon, 17 Nov 2014 17:07:58 -0800
Joe Perches j...@perches.com wrote:
Look at the next patch.
On Mon, 17 Nov 2014 18:50:52 -0800
Joe Perches j...@perches.com wrote:
On Mon, 2014-11-17 at 21:37 -0500, Steven Rostedt wrote:
On Mon, 17 Nov 2014 17:48:37 -0800
Joe Perches j...@perches.com wrote:
On Mon, 2014-11-17 at 20:24 -0500, Steven Rostedt wrote:
On Mon, 17 Nov 2014 17:07:58
From: "Steven Rostedt (Red Hat)"
Add a seq_buf_can_fit() helper function that removes the possible mistakes
of comparing the seq_buf length plus added data compared to the size of
the buffer.
Signed-off-by: Steven Rostedt
---
kernel/trace/seq_buf.c | 15 ++-
1 file changed, 10
From: Steven Rostedt (Red Hat) rost...@goodmis.org
Add a seq_buf_can_fit() helper function that removes the possible mistakes
of comparing the seq_buf length plus added data compared to the size of
the buffer.
Signed-off-by: Steven Rostedt rost...@goodmis.org
---
kernel/trace/seq_buf.c | 15
26 matches
Mail list logo
