Re: [PATCH 3/3] tools/perf/jvmti: generate correct debug information for inlined code

2017-12-06 Thread Stephane Eranian
Hi, On Wed, Nov 29, 2017 at 8:27 AM, Ben Gainey wrote: > On Wed, 2017-11-29 at 05:02 -0800, Stephane Eranian wrote: >> On Thu, Nov 23, 2017 at 7:22 AM, Arnaldo Carvalho de Melo >> wrote: >> > >> > Em Wed, Nov 22, 2017 at 06:25:41PM -0600, Kim Phillips

Re: [PATCH 3/3] tools/perf/jvmti: generate correct debug information for inlined code

2017-12-06 Thread Stephane Eranian
Hi, On Wed, Nov 29, 2017 at 8:27 AM, Ben Gainey wrote: > On Wed, 2017-11-29 at 05:02 -0800, Stephane Eranian wrote: >> On Thu, Nov 23, 2017 at 7:22 AM, Arnaldo Carvalho de Melo >> wrote: >> > >> > Em Wed, Nov 22, 2017 at 06:25:41PM -0600, Kim Phillips escreveu: >> > > From: Ben Gainey >> > >

Re: [PATCH 3/3] tools/perf/jvmti: generate correct debug information for inlined code

2017-11-29 Thread Ben Gainey
On Wed, 2017-11-29 at 05:02 -0800, Stephane Eranian wrote: > On Thu, Nov 23, 2017 at 7:22 AM, Arnaldo Carvalho de Melo > wrote: > > > > Em Wed, Nov 22, 2017 at 06:25:41PM -0600, Kim Phillips escreveu: > > > From: Ben Gainey > > > @@ -405,7 +405,9 @@

Re: [PATCH 3/3] tools/perf/jvmti: generate correct debug information for inlined code

2017-11-29 Thread Ben Gainey
On Wed, 2017-11-29 at 05:02 -0800, Stephane Eranian wrote: > On Thu, Nov 23, 2017 at 7:22 AM, Arnaldo Carvalho de Melo > wrote: > > > > Em Wed, Nov 22, 2017 at 06:25:41PM -0600, Kim Phillips escreveu: > > > From: Ben Gainey > > > @@ -405,7 +405,9 @@ jvmti_write_debug_info(void *agent, uint64_t >

Re: [PATCH 3/3] tools/perf/jvmti: generate correct debug information for inlined code

2017-11-29 Thread Stephane Eranian
On Thu, Nov 23, 2017 at 7:22 AM, Arnaldo Carvalho de Melo wrote: > > Em Wed, Nov 22, 2017 at 06:25:41PM -0600, Kim Phillips escreveu: > > From: Ben Gainey > > @@ -405,7 +405,9 @@ jvmti_write_debug_info(void *agent, uint64_t code, > > const char *file, > >

Re: [PATCH 3/3] tools/perf/jvmti: generate correct debug information for inlined code

2017-11-29 Thread Stephane Eranian
On Thu, Nov 23, 2017 at 7:22 AM, Arnaldo Carvalho de Melo wrote: > > Em Wed, Nov 22, 2017 at 06:25:41PM -0600, Kim Phillips escreveu: > > From: Ben Gainey > > @@ -405,7 +405,9 @@ jvmti_write_debug_info(void *agent, uint64_t code, > > const char *file, > > return -1; > > } >

Re: [PATCH 3/3] tools/perf/jvmti: generate correct debug information for inlined code

2017-11-23 Thread Arnaldo Carvalho de Melo
Em Wed, Nov 22, 2017 at 06:25:41PM -0600, Kim Phillips escreveu: > From: Ben Gainey > @@ -405,7 +405,9 @@ jvmti_write_debug_info(void *agent, uint64_t code, const > char *file, > return -1; > } > > - flen = strlen(file) + 1; > + for (i = 0; i <

Re: [PATCH 3/3] tools/perf/jvmti: generate correct debug information for inlined code

2017-11-23 Thread Arnaldo Carvalho de Melo
Em Wed, Nov 22, 2017 at 06:25:41PM -0600, Kim Phillips escreveu: > From: Ben Gainey > @@ -405,7 +405,9 @@ jvmti_write_debug_info(void *agent, uint64_t code, const > char *file, > return -1; > } > > - flen = strlen(file) + 1; > + for (i = 0; i < nr_lines; ++i) { > +

[PATCH 3/3] tools/perf/jvmti: generate correct debug information for inlined code

2017-11-22 Thread Kim Phillips
From: Ben Gainey tools/perf/jvmti is broken in so far as it generates incorrect debug information. Specifically it attributes all debug lines to the original method being output even in the case that some code is being inlined from elsewhere. This patch fixes the issue. To

[PATCH 3/3] tools/perf/jvmti: generate correct debug information for inlined code

2017-11-22 Thread Kim Phillips
From: Ben Gainey tools/perf/jvmti is broken in so far as it generates incorrect debug information. Specifically it attributes all debug lines to the original method being output even in the case that some code is being inlined from elsewhere. This patch fixes the issue. To test (from within