Re: [PATCH 3/9] spi: sunxi: check that transfer speed is non-zero

2015-08-20 Thread Maxime Ripard
On Thu, Aug 20, 2015 at 09:45:07PM +0200, Michal Suchanek wrote: > On 20 August 2015 at 16:48, Maxime Ripard > wrote: > > On Thu, Aug 20, 2015 at 02:19:46PM -, Michal Suchanek wrote: > >> When the maximum transfer speed is not set for a SPI slave the value > >> remains 0 and the code in sunxi

Re: [PATCH 3/9] spi: sunxi: check that transfer speed is non-zero

2015-08-20 Thread Michal Suchanek
On 20 August 2015 at 16:48, Maxime Ripard wrote: > On Thu, Aug 20, 2015 at 02:19:46PM -, Michal Suchanek wrote: >> When the maximum transfer speed is not set for a SPI slave the value >> remains 0 and the code in sunxi SPI divides by it. Use an arbitrary >> speed instead in that case. >> >>

Re: [PATCH 3/9] spi: sunxi: check that transfer speed is non-zero

2015-08-20 Thread Mark Brown
On Thu, Aug 20, 2015 at 02:19:46PM -, Michal Suchanek wrote: > When the maximum transfer speed is not set for a SPI slave the value > remains 0 and the code in sunxi SPI divides by it. Use an arbitrary > speed instead in that case. You should always be using the transfer speed that is defined

Re: [PATCH 3/9] spi: sunxi: check that transfer speed is non-zero

2015-08-20 Thread Maxime Ripard
On Thu, Aug 20, 2015 at 02:19:46PM -, Michal Suchanek wrote: > When the maximum transfer speed is not set for a SPI slave the value > remains 0 and the code in sunxi SPI divides by it. Use an arbitrary > speed instead in that case. > > Signed-off-by: Michal Suchanek spi->max_speed_hz is set

Re: [PATCH 3/9] spi: sunxi: check that transfer speed is non-zero

2015-08-20 Thread Mark Brown
On Thu, Aug 20, 2015 at 02:19:46PM -, Michal Suchanek wrote: When the maximum transfer speed is not set for a SPI slave the value remains 0 and the code in sunxi SPI divides by it. Use an arbitrary speed instead in that case. You should always be using the transfer speed that is defined

Re: [PATCH 3/9] spi: sunxi: check that transfer speed is non-zero

2015-08-20 Thread Maxime Ripard
On Thu, Aug 20, 2015 at 09:45:07PM +0200, Michal Suchanek wrote: On 20 August 2015 at 16:48, Maxime Ripard maxime.rip...@free-electrons.com wrote: On Thu, Aug 20, 2015 at 02:19:46PM -, Michal Suchanek wrote: When the maximum transfer speed is not set for a SPI slave the value remains 0

Re: [PATCH 3/9] spi: sunxi: check that transfer speed is non-zero

2015-08-20 Thread Maxime Ripard
On Thu, Aug 20, 2015 at 02:19:46PM -, Michal Suchanek wrote: When the maximum transfer speed is not set for a SPI slave the value remains 0 and the code in sunxi SPI divides by it. Use an arbitrary speed instead in that case. Signed-off-by: Michal Suchanek hramr...@gmail.com

Re: [PATCH 3/9] spi: sunxi: check that transfer speed is non-zero

2015-08-20 Thread Michal Suchanek
On 20 August 2015 at 16:48, Maxime Ripard maxime.rip...@free-electrons.com wrote: On Thu, Aug 20, 2015 at 02:19:46PM -, Michal Suchanek wrote: When the maximum transfer speed is not set for a SPI slave the value remains 0 and the code in sunxi SPI divides by it. Use an arbitrary speed