Re: [PATCH 32/35] clockevents: Fix cpu down race for hrtimer based broadcasting

2015-03-29 Thread Ingo Molnar
* Preeti U Murthy wrote: > On 03/02/2015 08:26 PM, Peter Zijlstra wrote: > > On Fri, Feb 27, 2015 at 02:19:05PM +0530, Preeti U Murthy wrote: > >> The problem reported in the changelog of this patch is causing severe > >> regressions very frequently on our machines for certain usecases. It

Re: [PATCH 32/35] clockevents: Fix cpu down race for hrtimer based broadcasting

2015-03-29 Thread Ingo Molnar
* Preeti U Murthy pre...@linux.vnet.ibm.com wrote: On 03/02/2015 08:26 PM, Peter Zijlstra wrote: On Fri, Feb 27, 2015 at 02:19:05PM +0530, Preeti U Murthy wrote: The problem reported in the changelog of this patch is causing severe regressions very frequently on our machines for certain

Re: [PATCH 32/35] clockevents: Fix cpu down race for hrtimer based broadcasting

2015-03-24 Thread Preeti U Murthy
Ping. On 03/16/2015 10:22 AM, Preeti U Murthy wrote: > Hi Peter, Ingo, Thomas, > > Can you please take a look at the conversation on this thread ? > This fix is urgent. > > Regards > Preeti U Murthy > > On 03/02/2015 08:26 PM, Peter Zijlstra wrote: >> On Fri, Feb 27, 2015 at 02:19:05PM +0530,

Re: [PATCH 32/35] clockevents: Fix cpu down race for hrtimer based broadcasting

2015-03-24 Thread Preeti U Murthy
Ping. On 03/16/2015 10:22 AM, Preeti U Murthy wrote: Hi Peter, Ingo, Thomas, Can you please take a look at the conversation on this thread ? This fix is urgent. Regards Preeti U Murthy On 03/02/2015 08:26 PM, Peter Zijlstra wrote: On Fri, Feb 27, 2015 at 02:19:05PM +0530, Preeti U

Re: [PATCH 32/35] clockevents: Fix cpu down race for hrtimer based broadcasting

2015-03-15 Thread Preeti U Murthy
Hi Peter, Ingo, Thomas, Can you please take a look at the conversation on this thread ? This fix is urgent. Regards Preeti U Murthy On 03/02/2015 08:26 PM, Peter Zijlstra wrote: > On Fri, Feb 27, 2015 at 02:19:05PM +0530, Preeti U Murthy wrote: >> The problem reported in the changelog of this

Re: [PATCH 32/35] clockevents: Fix cpu down race for hrtimer based broadcasting

2015-03-15 Thread Preeti U Murthy
Hi Peter, Ingo, Thomas, Can you please take a look at the conversation on this thread ? This fix is urgent. Regards Preeti U Murthy On 03/02/2015 08:26 PM, Peter Zijlstra wrote: On Fri, Feb 27, 2015 at 02:19:05PM +0530, Preeti U Murthy wrote: The problem reported in the changelog of this

Re: [PATCH 32/35] clockevents: Fix cpu down race for hrtimer based broadcasting

2015-03-04 Thread Preeti U Murthy
On 03/02/2015 08:26 PM, Peter Zijlstra wrote: > On Fri, Feb 27, 2015 at 02:19:05PM +0530, Preeti U Murthy wrote: >> The problem reported in the changelog of this patch is causing severe >> regressions very frequently on our machines for certain usecases. It would >> help to put in a fix in place

Re: [PATCH 32/35] clockevents: Fix cpu down race for hrtimer based broadcasting

2015-03-04 Thread Preeti U Murthy
On 03/02/2015 08:26 PM, Peter Zijlstra wrote: On Fri, Feb 27, 2015 at 02:19:05PM +0530, Preeti U Murthy wrote: The problem reported in the changelog of this patch is causing severe regressions very frequently on our machines for certain usecases. It would help to put in a fix in place first

Re: [PATCH 32/35] clockevents: Fix cpu down race for hrtimer based broadcasting

2015-03-02 Thread Peter Zijlstra
On Fri, Feb 27, 2015 at 02:19:05PM +0530, Preeti U Murthy wrote: > The problem reported in the changelog of this patch is causing severe > regressions very frequently on our machines for certain usecases. It would > help to put in a fix in place first and then follow that up with these > cleanups.

Re: [PATCH 32/35] clockevents: Fix cpu down race for hrtimer based broadcasting

2015-03-02 Thread Peter Zijlstra
On Fri, Feb 27, 2015 at 02:19:05PM +0530, Preeti U Murthy wrote: The problem reported in the changelog of this patch is causing severe regressions very frequently on our machines for certain usecases. It would help to put in a fix in place first and then follow that up with these cleanups. A

Re: [PATCH 32/35] clockevents: Fix cpu down race for hrtimer based broadcasting

2015-02-27 Thread Preeti U Murthy
On 02/26/2015 11:01 AM, Preeti U Murthy wrote: > On 02/23/2015 11:03 PM, Nicolas Pitre wrote: >> On Mon, 23 Feb 2015, Nicolas Pitre wrote: >> >>> On Mon, 23 Feb 2015, Peter Zijlstra wrote: >>> The reported function that fails: bL_switcher_restore_cpus() is called in the error paths of

Re: [PATCH 32/35] clockevents: Fix cpu down race for hrtimer based broadcasting

2015-02-27 Thread Preeti U Murthy
On 02/26/2015 11:01 AM, Preeti U Murthy wrote: On 02/23/2015 11:03 PM, Nicolas Pitre wrote: On Mon, 23 Feb 2015, Nicolas Pitre wrote: On Mon, 23 Feb 2015, Peter Zijlstra wrote: The reported function that fails: bL_switcher_restore_cpus() is called in the error paths of the former and the

Re: [PATCH 32/35] clockevents: Fix cpu down race for hrtimer based broadcasting

2015-02-25 Thread Preeti U Murthy
On 02/23/2015 11:03 PM, Nicolas Pitre wrote: > On Mon, 23 Feb 2015, Nicolas Pitre wrote: > >> On Mon, 23 Feb 2015, Peter Zijlstra wrote: >> >>> The reported function that fails: bL_switcher_restore_cpus() is called >>> in the error paths of the former and the main path in the latter to make >>>

Re: [PATCH 32/35] clockevents: Fix cpu down race for hrtimer based broadcasting

2015-02-25 Thread Preeti U Murthy
On 02/23/2015 11:03 PM, Nicolas Pitre wrote: On Mon, 23 Feb 2015, Nicolas Pitre wrote: On Mon, 23 Feb 2015, Peter Zijlstra wrote: The reported function that fails: bL_switcher_restore_cpus() is called in the error paths of the former and the main path in the latter to make the 'stolen'

Re: [PATCH 32/35] clockevents: Fix cpu down race for hrtimer based broadcasting

2015-02-23 Thread Nicolas Pitre
On Mon, 23 Feb 2015, Nicolas Pitre wrote: > On Mon, 23 Feb 2015, Peter Zijlstra wrote: > > > The reported function that fails: bL_switcher_restore_cpus() is called > > in the error paths of the former and the main path in the latter to make > > the 'stolen' cpus re-appear. > > > > The patch in

Re: [PATCH 32/35] clockevents: Fix cpu down race for hrtimer based broadcasting

2015-02-23 Thread Nicolas Pitre
On Mon, 23 Feb 2015, Peter Zijlstra wrote: > In any case, having had a second look I think I might have some ideas: > > - bL_switcher_enable() -- enables the whole switcher thing and >disables half the cpus with hot-un-plug, creates a mapping etc.. > > - bL_switcher_disable() -- disabled

Re: [PATCH 32/35] clockevents: Fix cpu down race for hrtimer based broadcasting

2015-02-23 Thread Peter Zijlstra
On Sat, Feb 21, 2015 at 12:45:51PM -0500, Nicolas Pitre wrote: > > I'm having a very hard time trying to follow wth this thing all is > > doing; its using hotplug but its also doing magic with cpu_suspend(). > > You're fully aware of the on-going work on the scheduler to better > support the

Re: [PATCH 32/35] clockevents: Fix cpu down race for hrtimer based broadcasting

2015-02-23 Thread Peter Zijlstra
On Sat, Feb 21, 2015 at 12:45:51PM -0500, Nicolas Pitre wrote: I'm having a very hard time trying to follow wth this thing all is doing; its using hotplug but its also doing magic with cpu_suspend(). You're fully aware of the on-going work on the scheduler to better support the big.LITTLE

Re: [PATCH 32/35] clockevents: Fix cpu down race for hrtimer based broadcasting

2015-02-23 Thread Nicolas Pitre
On Mon, 23 Feb 2015, Peter Zijlstra wrote: In any case, having had a second look I think I might have some ideas: - bL_switcher_enable() -- enables the whole switcher thing and disables half the cpus with hot-un-plug, creates a mapping etc.. - bL_switcher_disable() -- disabled the

Re: [PATCH 32/35] clockevents: Fix cpu down race for hrtimer based broadcasting

2015-02-23 Thread Nicolas Pitre
On Mon, 23 Feb 2015, Nicolas Pitre wrote: On Mon, 23 Feb 2015, Peter Zijlstra wrote: The reported function that fails: bL_switcher_restore_cpus() is called in the error paths of the former and the main path in the latter to make the 'stolen' cpus re-appear. The patch in question

Re: [PATCH 32/35] clockevents: Fix cpu down race for hrtimer based broadcasting

2015-02-21 Thread Nicolas Pitre
On Sat, 21 Feb 2015, Peter Zijlstra wrote: > On Thu, Feb 19, 2015 at 12:51:52PM -0500, Nicolas Pitre wrote: > > > > This breaks the b.L switcher disabling code which essentially does: > > > > static void bL_switcher_restore_cpus(void) > > { > > int i; > > > > for_each_cpu(i,

Re: [PATCH 32/35] clockevents: Fix cpu down race for hrtimer based broadcasting

2015-02-21 Thread Peter Zijlstra
On Thu, Feb 19, 2015 at 12:51:52PM -0500, Nicolas Pitre wrote: > > This breaks the b.L switcher disabling code which essentially does: > > static void bL_switcher_restore_cpus(void) > { > int i; > > for_each_cpu(i, _switcher_removed_logical_cpus) { > struct

Re: [PATCH 32/35] clockevents: Fix cpu down race for hrtimer based broadcasting

2015-02-21 Thread Nicolas Pitre
On Sat, 21 Feb 2015, Peter Zijlstra wrote: On Thu, Feb 19, 2015 at 12:51:52PM -0500, Nicolas Pitre wrote: This breaks the b.L switcher disabling code which essentially does: static void bL_switcher_restore_cpus(void) { int i; for_each_cpu(i,

Re: [PATCH 32/35] clockevents: Fix cpu down race for hrtimer based broadcasting

2015-02-21 Thread Peter Zijlstra
On Thu, Feb 19, 2015 at 12:51:52PM -0500, Nicolas Pitre wrote: This breaks the b.L switcher disabling code which essentially does: static void bL_switcher_restore_cpus(void) { int i; for_each_cpu(i, bL_switcher_removed_logical_cpus) { struct device

Re: [PATCH 32/35] clockevents: Fix cpu down race for hrtimer based broadcasting

2015-02-19 Thread Nicolas Pitre
On Mon, 16 Feb 2015, Peter Zijlstra wrote: > From: Thomas Gleixner > > Preeti reported a cpu down race with hrtimer based broadcasting: > > Assume CPU1 is the CPU which holds the hrtimer broadcasting duty > before it is taken down. > > CPU0 CPU1 > cpu_down() >

Re: [PATCH 32/35] clockevents: Fix cpu down race for hrtimer based broadcasting

2015-02-19 Thread Peter Zijlstra
On Thu, Feb 19, 2015 at 12:31:53PM +0530, Preeti U Murthy wrote: > On 02/18/2015 06:36 PM, Peter Zijlstra wrote: > > On Wed, Feb 18, 2015 at 08:40:52AM +0530, Preeti U Murthy wrote: > >> > >> Look at the changelog, > > > > Heh, yah, clearly I tl;dr'd that. Indeed. > > > >> it explains why

Re: [PATCH 32/35] clockevents: Fix cpu down race for hrtimer based broadcasting

2015-02-19 Thread Peter Zijlstra
On Thu, Feb 19, 2015 at 12:31:53PM +0530, Preeti U Murthy wrote: On 02/18/2015 06:36 PM, Peter Zijlstra wrote: On Wed, Feb 18, 2015 at 08:40:52AM +0530, Preeti U Murthy wrote: Look at the changelog, Heh, yah, clearly I tl;dr'd that. Indeed. it explains why tick_takeover must be

Re: [PATCH 32/35] clockevents: Fix cpu down race for hrtimer based broadcasting

2015-02-19 Thread Nicolas Pitre
On Mon, 16 Feb 2015, Peter Zijlstra wrote: From: Thomas Gleixner t...@linutronix.de Preeti reported a cpu down race with hrtimer based broadcasting: Assume CPU1 is the CPU which holds the hrtimer broadcasting duty before it is taken down. CPU0 CPU1 cpu_down()

Re: [PATCH 32/35] clockevents: Fix cpu down race for hrtimer based broadcasting

2015-02-18 Thread Preeti U Murthy
On 02/18/2015 06:36 PM, Peter Zijlstra wrote: > On Wed, Feb 18, 2015 at 08:40:52AM +0530, Preeti U Murthy wrote: >> >> Look at the changelog, > > Heh, yah, clearly I tl;dr'd that. Indeed. > >> it explains why tick_takeover must be called >> *before* __cpu_die(). > > Since you reported this,

Re: [PATCH 32/35] clockevents: Fix cpu down race for hrtimer based broadcasting

2015-02-18 Thread Peter Zijlstra
On Wed, Feb 18, 2015 at 08:40:52AM +0530, Preeti U Murthy wrote: > > Look at the changelog, Heh, yah, clearly I tl;dr'd that. Indeed. > it explains why tick_takeover must be called > *before* __cpu_die(). Since you reported this, can you test if things work if you move that function call to

Re: [PATCH 32/35] clockevents: Fix cpu down race for hrtimer based broadcasting

2015-02-18 Thread Preeti U Murthy
On 02/18/2015 06:36 PM, Peter Zijlstra wrote: On Wed, Feb 18, 2015 at 08:40:52AM +0530, Preeti U Murthy wrote: Look at the changelog, Heh, yah, clearly I tl;dr'd that. Indeed. it explains why tick_takeover must be called *before* __cpu_die(). Since you reported this, can you test if

Re: [PATCH 32/35] clockevents: Fix cpu down race for hrtimer based broadcasting

2015-02-18 Thread Peter Zijlstra
On Wed, Feb 18, 2015 at 08:40:52AM +0530, Preeti U Murthy wrote: Look at the changelog, Heh, yah, clearly I tl;dr'd that. Indeed. it explains why tick_takeover must be called *before* __cpu_die(). Since you reported this, can you test if things work if you move that function call to

Re: [PATCH 32/35] clockevents: Fix cpu down race for hrtimer based broadcasting

2015-02-17 Thread Preeti U Murthy
On 02/17/2015 04:09 PM, Peter Zijlstra wrote: >> [PATCH 11/35] clockevents: Cleanup dead cpu explicitely n Tue, Feb 17, 2015 at 09:33:45AM +0530, Preeti U Murthy wrote: >> On 02/16/2015 05:45 PM, Peter Zijlstra wrote: >> From: Thomas Gleixner >> @@ -428,7 +428,7 @@ static int __ref

Re: [PATCH 32/35] clockevents: Fix cpu down race for hrtimer based broadcasting

2015-02-17 Thread Peter Zijlstra
On Tue, Feb 17, 2015 at 09:33:45AM +0530, Preeti U Murthy wrote: > On 02/16/2015 05:45 PM, Peter Zijlstra wrote: > > >> From: Thomas Gleixner > > >> @@ -428,7 +428,7 @@ static int __ref _cpu_down(unsigned int > >>__cpu_die(cpu); > >> > >>/* CPU is completely dead: tell everyone. Too

Re: [PATCH 32/35] clockevents: Fix cpu down race for hrtimer based broadcasting

2015-02-17 Thread Preeti U Murthy
On 02/17/2015 04:09 PM, Peter Zijlstra wrote: [PATCH 11/35] clockevents: Cleanup dead cpu explicitely n Tue, Feb 17, 2015 at 09:33:45AM +0530, Preeti U Murthy wrote: On 02/16/2015 05:45 PM, Peter Zijlstra wrote: From: Thomas Gleixner t...@linutronix.de @@ -428,7 +428,7 @@ static int __ref

Re: [PATCH 32/35] clockevents: Fix cpu down race for hrtimer based broadcasting

2015-02-17 Thread Peter Zijlstra
On Tue, Feb 17, 2015 at 09:33:45AM +0530, Preeti U Murthy wrote: On 02/16/2015 05:45 PM, Peter Zijlstra wrote: From: Thomas Gleixner t...@linutronix.de @@ -428,7 +428,7 @@ static int __ref _cpu_down(unsigned int __cpu_die(cpu); /* CPU is completely dead: tell everyone. Too

Re: [PATCH 32/35] clockevents: Fix cpu down race for hrtimer based broadcasting

2015-02-16 Thread Preeti U Murthy
On 02/16/2015 05:45 PM, Peter Zijlstra wrote: >> From: Thomas Gleixner >> @@ -428,7 +428,7 @@ static int __ref _cpu_down(unsigned int >> __cpu_die(cpu); >> >> /* CPU is completely dead: tell everyone. Too late to complain. */ >>- tick_cleanup_dead_cpu(cpu); >>+

[PATCH 32/35] clockevents: Fix cpu down race for hrtimer based broadcasting

2015-02-16 Thread Peter Zijlstra
From: Thomas Gleixner Preeti reported a cpu down race with hrtimer based broadcasting: Assume CPU1 is the CPU which holds the hrtimer broadcasting duty before it is taken down. CPU0CPU1 cpu_down() takedown_cpu()

[PATCH 32/35] clockevents: Fix cpu down race for hrtimer based broadcasting

2015-02-16 Thread Peter Zijlstra
From: Thomas Gleixner t...@linutronix.de Preeti reported a cpu down race with hrtimer based broadcasting: Assume CPU1 is the CPU which holds the hrtimer broadcasting duty before it is taken down. CPU0CPU1 cpu_down() takedown_cpu()

Re: [PATCH 32/35] clockevents: Fix cpu down race for hrtimer based broadcasting

2015-02-16 Thread Preeti U Murthy
On 02/16/2015 05:45 PM, Peter Zijlstra wrote: From: Thomas Gleixner t...@linutronix.de @@ -428,7 +428,7 @@ static int __ref _cpu_down(unsigned int __cpu_die(cpu); /* CPU is completely dead: tell everyone. Too late to complain. */ - tick_cleanup_dead_cpu(cpu); +