Re: [PATCH 4/6] MTHCA driver (infiniband) use new pci interfaces

2006-12-11 Thread Benjamin Herrenschmidt
> Actually even PCIe might not be that easy. For example with current > kernels on PowerPC 440SPe (SoC with PCIe), I just get: > > # lspci > 00:01.0 InfiniBand: Mellanox Technology: Unknown device 6274 (rev a0) > > ie no host bridge / root complex. Did somebody used the spec as toilet

Re: [PATCH 4/6] MTHCA driver (infiniband) use new pci interfaces

2006-12-11 Thread Roland Dreier
> I'm worried by this... At no point do you check the host bridge > capabilities, and thus will happily set the max read req size to some > value larger than the max the host bridge can cope... Well, it's disabled by default... the option is there as a quick way to fix "why is my bandwidth so

Re: [PATCH 4/6] MTHCA driver (infiniband) use new pci interfaces

2006-12-11 Thread Roland Dreier
I'm worried by this... At no point do you check the host bridge capabilities, and thus will happily set the max read req size to some value larger than the max the host bridge can cope... Well, it's disabled by default... the option is there as a quick way to fix why is my bandwidth so low

Re: [PATCH 4/6] MTHCA driver (infiniband) use new pci interfaces

2006-12-11 Thread Benjamin Herrenschmidt
Actually even PCIe might not be that easy. For example with current kernels on PowerPC 440SPe (SoC with PCIe), I just get: # lspci 00:01.0 InfiniBand: Mellanox Technology: Unknown device 6274 (rev a0) ie no host bridge / root complex. Did somebody used the spec as toilet paper

Re: [PATCH 4/6] MTHCA driver (infiniband) use new pci interfaces

2006-12-10 Thread Grant Grundler
On Mon, Dec 11, 2006 at 02:55:39PM +1100, Benjamin Herrenschmidt wrote: > On Fri, 2006-12-08 at 10:22 -0800, Stephen Hemminger wrote: > > plain text document attachment (mthca-rbc.patch) > > Use new pci interfaces to set read request tuning values > > Untested because of lack of hardware.

Re: [PATCH 4/6] MTHCA driver (infiniband) use new pci interfaces

2006-12-10 Thread Grant Grundler
On Mon, Dec 11, 2006 at 02:55:39PM +1100, Benjamin Herrenschmidt wrote: On Fri, 2006-12-08 at 10:22 -0800, Stephen Hemminger wrote: plain text document attachment (mthca-rbc.patch) Use new pci interfaces to set read request tuning values Untested because of lack of hardware. Sorry...I

Re: [PATCH 4/6] MTHCA driver (infiniband) use new pci interfaces

2006-12-08 Thread Roland Dreier
Looks fine (assuming the PCI core interfaces it uses go in). Acked-by: Roland Dreier <[EMAIL PROTECTED]> - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH 4/6] MTHCA driver (infiniband) use new pci interfaces

2006-12-08 Thread Stephen Hemminger
Use new pci interfaces to set read request tuning values Untested because of lack of hardware. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- drivers/infiniband/hw/mthca/mthca_main.c | 38 +++ 1 file changed, 9 insertions(+), 29 deletions(-) ---

[PATCH 4/6] MTHCA driver (infiniband) use new pci interfaces

2006-12-08 Thread Stephen Hemminger
Use new pci interfaces to set read request tuning values Untested because of lack of hardware. Signed-off-by: Stephen Hemminger [EMAIL PROTECTED] --- drivers/infiniband/hw/mthca/mthca_main.c | 38 +++ 1 file changed, 9 insertions(+), 29 deletions(-) ---

Re: [PATCH 4/6] MTHCA driver (infiniband) use new pci interfaces

2006-12-08 Thread Roland Dreier
Looks fine (assuming the PCI core interfaces it uses go in). Acked-by: Roland Dreier [EMAIL PROTECTED] - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please