Re: [PATCH 4.9 43/92] x86/pti: Do not enable PTI on CPUs which are not vulnerable to Meltdown

Hi, This should use boot_cpu_has_bug(X86_BUG_CPU_MELTDOWN)) - I am preparing patches. Best, Nick

Re: [PATCH 4.9 43/92] x86/pti: Do not enable PTI on CPUs which are not vulnerable to Meltdown

Hi, This should use boot_cpu_has_bug(X86_BUG_CPU_MELTDOWN)) - I am preparing patches. Best, Nick

Re: [PATCH 4.9 43/92] x86/pti: Do not enable PTI on CPUs which are not vulnerable to Meltdown

Hi I do not have a tested patch, but I expect the change would be something like: skip: - if (boot_cpu_data.x86_vendor == X86_VENDOR_AMD) + if (!static_cpu_has_bug(X86_BUG_CPU_MELTDOWN)) goto disable; Cheers, Nick On Tue, Feb 13, 2018 at 4:32 PM, Greg Kroah-Hartman

Re: [PATCH 4.9 43/92] x86/pti: Do not enable PTI on CPUs which are not vulnerable to Meltdown

Hi I do not have a tested patch, but I expect the change would be something like: skip: - if (boot_cpu_data.x86_vendor == X86_VENDOR_AMD) + if (!static_cpu_has_bug(X86_BUG_CPU_MELTDOWN)) goto disable; Cheers, Nick On Tue, Feb 13, 2018 at 4:32 PM, Greg Kroah-Hartman

Re: [PATCH 4.9 43/92] x86/pti: Do not enable PTI on CPUs which are not vulnerable to Meltdown

On Tue, Feb 13, 2018 at 03:27:47PM +, Nick Lowe wrote: > Hi Arjan and Greg, > > Sorry if I am not being clear enough. > > My point is that there is a check for X86_VENDOR_AMD now in two places. > > It is still hardcoded for the auto boot option which I think should > not be there. The patch

Re: [PATCH 4.9 43/92] x86/pti: Do not enable PTI on CPUs which are not vulnerable to Meltdown

On Tue, Feb 13, 2018 at 03:27:47PM +, Nick Lowe wrote: > Hi Arjan and Greg, > > Sorry if I am not being clear enough. > > My point is that there is a check for X86_VENDOR_AMD now in two places. > > It is still hardcoded for the auto boot option which I think should > not be there. The patch

Re: [PATCH 4.9 43/92] x86/pti: Do not enable PTI on CPUs which are not vulnerable to Meltdown

On 02/13/2018 07:56 AM, Andi Kleen wrote: > On Tue, Feb 13, 2018 at 07:09:44AM -0800, Arjan van de Ven wrote: >>> So, any hints on what you think should be the correct fix here? >> the patch sure looks correct to me, it now has a nice table for CPU IDs >> including all of AMD (and soon hopefully

Re: [PATCH 4.9 43/92] x86/pti: Do not enable PTI on CPUs which are not vulnerable to Meltdown

On 02/13/2018 07:56 AM, Andi Kleen wrote: > On Tue, Feb 13, 2018 at 07:09:44AM -0800, Arjan van de Ven wrote: >>> So, any hints on what you think should be the correct fix here? >> the patch sure looks correct to me, it now has a nice table for CPU IDs >> including all of AMD (and soon hopefully

Re: [PATCH 4.9 43/92] x86/pti: Do not enable PTI on CPUs which are not vulnerable to Meltdown

On Tue, Feb 13, 2018 at 05:02:59PM +0100, Thomas Gleixner wrote: > No. The table is basically excluding families <=5 and a few individual > ones. Anything newer than that should tell via ARCH_CAP_RDCL_NO and not > need any entry. It looks to me like Nick wants 4.9 to test X86_BUG_CPU_MELTDOWN in

Re: [PATCH 4.9 43/92] x86/pti: Do not enable PTI on CPUs which are not vulnerable to Meltdown

On Tue, Feb 13, 2018 at 05:02:59PM +0100, Thomas Gleixner wrote: > No. The table is basically excluding families <=5 and a few individual > ones. Anything newer than that should tell via ARCH_CAP_RDCL_NO and not > need any entry. It looks to me like Nick wants 4.9 to test X86_BUG_CPU_MELTDOWN in

Re: [PATCH 4.9 43/92] x86/pti: Do not enable PTI on CPUs which are not vulnerable to Meltdown

On Tue, 13 Feb 2018, Andi Kleen wrote: > On Tue, Feb 13, 2018 at 07:09:44AM -0800, Arjan van de Ven wrote: > > > > > > So, any hints on what you think should be the correct fix here? > > > > the patch sure looks correct to me, it now has a nice table for CPU IDs > > including all of AMD (and

Re: [PATCH 4.9 43/92] x86/pti: Do not enable PTI on CPUs which are not vulnerable to Meltdown

On Tue, 13 Feb 2018, Andi Kleen wrote: > On Tue, Feb 13, 2018 at 07:09:44AM -0800, Arjan van de Ven wrote: > > > > > > So, any hints on what you think should be the correct fix here? > > > > the patch sure looks correct to me, it now has a nice table for CPU IDs > > including all of AMD (and

Re: [PATCH 4.9 43/92] x86/pti: Do not enable PTI on CPUs which are not vulnerable to Meltdown

On Tue, Feb 13, 2018 at 07:09:44AM -0800, Arjan van de Ven wrote: > > > > So, any hints on what you think should be the correct fix here? > > the patch sure looks correct to me, it now has a nice table for CPU IDs > including all of AMD (and soon hopefully the existing Intel ones that are not >

Re: [PATCH 4.9 43/92] x86/pti: Do not enable PTI on CPUs which are not vulnerable to Meltdown

On Tue, Feb 13, 2018 at 07:09:44AM -0800, Arjan van de Ven wrote: > > > > So, any hints on what you think should be the correct fix here? > > the patch sure looks correct to me, it now has a nice table for CPU IDs > including all of AMD (and soon hopefully the existing Intel ones that are not >

Re: [PATCH 4.9 43/92] x86/pti: Do not enable PTI on CPUs which are not vulnerable to Meltdown

Hi Arjan and Greg, Sorry if I am not being clear enough. My point is that there is a check for X86_VENDOR_AMD now in two places. It is still hardcoded for the auto boot option which I think should not be there. The patch on that basis looked incomplete to me. Put another way, there is no

Re: [PATCH 4.9 43/92] x86/pti: Do not enable PTI on CPUs which are not vulnerable to Meltdown

Hi Arjan and Greg, Sorry if I am not being clear enough. My point is that there is a check for X86_VENDOR_AMD now in two places. It is still hardcoded for the auto boot option which I think should not be there. The patch on that basis looked incomplete to me. Put another way, there is no

Re: [PATCH 4.9 43/92] x86/pti: Do not enable PTI on CPUs which are not vulnerable to Meltdown

So, any hints on what you think should be the correct fix here? the patch sure looks correct to me, it now has a nice table for CPU IDs including all of AMD (and soon hopefully the existing Intel ones that are not exposed to meltdown)

Re: [PATCH 4.9 43/92] x86/pti: Do not enable PTI on CPUs which are not vulnerable to Meltdown

So, any hints on what you think should be the correct fix here? the patch sure looks correct to me, it now has a nice table for CPU IDs including all of AMD (and soon hopefully the existing Intel ones that are not exposed to meltdown)

Re: [PATCH 4.9 43/92] x86/pti: Do not enable PTI on CPUs which are not vulnerable to Meltdown

On Tue, Feb 13, 2018 at 01:34:07PM +, Nick Lowe wrote: > Hi, > > This does not seem to have subsumed the AMD specific code in > > x86/pti: Do not enable PTI on CPUs which are not vulnerable to Meltdown > Commit a8799fd14d9f7f385a5a5c86cde247caf4bb0320 > >

Re: [PATCH 4.9 43/92] x86/pti: Do not enable PTI on CPUs which are not vulnerable to Meltdown

On Tue, Feb 13, 2018 at 01:34:07PM +, Nick Lowe wrote: > Hi, > > This does not seem to have subsumed the AMD specific code in > > x86/pti: Do not enable PTI on CPUs which are not vulnerable to Meltdown > Commit a8799fd14d9f7f385a5a5c86cde247caf4bb0320 > >

Re: [PATCH 4.9 43/92] x86/pti: Do not enable PTI on CPUs which are not vulnerable to Meltdown

Hi, This does not seem to have subsumed the AMD specific code in x86/pti: Do not enable PTI on CPUs which are not vulnerable to Meltdown Commit a8799fd14d9f7f385a5a5c86cde247caf4bb0320

Re: [PATCH 4.9 43/92] x86/pti: Do not enable PTI on CPUs which are not vulnerable to Meltdown

Hi, This does not seem to have subsumed the AMD specific code in x86/pti: Do not enable PTI on CPUs which are not vulnerable to Meltdown Commit a8799fd14d9f7f385a5a5c86cde247caf4bb0320

[PATCH 4.9 43/92] x86/pti: Do not enable PTI on CPUs which are not vulnerable to Meltdown

4.9-stable review patch. If anyone has any objections, please let me know. -- From: David Woodhouse (cherry picked from commit fec9434a12f38d3aeafeb75711b71d8a1fdef621) Also, for CPUs which don't speculate at all, don't report that they're vulnerable to the

[PATCH 4.9 43/92] x86/pti: Do not enable PTI on CPUs which are not vulnerable to Meltdown

4.9-stable review patch. If anyone has any objections, please let me know. -- From: David Woodhouse (cherry picked from commit fec9434a12f38d3aeafeb75711b71d8a1fdef621) Also, for CPUs which don't speculate at all, don't report that they're vulnerable to the Spectre variants