Re: [PATCH 5/6] floppy: remove check for allocated queue on do_floppy_init error handling

2012-08-13 Thread Herton Ronaldo Krzesinski
On Fri, Aug 10, 2012 at 01:36:53PM -0400, Vivek Goyal wrote: > On Thu, Aug 09, 2012 at 04:59:50PM -0300, Herton Ronaldo Krzesinski wrote: > > The check "if (disks[dr]->queue)" check is bogus, if we reach there > > for each dr should exist an queue allocated (note that we decrement dr > > first on

Re: [PATCH 5/6] floppy: remove check for allocated queue on do_floppy_init error handling

2012-08-13 Thread Herton Ronaldo Krzesinski
On Fri, Aug 10, 2012 at 01:36:53PM -0400, Vivek Goyal wrote: On Thu, Aug 09, 2012 at 04:59:50PM -0300, Herton Ronaldo Krzesinski wrote: The check if (disks[dr]-queue) check is bogus, if we reach there for each dr should exist an queue allocated (note that we decrement dr first on entering

Re: [PATCH 5/6] floppy: remove check for allocated queue on do_floppy_init error handling

2012-08-10 Thread Vivek Goyal
On Thu, Aug 09, 2012 at 04:59:50PM -0300, Herton Ronaldo Krzesinski wrote: > The check "if (disks[dr]->queue)" check is bogus, if we reach there > for each dr should exist an queue allocated (note that we decrement dr > first on entering the loop). > > Signed-off-by: Herton Ronaldo Krzesinski

Re: [PATCH 5/6] floppy: remove check for allocated queue on do_floppy_init error handling

2012-08-10 Thread Vivek Goyal
On Thu, Aug 09, 2012 at 04:59:50PM -0300, Herton Ronaldo Krzesinski wrote: The check if (disks[dr]-queue) check is bogus, if we reach there for each dr should exist an queue allocated (note that we decrement dr first on entering the loop). Signed-off-by: Herton Ronaldo Krzesinski

[PATCH 5/6] floppy: remove check for allocated queue on do_floppy_init error handling

2012-08-09 Thread Herton Ronaldo Krzesinski
The check "if (disks[dr]->queue)" check is bogus, if we reach there for each dr should exist an queue allocated (note that we decrement dr first on entering the loop). Signed-off-by: Herton Ronaldo Krzesinski --- drivers/block/floppy.c | 16 +++- 1 file changed, 7 insertions(+), 9

[PATCH 5/6] floppy: remove check for allocated queue on do_floppy_init error handling

2012-08-09 Thread Herton Ronaldo Krzesinski
The check if (disks[dr]-queue) check is bogus, if we reach there for each dr should exist an queue allocated (note that we decrement dr first on entering the loop). Signed-off-by: Herton Ronaldo Krzesinski herton.krzesin...@canonical.com --- drivers/block/floppy.c | 16 +++- 1 file