Re: [PATCH 8/9] clk: sunxi-ng: Add A31/A31s clocks

2016-07-28 Thread Maxime Ripard
On Tue, Jul 26, 2016 at 03:04:30PM +0800, Chen-Yu Tsai wrote: > Add a new style driver for the clock control unit in Allwinner A31/A31s. > > A few clocks are still missing: > > - EMAC clock > > Signed-off-by: Chen-Yu Tsai Looks good to me, aside from the comment made by

Re: [PATCH 8/9] clk: sunxi-ng: Add A31/A31s clocks

2016-07-28 Thread Maxime Ripard
On Tue, Jul 26, 2016 at 03:04:30PM +0800, Chen-Yu Tsai wrote: > Add a new style driver for the clock control unit in Allwinner A31/A31s. > > A few clocks are still missing: > > - EMAC clock > > Signed-off-by: Chen-Yu Tsai Looks good to me, aside from the comment made by Jean-Francois. I

Re: [PATCH 8/9] clk: sunxi-ng: Add A31/A31s clocks

2016-07-27 Thread Rob Herring
On Tue, Jul 26, 2016 at 03:04:30PM +0800, Chen-Yu Tsai wrote: > Add a new style driver for the clock control unit in Allwinner A31/A31s. > > A few clocks are still missing: > > - EMAC clock > > Signed-off-by: Chen-Yu Tsai > --- > .../devicetree/bindings/clock/sunxi-ccu.txt

Re: [PATCH 8/9] clk: sunxi-ng: Add A31/A31s clocks

2016-07-27 Thread Rob Herring
On Tue, Jul 26, 2016 at 03:04:30PM +0800, Chen-Yu Tsai wrote: > Add a new style driver for the clock control unit in Allwinner A31/A31s. > > A few clocks are still missing: > > - EMAC clock > > Signed-off-by: Chen-Yu Tsai > --- > .../devicetree/bindings/clock/sunxi-ccu.txt|3

Re: [PATCH 8/9] clk: sunxi-ng: Add A31/A31s clocks

2016-07-26 Thread Jean-Francois Moine
On Tue, 26 Jul 2016 15:04:30 +0800 Chen-Yu Tsai wrote: > +static const struct ccu_mux_fixed_prediv clk_out_predivs[] = { > + { .index = 0, .div = 750, }, > + { .index = 3, .div = 4, }, > + { .index = 4, .div = 4, }, > +}; No end of table. -- Ken ar c'hentañ |

Re: [PATCH 8/9] clk: sunxi-ng: Add A31/A31s clocks

2016-07-26 Thread Jean-Francois Moine
On Tue, 26 Jul 2016 15:04:30 +0800 Chen-Yu Tsai wrote: > +static const struct ccu_mux_fixed_prediv clk_out_predivs[] = { > + { .index = 0, .div = 750, }, > + { .index = 3, .div = 4, }, > + { .index = 4, .div = 4, }, > +}; No end of table. -- Ken ar c'hentañ | ** Breizh

[PATCH 8/9] clk: sunxi-ng: Add A31/A31s clocks

2016-07-26 Thread Chen-Yu Tsai
Add a new style driver for the clock control unit in Allwinner A31/A31s. A few clocks are still missing: - EMAC clock Signed-off-by: Chen-Yu Tsai --- .../devicetree/bindings/clock/sunxi-ccu.txt|3 +- drivers/clk/sunxi-ng/Kconfig | 10 +

[PATCH 8/9] clk: sunxi-ng: Add A31/A31s clocks

2016-07-26 Thread Chen-Yu Tsai
Add a new style driver for the clock control unit in Allwinner A31/A31s. A few clocks are still missing: - EMAC clock Signed-off-by: Chen-Yu Tsai --- .../devicetree/bindings/clock/sunxi-ccu.txt|3 +- drivers/clk/sunxi-ng/Kconfig | 10 +