Re: [PATCH V3] sched/deadline: Update rq_clock of later_rq when pushing a task

2018-07-20 Thread Peter Zijlstra
On Fri, Jul 20, 2018 at 05:36:06PM +0200, Daniel Bristot de Oliveira wrote: > Am I missing something? Nothing, I was missing why exactly this was deadline only. Figured it out now :-)

Re: [PATCH V3] sched/deadline: Update rq_clock of later_rq when pushing a task

2018-07-20 Thread Peter Zijlstra
On Fri, Jul 20, 2018 at 05:36:06PM +0200, Daniel Bristot de Oliveira wrote: > Am I missing something? Nothing, I was missing why exactly this was deadline only. Figured it out now :-)

Re: [PATCH V3] sched/deadline: Update rq_clock of later_rq when pushing a task

2018-07-20 Thread Juri Lelli
On 20/07/18 17:36, Daniel Bristot de Oliveira wrote: > On 07/20/2018 02:53 PM, Juri Lelli wrote: > > On 20/07/18 14:48, Peter Zijlstra wrote: > >> On Fri, Jul 20, 2018 at 02:46:15PM +0200, Peter Zijlstra wrote: > >>> On Fri, Jul 20, 2018 at 11:16:30AM +0200, Daniel Bristot de Oliveira > >>>

Re: [PATCH V3] sched/deadline: Update rq_clock of later_rq when pushing a task

2018-07-20 Thread Juri Lelli
On 20/07/18 17:36, Daniel Bristot de Oliveira wrote: > On 07/20/2018 02:53 PM, Juri Lelli wrote: > > On 20/07/18 14:48, Peter Zijlstra wrote: > >> On Fri, Jul 20, 2018 at 02:46:15PM +0200, Peter Zijlstra wrote: > >>> On Fri, Jul 20, 2018 at 11:16:30AM +0200, Daniel Bristot de Oliveira > >>>

Re: [PATCH V3] sched/deadline: Update rq_clock of later_rq when pushing a task

2018-07-20 Thread Daniel Bristot de Oliveira
On 07/20/2018 02:53 PM, Juri Lelli wrote: > On 20/07/18 14:48, Peter Zijlstra wrote: >> On Fri, Jul 20, 2018 at 02:46:15PM +0200, Peter Zijlstra wrote: >>> On Fri, Jul 20, 2018 at 11:16:30AM +0200, Daniel Bristot de Oliveira wrote: diff --git a/kernel/sched/deadline.c

Re: [PATCH V3] sched/deadline: Update rq_clock of later_rq when pushing a task

2018-07-20 Thread Daniel Bristot de Oliveira
On 07/20/2018 02:53 PM, Juri Lelli wrote: > On 20/07/18 14:48, Peter Zijlstra wrote: >> On Fri, Jul 20, 2018 at 02:46:15PM +0200, Peter Zijlstra wrote: >>> On Fri, Jul 20, 2018 at 11:16:30AM +0200, Daniel Bristot de Oliveira wrote: diff --git a/kernel/sched/deadline.c

Re: [PATCH V3] sched/deadline: Update rq_clock of later_rq when pushing a task

2018-07-20 Thread Juri Lelli
On 20/07/18 14:48, Peter Zijlstra wrote: > On Fri, Jul 20, 2018 at 02:46:15PM +0200, Peter Zijlstra wrote: > > On Fri, Jul 20, 2018 at 11:16:30AM +0200, Daniel Bristot de Oliveira wrote: > > > diff --git a/kernel/sched/deadline.c b/kernel/sched/deadline.c > > > index fbfc3f1d368a..8b50eea4b607

Re: [PATCH V3] sched/deadline: Update rq_clock of later_rq when pushing a task

2018-07-20 Thread Juri Lelli
On 20/07/18 14:48, Peter Zijlstra wrote: > On Fri, Jul 20, 2018 at 02:46:15PM +0200, Peter Zijlstra wrote: > > On Fri, Jul 20, 2018 at 11:16:30AM +0200, Daniel Bristot de Oliveira wrote: > > > diff --git a/kernel/sched/deadline.c b/kernel/sched/deadline.c > > > index fbfc3f1d368a..8b50eea4b607

Re: [PATCH V3] sched/deadline: Update rq_clock of later_rq when pushing a task

2018-07-20 Thread Peter Zijlstra
On Fri, Jul 20, 2018 at 02:46:15PM +0200, Peter Zijlstra wrote: > On Fri, Jul 20, 2018 at 11:16:30AM +0200, Daniel Bristot de Oliveira wrote: > > diff --git a/kernel/sched/deadline.c b/kernel/sched/deadline.c > > index fbfc3f1d368a..8b50eea4b607 100644 > > --- a/kernel/sched/deadline.c > > +++

Re: [PATCH V3] sched/deadline: Update rq_clock of later_rq when pushing a task

2018-07-20 Thread Peter Zijlstra
On Fri, Jul 20, 2018 at 02:46:15PM +0200, Peter Zijlstra wrote: > On Fri, Jul 20, 2018 at 11:16:30AM +0200, Daniel Bristot de Oliveira wrote: > > diff --git a/kernel/sched/deadline.c b/kernel/sched/deadline.c > > index fbfc3f1d368a..8b50eea4b607 100644 > > --- a/kernel/sched/deadline.c > > +++

Re: [PATCH V3] sched/deadline: Update rq_clock of later_rq when pushing a task

2018-07-20 Thread Peter Zijlstra
On Fri, Jul 20, 2018 at 11:16:30AM +0200, Daniel Bristot de Oliveira wrote: > diff --git a/kernel/sched/deadline.c b/kernel/sched/deadline.c > index fbfc3f1d368a..8b50eea4b607 100644 > --- a/kernel/sched/deadline.c > +++ b/kernel/sched/deadline.c > @@ -2090,8 +2090,14 @@ static int

Re: [PATCH V3] sched/deadline: Update rq_clock of later_rq when pushing a task

2018-07-20 Thread Peter Zijlstra
On Fri, Jul 20, 2018 at 11:16:30AM +0200, Daniel Bristot de Oliveira wrote: > diff --git a/kernel/sched/deadline.c b/kernel/sched/deadline.c > index fbfc3f1d368a..8b50eea4b607 100644 > --- a/kernel/sched/deadline.c > +++ b/kernel/sched/deadline.c > @@ -2090,8 +2090,14 @@ static int

[PATCH V3] sched/deadline: Update rq_clock of later_rq when pushing a task

2018-07-20 Thread Daniel Bristot de Oliveira
Daniel Casini got this warn while running a DL task here at RetisLab: [ 461.137582] [ cut here ] [ 461.137583] rq->clock_update_flags < RQCF_ACT_SKIP [ 461.137599] WARNING: CPU: 4 PID: 2354 at kernel/sched/sched.h:967

[PATCH V3] sched/deadline: Update rq_clock of later_rq when pushing a task

2018-07-20 Thread Daniel Bristot de Oliveira
Daniel Casini got this warn while running a DL task here at RetisLab: [ 461.137582] [ cut here ] [ 461.137583] rq->clock_update_flags < RQCF_ACT_SKIP [ 461.137599] WARNING: CPU: 4 PID: 2354 at kernel/sched/sched.h:967