Re: [PATCH net/3.9] ipv6: ndisc: fix ndisc_send_redirect writing to the wrong skb

2013-06-13 Thread David Miller
From: Matthias Schiffer Date: Fri, 07 Jun 2013 13:00:52 +0200 > On 05/31/2013 10:42 AM, David Miller wrote: >> From: Cong Wang >> Date: Fri, 31 May 2013 11:23:11 +0800 >> >>> On Fri, May 31, 2013 at 9:27 AM, Matthias Schiffer >>> wrote: Since some refactoring in 5f5a011,

Re: [PATCH net/3.9] ipv6: ndisc: fix ndisc_send_redirect writing to the wrong skb

2013-06-13 Thread David Miller
From: Matthias Schiffer mschif...@universe-factory.net Date: Fri, 07 Jun 2013 13:00:52 +0200 On 05/31/2013 10:42 AM, David Miller wrote: From: Cong Wang xiyou.wangc...@gmail.com Date: Fri, 31 May 2013 11:23:11 +0800 On Fri, May 31, 2013 at 9:27 AM, Matthias Schiffer

Re: [PATCH net/3.9] ipv6: ndisc: fix ndisc_send_redirect writing to the wrong skb

2013-06-07 Thread Matthias Schiffer
On 05/31/2013 10:42 AM, David Miller wrote: > From: Cong Wang > Date: Fri, 31 May 2013 11:23:11 +0800 > >> On Fri, May 31, 2013 at 9:27 AM, Matthias Schiffer >> wrote: >>> Since some refactoring in 5f5a011, ndisc_send_redirect called >>> ndisc_fill_redirect_hdr_option on the wrong skb, leading

Re: [PATCH net/3.9] ipv6: ndisc: fix ndisc_send_redirect writing to the wrong skb

2013-06-07 Thread Matthias Schiffer
On 05/31/2013 10:42 AM, David Miller wrote: From: Cong Wang xiyou.wangc...@gmail.com Date: Fri, 31 May 2013 11:23:11 +0800 On Fri, May 31, 2013 at 9:27 AM, Matthias Schiffer mschif...@universe-factory.net wrote: Since some refactoring in 5f5a011, ndisc_send_redirect called

Re: [PATCH net/3.9] ipv6: ndisc: fix ndisc_send_redirect writing to the wrong skb

2013-05-31 Thread David Miller
From: Cong Wang Date: Fri, 31 May 2013 11:23:11 +0800 > On Fri, May 31, 2013 at 9:27 AM, Matthias Schiffer > wrote: >> Since some refactoring in 5f5a011, ndisc_send_redirect called >> ndisc_fill_redirect_hdr_option on the wrong skb, leading to data corruption >> or >> in the worst case a panic

Re: [PATCH net/3.9] ipv6: ndisc: fix ndisc_send_redirect writing to the wrong skb

2013-05-31 Thread David Miller
From: Cong Wang xiyou.wangc...@gmail.com Date: Fri, 31 May 2013 11:23:11 +0800 On Fri, May 31, 2013 at 9:27 AM, Matthias Schiffer mschif...@universe-factory.net wrote: Since some refactoring in 5f5a011, ndisc_send_redirect called ndisc_fill_redirect_hdr_option on the wrong skb, leading to

Re: [PATCH net/3.9] ipv6: ndisc: fix ndisc_send_redirect writing to the wrong skb

2013-05-30 Thread Cong Wang
On Fri, May 31, 2013 at 9:27 AM, Matthias Schiffer wrote: > Since some refactoring in 5f5a011, ndisc_send_redirect called > ndisc_fill_redirect_hdr_option on the wrong skb, leading to data corruption or > in the worst case a panic when the skb_put failed. > > Signed-off-by: Matthias Schiffer

[PATCH net/3.9] ipv6: ndisc: fix ndisc_send_redirect writing to the wrong skb

2013-05-30 Thread Matthias Schiffer
Since some refactoring in 5f5a011, ndisc_send_redirect called ndisc_fill_redirect_hdr_option on the wrong skb, leading to data corruption or in the worst case a panic when the skb_put failed. Signed-off-by: Matthias Schiffer --- net/ipv6/ndisc.c | 2 +- 1 file changed, 1 insertion(+), 1

[PATCH net/3.9] ipv6: ndisc: fix ndisc_send_redirect writing to the wrong skb

2013-05-30 Thread Matthias Schiffer
Since some refactoring in 5f5a011, ndisc_send_redirect called ndisc_fill_redirect_hdr_option on the wrong skb, leading to data corruption or in the worst case a panic when the skb_put failed. Signed-off-by: Matthias Schiffer mschif...@universe-factory.net --- net/ipv6/ndisc.c | 2 +- 1 file

Re: [PATCH net/3.9] ipv6: ndisc: fix ndisc_send_redirect writing to the wrong skb

2013-05-30 Thread Cong Wang
On Fri, May 31, 2013 at 9:27 AM, Matthias Schiffer mschif...@universe-factory.net wrote: Since some refactoring in 5f5a011, ndisc_send_redirect called ndisc_fill_redirect_hdr_option on the wrong skb, leading to data corruption or in the worst case a panic when the skb_put failed.