Re: [PATCH tip/core/rcu 03/17] rcu/tree: Skip entry into the page allocator for PREEMPT_RT

2020-07-15 Thread Uladzislau Rezki
On Wed, Jul 15, 2020 at 04:16:22PM +0200, Sebastian Andrzej Siewior wrote: > On 2020-07-15 15:38:08 [+0200], Uladzislau Rezki wrote: > > > As of -rc3 it should complain about printk() which is why it is still > > > disabled by default. > > > > > Have you tried to trigger a "complain" you are

Re: [PATCH tip/core/rcu 03/17] rcu/tree: Skip entry into the page allocator for PREEMPT_RT

2020-07-15 Thread Sebastian Andrzej Siewior
On 2020-07-15 15:38:08 [+0200], Uladzislau Rezki wrote: > > As of -rc3 it should complain about printk() which is why it is still > > disabled by default. > > > Have you tried to trigger a "complain" you are talking about? No, but I is wrong because a raw_spinlock_t is acquired followed by a

Re: [PATCH tip/core/rcu 03/17] rcu/tree: Skip entry into the page allocator for PREEMPT_RT

2020-07-15 Thread Uladzislau Rezki
On Tue, Jun 30, 2020 at 06:45:43PM +0200, Sebastian Andrzej Siewior wrote: > On 2020-06-24 13:12:12 [-0700], paul...@kernel.org wrote: > > From: "Joel Fernandes (Google)" > > > > To keep the kfree_rcu() code working in purely atomic sections on RT, > > such as non-threaded IRQ handlers and raw

Re: [PATCH tip/core/rcu 03/17] rcu/tree: Skip entry into the page allocator for PREEMPT_RT

2020-07-08 Thread Uladzislau Rezki
On Tue, Jul 07, 2020 at 02:45:31PM -0400, Joel Fernandes wrote: > On Tue, Jul 07, 2020 at 07:34:41PM +0200, Uladzislau Rezki wrote: > > On Mon, Jul 06, 2020 at 02:06:45PM -0700, Paul E. McKenney wrote: > > > On Thu, Jul 02, 2020 at 10:19:08PM +0200, Sebastian Andrzej Siewior wrote: > > > > On

Re: [PATCH tip/core/rcu 03/17] rcu/tree: Skip entry into the page allocator for PREEMPT_RT

2020-07-07 Thread Joel Fernandes
On Tue, Jul 07, 2020 at 07:34:41PM +0200, Uladzislau Rezki wrote: > On Mon, Jul 06, 2020 at 02:06:45PM -0700, Paul E. McKenney wrote: > > On Thu, Jul 02, 2020 at 10:19:08PM +0200, Sebastian Andrzej Siewior wrote: > > > On 2020-07-02 09:48:26 [-0700], Paul E. McKenney wrote: > > > > On Thu, Jul 02,

Re: [PATCH tip/core/rcu 03/17] rcu/tree: Skip entry into the page allocator for PREEMPT_RT

2020-07-07 Thread Uladzislau Rezki
On Mon, Jul 06, 2020 at 02:06:45PM -0700, Paul E. McKenney wrote: > On Thu, Jul 02, 2020 at 10:19:08PM +0200, Sebastian Andrzej Siewior wrote: > > On 2020-07-02 09:48:26 [-0700], Paul E. McKenney wrote: > > > On Thu, Jul 02, 2020 at 04:12:16PM +0200, Sebastian Andrzej Siewior wrote: > > > > On

Re: [PATCH tip/core/rcu 03/17] rcu/tree: Skip entry into the page allocator for PREEMPT_RT

2020-07-07 Thread Sebastian Andrzej Siewior
On 2020-07-06 16:29:49 [-0400], Joel Fernandes wrote: > Anyway, I think as we discussed on IRC, your proposal will work for both > kernels while allowing us to keep the internal lock as raw. Why can't we use the migrate_disable() and spinlock_t? > thanks, > > - Joel Sebastian

Re: [PATCH tip/core/rcu 03/17] rcu/tree: Skip entry into the page allocator for PREEMPT_RT

2020-07-06 Thread Paul E. McKenney
On Thu, Jul 02, 2020 at 10:19:08PM +0200, Sebastian Andrzej Siewior wrote: > On 2020-07-02 09:48:26 [-0700], Paul E. McKenney wrote: > > On Thu, Jul 02, 2020 at 04:12:16PM +0200, Sebastian Andrzej Siewior wrote: > > > On 2020-06-30 11:35:34 [-0700], Paul E. McKenney wrote: > > > > > This is not

Re: [PATCH tip/core/rcu 03/17] rcu/tree: Skip entry into the page allocator for PREEMPT_RT

2020-07-06 Thread Joel Fernandes
On Mon, Jul 06, 2020 at 09:55:57PM +0200, Uladzislau Rezki wrote: [...] > > > Another way of fixing it is just dropping the lock letting the page > > > allocator to do an allocation without our "upper/local" lock. I did a > > > proposal like that once upon a time, so maybe it is a time to

Re: [PATCH tip/core/rcu 03/17] rcu/tree: Skip entry into the page allocator for PREEMPT_RT

2020-07-06 Thread Uladzislau Rezki
On Mon, Jul 06, 2020 at 03:42:32PM -0400, Joel Fernandes wrote: > On Thu, Jul 02, 2020 at 09:45:06PM +0200, Uladzislau Rezki wrote: > > On Thu, Jul 02, 2020 at 04:12:16PM +0200, Sebastian Andrzej Siewior wrote: > > > On 2020-06-30 11:35:34 [-0700], Paul E. McKenney wrote: > > > > > This is not

Re: [PATCH tip/core/rcu 03/17] rcu/tree: Skip entry into the page allocator for PREEMPT_RT

2020-07-06 Thread Joel Fernandes
On Thu, Jul 02, 2020 at 09:45:06PM +0200, Uladzislau Rezki wrote: > On Thu, Jul 02, 2020 at 04:12:16PM +0200, Sebastian Andrzej Siewior wrote: > > On 2020-06-30 11:35:34 [-0700], Paul E. McKenney wrote: > > > > This is not going to work together with the "wait context validator" > > > >

Re: [PATCH tip/core/rcu 03/17] rcu/tree: Skip entry into the page allocator for PREEMPT_RT

2020-07-02 Thread Sebastian Andrzej Siewior
On 2020-07-02 09:48:26 [-0700], Paul E. McKenney wrote: > On Thu, Jul 02, 2020 at 04:12:16PM +0200, Sebastian Andrzej Siewior wrote: > > On 2020-06-30 11:35:34 [-0700], Paul E. McKenney wrote: > > > > This is not going to work together with the "wait context validator" > > > >

Re: [PATCH tip/core/rcu 03/17] rcu/tree: Skip entry into the page allocator for PREEMPT_RT

2020-07-02 Thread Uladzislau Rezki
On Thu, Jul 02, 2020 at 04:12:16PM +0200, Sebastian Andrzej Siewior wrote: > On 2020-06-30 11:35:34 [-0700], Paul E. McKenney wrote: > > > This is not going to work together with the "wait context validator" > > > (CONFIG_PROVE_RAW_LOCK_NESTING). As of -rc3 it should complain about > > > printk()

Re: [PATCH tip/core/rcu 03/17] rcu/tree: Skip entry into the page allocator for PREEMPT_RT

2020-07-02 Thread Paul E. McKenney
On Thu, Jul 02, 2020 at 04:12:16PM +0200, Sebastian Andrzej Siewior wrote: > On 2020-06-30 11:35:34 [-0700], Paul E. McKenney wrote: > > > This is not going to work together with the "wait context validator" > > > (CONFIG_PROVE_RAW_LOCK_NESTING). As of -rc3 it should complain about > > > printk()

Re: [PATCH tip/core/rcu 03/17] rcu/tree: Skip entry into the page allocator for PREEMPT_RT

2020-07-02 Thread Sebastian Andrzej Siewior
On 2020-06-30 11:35:34 [-0700], Paul E. McKenney wrote: > > This is not going to work together with the "wait context validator" > > (CONFIG_PROVE_RAW_LOCK_NESTING). As of -rc3 it should complain about > > printk() which is why it is still disabled by default. > > Fixing that should be

Re: [PATCH tip/core/rcu 03/17] rcu/tree: Skip entry into the page allocator for PREEMPT_RT

2020-06-30 Thread Paul E. McKenney
On Tue, Jun 30, 2020 at 06:45:43PM +0200, Sebastian Andrzej Siewior wrote: > On 2020-06-24 13:12:12 [-0700], paul...@kernel.org wrote: > > From: "Joel Fernandes (Google)" > > > > To keep the kfree_rcu() code working in purely atomic sections on RT, > > such as non-threaded IRQ handlers and raw

Re: [PATCH tip/core/rcu 03/17] rcu/tree: Skip entry into the page allocator for PREEMPT_RT

2020-06-30 Thread Sebastian Andrzej Siewior
On 2020-06-24 13:12:12 [-0700], paul...@kernel.org wrote: > From: "Joel Fernandes (Google)" > > To keep the kfree_rcu() code working in purely atomic sections on RT, > such as non-threaded IRQ handlers and raw spinlock sections, avoid > calling into the page allocator which uses sleeping locks

[PATCH tip/core/rcu 03/17] rcu/tree: Skip entry into the page allocator for PREEMPT_RT

2020-06-24 Thread paulmck
From: "Joel Fernandes (Google)" To keep the kfree_rcu() code working in purely atomic sections on RT, such as non-threaded IRQ handlers and raw spinlock sections, avoid calling into the page allocator which uses sleeping locks on RT. In fact, even if the caller is preemptible, the kfree_rcu()