Re: [PATCH v10 3/8] i2c: thunderx: Add i2c driver for ThunderX SOC

2016-08-23 Thread Jan Glauber
On Tue, Aug 23, 2016 at 10:39:41PM +0200, Wolfram Sang wrote: > On Tue, Aug 23, 2016 at 10:36:29PM +0200, Wolfram Sang wrote: > > > > > i2c-octeon-objs := i2c-cavium.o i2c-octeon-core.o > > > obj-$(CONFIG_I2C_OCTEON) += i2c-octeon.o > > > +i2c-thunderx-objs := i2c-cavium.o i2c-thunderx-core.o >

Re: [PATCH v10 3/8] i2c: thunderx: Add i2c driver for ThunderX SOC

2016-08-23 Thread Jan Glauber
On Tue, Aug 23, 2016 at 10:36:29PM +0200, Wolfram Sang wrote: > > > i2c-octeon-objs := i2c-cavium.o i2c-octeon-core.o > > obj-$(CONFIG_I2C_OCTEON) += i2c-octeon.o > > +i2c-thunderx-objs := i2c-cavium.o i2c-thunderx-core.o > > +obj-$(CONFIG_I2C_THUNDERX) += i2c-thunderx.o > > Shouldn't that ra

Re: [PATCH v10 3/8] i2c: thunderx: Add i2c driver for ThunderX SOC

2016-08-23 Thread Wolfram Sang
On Tue, Aug 23, 2016 at 10:36:29PM +0200, Wolfram Sang wrote: > > > i2c-octeon-objs := i2c-cavium.o i2c-octeon-core.o > > obj-$(CONFIG_I2C_OCTEON) += i2c-octeon.o > > +i2c-thunderx-objs := i2c-cavium.o i2c-thunderx-core.o > > +obj-$(CONFIG_I2C_THUNDERX) += i2c-thunderx.o > > Shouldn't that ra

Re: [PATCH v10 3/8] i2c: thunderx: Add i2c driver for ThunderX SOC

2016-08-23 Thread Wolfram Sang
> i2c-octeon-objs := i2c-cavium.o i2c-octeon-core.o > obj-$(CONFIG_I2C_OCTEON) += i2c-octeon.o > +i2c-thunderx-objs := i2c-cavium.o i2c-thunderx-core.o > +obj-$(CONFIG_I2C_THUNDERX) += i2c-thunderx.o Shouldn't that rather be "i2c-cavium-core.o", "i2c-octeon-platdrv.o", and "i2c-thunderx-p

[PATCH v10 3/8] i2c: thunderx: Add i2c driver for ThunderX SOC

2016-06-15 Thread Jan Glauber
The ThunderX SOC uses the same i2c block as the Octeon SOC. The main difference is that on ThunderX the device is a PCI device so device probing is done via PCI, interrupts are MSI-X. The clock rates can be set via device tree or ACPI. Signed-off-by: Jan Glauber --- drivers/i2c/busses/Kconfig