Re: [PATCH v11 8/8] perf: ARM DynamIQ Shared Unit PMU support

2018-03-19 Thread Suzuki K Poulose
On 07/03/18 21:36, Saravana Kannan wrote: On 03/07/2018 06:59 AM, Suzuki K Poulose wrote: Hi Saravana, Sorry for the late response, I was out on vacation. On 05/03/18 22:10, Saravana Kannan wrote: On 03/05/2018 02:59 AM, Mark Rutland wrote: On Fri, Mar 02, 2018 at 11:19:56AM -0800,

Re: [PATCH v11 8/8] perf: ARM DynamIQ Shared Unit PMU support

2018-03-19 Thread Suzuki K Poulose
On 07/03/18 21:36, Saravana Kannan wrote: On 03/07/2018 06:59 AM, Suzuki K Poulose wrote: Hi Saravana, Sorry for the late response, I was out on vacation. On 05/03/18 22:10, Saravana Kannan wrote: On 03/05/2018 02:59 AM, Mark Rutland wrote: On Fri, Mar 02, 2018 at 11:19:56AM -0800,

Re: [PATCH v11 8/8] perf: ARM DynamIQ Shared Unit PMU support

2018-03-10 Thread Mark Rutland
On Fri, Mar 09, 2018 at 02:49:00PM -0800, Saravana Kannan wrote: > > > > Looking at the code, I didn't see any specific handling of cluster > > > > power collapse. AFAIK, the HW counters do not retain config (what event > > > > they are counting) or value (the current count) across power collapse.

Re: [PATCH v11 8/8] perf: ARM DynamIQ Shared Unit PMU support

2018-03-10 Thread Mark Rutland
On Fri, Mar 09, 2018 at 02:49:00PM -0800, Saravana Kannan wrote: > > > > Looking at the code, I didn't see any specific handling of cluster > > > > power collapse. AFAIK, the HW counters do not retain config (what event > > > > they are counting) or value (the current count) across power collapse.

Re: [PATCH v11 8/8] perf: ARM DynamIQ Shared Unit PMU support

2018-03-09 Thread Saravana Kannan
On 03/09/2018 05:35 AM, Mark Rutland wrote: On Fri, Mar 09, 2018 at 10:53:14AM +, Suzuki K Poulose wrote: + Cc: Lorenzo, Charles. On 08/03/18 23:59, Saravana Kannan wrote: On 01/02/2018 03:25 AM, Suzuki K Poulose wrote: Add support for the Cluster PMU part of the ARM DynamIQ Shared Unit

Re: [PATCH v11 8/8] perf: ARM DynamIQ Shared Unit PMU support

2018-03-09 Thread Saravana Kannan
On 03/09/2018 05:35 AM, Mark Rutland wrote: On Fri, Mar 09, 2018 at 10:53:14AM +, Suzuki K Poulose wrote: + Cc: Lorenzo, Charles. On 08/03/18 23:59, Saravana Kannan wrote: On 01/02/2018 03:25 AM, Suzuki K Poulose wrote: Add support for the Cluster PMU part of the ARM DynamIQ Shared Unit

Re: [PATCH v11 8/8] perf: ARM DynamIQ Shared Unit PMU support

2018-03-09 Thread Mark Rutland
On Fri, Mar 09, 2018 at 10:53:14AM +, Suzuki K Poulose wrote: > + Cc: Lorenzo, Charles. > > On 08/03/18 23:59, Saravana Kannan wrote: > > On 01/02/2018 03:25 AM, Suzuki K Poulose wrote: > > > Add support for the Cluster PMU part of the ARM DynamIQ Shared Unit (DSU). > > > The DSU integrates

Re: [PATCH v11 8/8] perf: ARM DynamIQ Shared Unit PMU support

2018-03-09 Thread Mark Rutland
On Fri, Mar 09, 2018 at 10:53:14AM +, Suzuki K Poulose wrote: > + Cc: Lorenzo, Charles. > > On 08/03/18 23:59, Saravana Kannan wrote: > > On 01/02/2018 03:25 AM, Suzuki K Poulose wrote: > > > Add support for the Cluster PMU part of the ARM DynamIQ Shared Unit (DSU). > > > The DSU integrates

Re: [PATCH v11 8/8] perf: ARM DynamIQ Shared Unit PMU support

2018-03-09 Thread Suzuki K Poulose
+ Cc: Lorenzo, Charles. On 08/03/18 23:59, Saravana Kannan wrote: On 01/02/2018 03:25 AM, Suzuki K Poulose wrote: Add support for the Cluster PMU part of the ARM DynamIQ Shared Unit (DSU). The DSU integrates one or more cores with an L3 memory system, control logic, and external interfaces to

Re: [PATCH v11 8/8] perf: ARM DynamIQ Shared Unit PMU support

2018-03-09 Thread Suzuki K Poulose
+ Cc: Lorenzo, Charles. On 08/03/18 23:59, Saravana Kannan wrote: On 01/02/2018 03:25 AM, Suzuki K Poulose wrote: Add support for the Cluster PMU part of the ARM DynamIQ Shared Unit (DSU). The DSU integrates one or more cores with an L3 memory system, control logic, and external interfaces to

Re: [PATCH v11 8/8] perf: ARM DynamIQ Shared Unit PMU support

2018-03-08 Thread Saravana Kannan
On 01/02/2018 03:25 AM, Suzuki K Poulose wrote: Add support for the Cluster PMU part of the ARM DynamIQ Shared Unit (DSU). The DSU integrates one or more cores with an L3 memory system, control logic, and external interfaces to form a multicore cluster. The PMU allows counting the various events

Re: [PATCH v11 8/8] perf: ARM DynamIQ Shared Unit PMU support

2018-03-08 Thread Saravana Kannan
On 01/02/2018 03:25 AM, Suzuki K Poulose wrote: Add support for the Cluster PMU part of the ARM DynamIQ Shared Unit (DSU). The DSU integrates one or more cores with an L3 memory system, control logic, and external interfaces to form a multicore cluster. The PMU allows counting the various events

Re: [PATCH v11 8/8] perf: ARM DynamIQ Shared Unit PMU support

2018-03-08 Thread Mark Rutland
On Mon, Mar 05, 2018 at 02:10:03PM -0800, Saravana Kannan wrote: > On 03/05/2018 02:59 AM, Mark Rutland wrote: > > On Fri, Mar 02, 2018 at 11:19:56AM -0800, Saravana Kannan wrote: > > > On 03/02/2018 02:42 AM, Mark Rutland wrote: > > > > It's important to note that the DSU PMU's event_init()

Re: [PATCH v11 8/8] perf: ARM DynamIQ Shared Unit PMU support

2018-03-08 Thread Mark Rutland
On Mon, Mar 05, 2018 at 02:10:03PM -0800, Saravana Kannan wrote: > On 03/05/2018 02:59 AM, Mark Rutland wrote: > > On Fri, Mar 02, 2018 at 11:19:56AM -0800, Saravana Kannan wrote: > > > On 03/02/2018 02:42 AM, Mark Rutland wrote: > > > > It's important to note that the DSU PMU's event_init()

Re: [PATCH v11 8/8] perf: ARM DynamIQ Shared Unit PMU support

2018-03-07 Thread Saravana Kannan
On 03/07/2018 06:59 AM, Suzuki K Poulose wrote: Hi Saravana, Sorry for the late response, I was out on vacation. On 05/03/18 22:10, Saravana Kannan wrote: On 03/05/2018 02:59 AM, Mark Rutland wrote: On Fri, Mar 02, 2018 at 11:19:56AM -0800, Saravana Kannan wrote: On 03/02/2018 02:42 AM,

Re: [PATCH v11 8/8] perf: ARM DynamIQ Shared Unit PMU support

2018-03-07 Thread Saravana Kannan
On 03/07/2018 06:59 AM, Suzuki K Poulose wrote: Hi Saravana, Sorry for the late response, I was out on vacation. On 05/03/18 22:10, Saravana Kannan wrote: On 03/05/2018 02:59 AM, Mark Rutland wrote: On Fri, Mar 02, 2018 at 11:19:56AM -0800, Saravana Kannan wrote: On 03/02/2018 02:42 AM,

Re: [PATCH v11 8/8] perf: ARM DynamIQ Shared Unit PMU support

2018-03-07 Thread Suzuki K Poulose
Hi Saravana, Sorry for the late response, I was out on vacation. On 05/03/18 22:10, Saravana Kannan wrote: On 03/05/2018 02:59 AM, Mark Rutland wrote: On Fri, Mar 02, 2018 at 11:19:56AM -0800, Saravana Kannan wrote: On 03/02/2018 02:42 AM, Mark Rutland wrote: It's important to note that

Re: [PATCH v11 8/8] perf: ARM DynamIQ Shared Unit PMU support

2018-03-07 Thread Suzuki K Poulose
Hi Saravana, Sorry for the late response, I was out on vacation. On 05/03/18 22:10, Saravana Kannan wrote: On 03/05/2018 02:59 AM, Mark Rutland wrote: On Fri, Mar 02, 2018 at 11:19:56AM -0800, Saravana Kannan wrote: On 03/02/2018 02:42 AM, Mark Rutland wrote: It's important to note that

Re: [PATCH v11 8/8] perf: ARM DynamIQ Shared Unit PMU support

2018-03-05 Thread Saravana Kannan
On 03/05/2018 02:59 AM, Mark Rutland wrote: On Fri, Mar 02, 2018 at 11:19:56AM -0800, Saravana Kannan wrote: On 03/02/2018 02:42 AM, Mark Rutland wrote: It's important to note that the DSU PMU's event_init() ensures events are affine to a single CPU, and the perf core code serializes

Re: [PATCH v11 8/8] perf: ARM DynamIQ Shared Unit PMU support

2018-03-05 Thread Saravana Kannan
On 03/05/2018 02:59 AM, Mark Rutland wrote: On Fri, Mar 02, 2018 at 11:19:56AM -0800, Saravana Kannan wrote: On 03/02/2018 02:42 AM, Mark Rutland wrote: It's important to note that the DSU PMU's event_init() ensures events are affine to a single CPU, and the perf core code serializes

Re: [PATCH v11 8/8] perf: ARM DynamIQ Shared Unit PMU support

2018-03-05 Thread Mark Rutland
On Fri, Mar 02, 2018 at 11:19:56AM -0800, Saravana Kannan wrote: > On 03/02/2018 02:42 AM, Mark Rutland wrote: > > It's important to note that the DSU PMU's event_init() ensures events > > are affine to a single CPU, and the perf core code serializes operations > > on those events via the context

Re: [PATCH v11 8/8] perf: ARM DynamIQ Shared Unit PMU support

2018-03-05 Thread Mark Rutland
On Fri, Mar 02, 2018 at 11:19:56AM -0800, Saravana Kannan wrote: > On 03/02/2018 02:42 AM, Mark Rutland wrote: > > It's important to note that the DSU PMU's event_init() ensures events > > are affine to a single CPU, and the perf core code serializes operations > > on those events via the context

Re: [PATCH v11 8/8] perf: ARM DynamIQ Shared Unit PMU support

2018-03-02 Thread Saravana Kannan
On 03/02/2018 02:42 AM, Mark Rutland wrote: On Thu, Mar 01, 2018 at 12:35:49PM -0800, Saravana Kannan wrote: On 03/01/2018 03:49 AM, Mark Rutland wrote: On Wed, Feb 28, 2018 at 02:17:33PM -0800, Saravana Kannan wrote: On 02/25/2018 06:36 AM, Mark Rutland wrote: On Fri, Feb 23, 2018 at

Re: [PATCH v11 8/8] perf: ARM DynamIQ Shared Unit PMU support

2018-03-02 Thread Saravana Kannan
On 03/02/2018 02:42 AM, Mark Rutland wrote: On Thu, Mar 01, 2018 at 12:35:49PM -0800, Saravana Kannan wrote: On 03/01/2018 03:49 AM, Mark Rutland wrote: On Wed, Feb 28, 2018 at 02:17:33PM -0800, Saravana Kannan wrote: On 02/25/2018 06:36 AM, Mark Rutland wrote: On Fri, Feb 23, 2018 at

Re: [PATCH v11 8/8] perf: ARM DynamIQ Shared Unit PMU support

2018-03-02 Thread Mark Rutland
On Thu, Mar 01, 2018 at 12:35:49PM -0800, Saravana Kannan wrote: > On 03/01/2018 03:49 AM, Mark Rutland wrote: > > On Wed, Feb 28, 2018 at 02:17:33PM -0800, Saravana Kannan wrote: > > > On 02/25/2018 06:36 AM, Mark Rutland wrote: > > > > On Fri, Feb 23, 2018 at 04:53:18PM -0800, Saravana Kannan

Re: [PATCH v11 8/8] perf: ARM DynamIQ Shared Unit PMU support

2018-03-02 Thread Mark Rutland
On Thu, Mar 01, 2018 at 12:35:49PM -0800, Saravana Kannan wrote: > On 03/01/2018 03:49 AM, Mark Rutland wrote: > > On Wed, Feb 28, 2018 at 02:17:33PM -0800, Saravana Kannan wrote: > > > On 02/25/2018 06:36 AM, Mark Rutland wrote: > > > > On Fri, Feb 23, 2018 at 04:53:18PM -0800, Saravana Kannan

Re: [PATCH v11 8/8] perf: ARM DynamIQ Shared Unit PMU support

2018-03-01 Thread Saravana Kannan
On 03/01/2018 03:49 AM, Mark Rutland wrote: On Wed, Feb 28, 2018 at 02:17:33PM -0800, Saravana Kannan wrote: On 02/25/2018 06:36 AM, Mark Rutland wrote: On Fri, Feb 23, 2018 at 04:53:18PM -0800, Saravana Kannan wrote: On 01/02/2018 03:25 AM, Suzuki K Poulose wrote: +static void

Re: [PATCH v11 8/8] perf: ARM DynamIQ Shared Unit PMU support

2018-03-01 Thread Saravana Kannan
On 03/01/2018 03:49 AM, Mark Rutland wrote: On Wed, Feb 28, 2018 at 02:17:33PM -0800, Saravana Kannan wrote: On 02/25/2018 06:36 AM, Mark Rutland wrote: On Fri, Feb 23, 2018 at 04:53:18PM -0800, Saravana Kannan wrote: On 01/02/2018 03:25 AM, Suzuki K Poulose wrote: +static void

Re: [PATCH v11 8/8] perf: ARM DynamIQ Shared Unit PMU support

2018-03-01 Thread Mark Rutland
On Wed, Feb 28, 2018 at 02:17:33PM -0800, Saravana Kannan wrote: > On 02/25/2018 06:36 AM, Mark Rutland wrote: > > On Fri, Feb 23, 2018 at 04:53:18PM -0800, Saravana Kannan wrote: > > > On 01/02/2018 03:25 AM, Suzuki K Poulose wrote: > > > > +static void dsu_pmu_event_update(struct perf_event

Re: [PATCH v11 8/8] perf: ARM DynamIQ Shared Unit PMU support

2018-03-01 Thread Mark Rutland
On Wed, Feb 28, 2018 at 02:17:33PM -0800, Saravana Kannan wrote: > On 02/25/2018 06:36 AM, Mark Rutland wrote: > > On Fri, Feb 23, 2018 at 04:53:18PM -0800, Saravana Kannan wrote: > > > On 01/02/2018 03:25 AM, Suzuki K Poulose wrote: > > > > +static void dsu_pmu_event_update(struct perf_event

Re: [PATCH v11 8/8] perf: ARM DynamIQ Shared Unit PMU support

2018-02-28 Thread Saravana Kannan
On 02/25/2018 06:36 AM, Mark Rutland wrote: On Fri, Feb 23, 2018 at 04:53:18PM -0800, Saravana Kannan wrote: On 01/02/2018 03:25 AM, Suzuki K Poulose wrote: +static void dsu_pmu_event_update(struct perf_event *event) +{ + struct hw_perf_event *hwc = >hw; + u64 delta, prev_count,

Re: [PATCH v11 8/8] perf: ARM DynamIQ Shared Unit PMU support

2018-02-28 Thread Saravana Kannan
On 02/25/2018 06:36 AM, Mark Rutland wrote: On Fri, Feb 23, 2018 at 04:53:18PM -0800, Saravana Kannan wrote: On 01/02/2018 03:25 AM, Suzuki K Poulose wrote: +static void dsu_pmu_event_update(struct perf_event *event) +{ + struct hw_perf_event *hwc = >hw; + u64 delta, prev_count,

Re: [PATCH v11 8/8] perf: ARM DynamIQ Shared Unit PMU support

2018-02-25 Thread Mark Rutland
On Fri, Feb 23, 2018 at 04:53:18PM -0800, Saravana Kannan wrote: > On 01/02/2018 03:25 AM, Suzuki K Poulose wrote: > > +static void dsu_pmu_event_update(struct perf_event *event) > > +{ > > + struct hw_perf_event *hwc = >hw; > > + u64 delta, prev_count, new_count; > > + > > + do { > > +

Re: [PATCH v11 8/8] perf: ARM DynamIQ Shared Unit PMU support

2018-02-25 Thread Mark Rutland
On Fri, Feb 23, 2018 at 04:53:18PM -0800, Saravana Kannan wrote: > On 01/02/2018 03:25 AM, Suzuki K Poulose wrote: > > +static void dsu_pmu_event_update(struct perf_event *event) > > +{ > > + struct hw_perf_event *hwc = >hw; > > + u64 delta, prev_count, new_count; > > + > > + do { > > +

Re: [PATCH v11 8/8] perf: ARM DynamIQ Shared Unit PMU support

2018-02-23 Thread Saravana Kannan
On 01/02/2018 03:25 AM, Suzuki K Poulose wrote: Add support for the Cluster PMU part of the ARM DynamIQ Shared Unit (DSU). The DSU integrates one or more cores with an L3 memory system, control logic, and external interfaces to form a multicore cluster. The PMU allows counting the various events

Re: [PATCH v11 8/8] perf: ARM DynamIQ Shared Unit PMU support

2018-02-23 Thread Saravana Kannan
On 01/02/2018 03:25 AM, Suzuki K Poulose wrote: Add support for the Cluster PMU part of the ARM DynamIQ Shared Unit (DSU). The DSU integrates one or more cores with an L3 memory system, control logic, and external interfaces to form a multicore cluster. The PMU allows counting the various events

Re: [PATCH v11 8/8] perf: ARM DynamIQ Shared Unit PMU support

2018-02-23 Thread Saravana Kannan
On 02/23/2018 03:35 AM, Mark Rutland wrote: On Thu, Feb 22, 2018 at 12:38:39PM -0800, Saravana Kannan wrote: On 02/22/2018 03:33 AM, Mark Rutland wrote: On Wed, Feb 21, 2018 at 06:32:46PM -0800, Saravana Kannan wrote: I'm not exactly sure if we can add entries to perf_type_id. If that's

Re: [PATCH v11 8/8] perf: ARM DynamIQ Shared Unit PMU support

2018-02-23 Thread Saravana Kannan
On 02/23/2018 03:35 AM, Mark Rutland wrote: On Thu, Feb 22, 2018 at 12:38:39PM -0800, Saravana Kannan wrote: On 02/22/2018 03:33 AM, Mark Rutland wrote: On Wed, Feb 21, 2018 at 06:32:46PM -0800, Saravana Kannan wrote: I'm not exactly sure if we can add entries to perf_type_id. If that's

Re: [PATCH v11 8/8] perf: ARM DynamIQ Shared Unit PMU support

2018-02-23 Thread Mark Rutland
On Thu, Feb 22, 2018 at 12:38:39PM -0800, Saravana Kannan wrote: > On 02/22/2018 03:33 AM, Mark Rutland wrote: > > On Wed, Feb 21, 2018 at 06:32:46PM -0800, Saravana Kannan wrote: > > > I'm not exactly sure if we can add entries to perf_type_id. If that's > > > allowed maybe we need to add

Re: [PATCH v11 8/8] perf: ARM DynamIQ Shared Unit PMU support

2018-02-23 Thread Mark Rutland
On Thu, Feb 22, 2018 at 12:38:39PM -0800, Saravana Kannan wrote: > On 02/22/2018 03:33 AM, Mark Rutland wrote: > > On Wed, Feb 21, 2018 at 06:32:46PM -0800, Saravana Kannan wrote: > > > I'm not exactly sure if we can add entries to perf_type_id. If that's > > > allowed maybe we need to add

Re: [PATCH v11 8/8] perf: ARM DynamIQ Shared Unit PMU support

2018-02-22 Thread Saravana Kannan
On 02/22/2018 03:33 AM, Mark Rutland wrote: On Wed, Feb 21, 2018 at 06:32:46PM -0800, Saravana Kannan wrote: On 01/02/2018 03:25 AM, Suzuki K Poulose wrote: +static int dsu_pmu_event_init(struct perf_event *event) +{ + struct dsu_pmu *dsu_pmu = to_dsu_pmu(event->pmu); + + if

Re: [PATCH v11 8/8] perf: ARM DynamIQ Shared Unit PMU support

2018-02-22 Thread Saravana Kannan
On 02/22/2018 03:33 AM, Mark Rutland wrote: On Wed, Feb 21, 2018 at 06:32:46PM -0800, Saravana Kannan wrote: On 01/02/2018 03:25 AM, Suzuki K Poulose wrote: +static int dsu_pmu_event_init(struct perf_event *event) +{ + struct dsu_pmu *dsu_pmu = to_dsu_pmu(event->pmu); + + if

Re: [PATCH v11 8/8] perf: ARM DynamIQ Shared Unit PMU support

2018-02-22 Thread Mark Rutland
On Wed, Feb 21, 2018 at 06:32:46PM -0800, Saravana Kannan wrote: > On 01/02/2018 03:25 AM, Suzuki K Poulose wrote: > > +static int dsu_pmu_event_init(struct perf_event *event) > > +{ > > + struct dsu_pmu *dsu_pmu = to_dsu_pmu(event->pmu); > > + > > + if (event->attr.type != event->pmu->type) >

Re: [PATCH v11 8/8] perf: ARM DynamIQ Shared Unit PMU support

2018-02-22 Thread Mark Rutland
On Wed, Feb 21, 2018 at 06:32:46PM -0800, Saravana Kannan wrote: > On 01/02/2018 03:25 AM, Suzuki K Poulose wrote: > > +static int dsu_pmu_event_init(struct perf_event *event) > > +{ > > + struct dsu_pmu *dsu_pmu = to_dsu_pmu(event->pmu); > > + > > + if (event->attr.type != event->pmu->type) >

Re: [PATCH v11 8/8] perf: ARM DynamIQ Shared Unit PMU support

2018-02-21 Thread Saravana Kannan
On 01/02/2018 03:25 AM, Suzuki K Poulose wrote: Add support for the Cluster PMU part of the ARM DynamIQ Shared Unit (DSU). The DSU integrates one or more cores with an L3 memory system, control logic, and external interfaces to form a multicore cluster. The PMU allows counting the various events

Re: [PATCH v11 8/8] perf: ARM DynamIQ Shared Unit PMU support

2018-02-21 Thread Saravana Kannan
On 01/02/2018 03:25 AM, Suzuki K Poulose wrote: Add support for the Cluster PMU part of the ARM DynamIQ Shared Unit (DSU). The DSU integrates one or more cores with an L3 memory system, control logic, and external interfaces to form a multicore cluster. The PMU allows counting the various events

[PATCH v11 8/8] perf: ARM DynamIQ Shared Unit PMU support

2018-01-02 Thread Suzuki K Poulose
Add support for the Cluster PMU part of the ARM DynamIQ Shared Unit (DSU). The DSU integrates one or more cores with an L3 memory system, control logic, and external interfaces to form a multicore cluster. The PMU allows counting the various events related to L3, SCU etc, along with providing a

[PATCH v11 8/8] perf: ARM DynamIQ Shared Unit PMU support

2018-01-02 Thread Suzuki K Poulose
Add support for the Cluster PMU part of the ARM DynamIQ Shared Unit (DSU). The DSU integrates one or more cores with an L3 memory system, control logic, and external interfaces to form a multicore cluster. The PMU allows counting the various events related to L3, SCU etc, along with providing a