Re: [PATCH v12 13/14] cpufreq: qcom: Re-organise kryo cpufreq to use it for other nvmem based qcom socs

2018-08-20 Thread Sricharan R
Hi Rob, On 8/17/2018 8:39 PM, Rob Herring wrote: > Hi, this email is from Rob's (experimental) review bot. I found a couple > of common problems with your patch. Please see below. > > On Tue, 14 Aug 2018 17:42:32 +0530, Sricharan R wrote: >> The kryo cpufreq driver reads the nvmem cell and uses

Re: [PATCH v12 13/14] cpufreq: qcom: Re-organise kryo cpufreq to use it for other nvmem based qcom socs

2018-08-20 Thread Sricharan R
Hi Rob, On 8/17/2018 8:39 PM, Rob Herring wrote: > Hi, this email is from Rob's (experimental) review bot. I found a couple > of common problems with your patch. Please see below. > > On Tue, 14 Aug 2018 17:42:32 +0530, Sricharan R wrote: >> The kryo cpufreq driver reads the nvmem cell and uses

Re: [PATCH v12 13/14] cpufreq: qcom: Re-organise kryo cpufreq to use it for other nvmem based qcom socs

2018-08-17 Thread Rob Herring
Hi, this email is from Rob's (experimental) review bot. I found a couple of common problems with your patch. Please see below. On Tue, 14 Aug 2018 17:42:32 +0530, Sricharan R wrote: > The kryo cpufreq driver reads the nvmem cell and uses that data to > populate the opps. There are other qcom

Re: [PATCH v12 13/14] cpufreq: qcom: Re-organise kryo cpufreq to use it for other nvmem based qcom socs

2018-08-17 Thread Rob Herring
Hi, this email is from Rob's (experimental) review bot. I found a couple of common problems with your patch. Please see below. On Tue, 14 Aug 2018 17:42:32 +0530, Sricharan R wrote: > The kryo cpufreq driver reads the nvmem cell and uses that data to > populate the opps. There are other qcom

[PATCH v12 13/14] cpufreq: qcom: Re-organise kryo cpufreq to use it for other nvmem based qcom socs

2018-08-14 Thread Sricharan R
The kryo cpufreq driver reads the nvmem cell and uses that data to populate the opps. There are other qcom cpufreq socs like krait which does similar thing. Except for the interpretation of the read data, rest of the driver is same for both the cases. So pull the common things out for reuse.

[PATCH v12 13/14] cpufreq: qcom: Re-organise kryo cpufreq to use it for other nvmem based qcom socs

2018-08-14 Thread Sricharan R
The kryo cpufreq driver reads the nvmem cell and uses that data to populate the opps. There are other qcom cpufreq socs like krait which does similar thing. Except for the interpretation of the read data, rest of the driver is same for both the cases. So pull the common things out for reuse.