Re: [PATCH v2] bpf, i386: remove unneeded conversion to bool

2020-05-07 Thread Daniel Borkmann
On 5/7/20 12:04 AM, Martin KaFai Lau wrote: On Wed, May 06, 2020 at 10:03:52PM +0800, Jason Yan wrote: The '==' expression itself is bool, no need to convert it to bool again. This fixes the following coccicheck warning: Make sense. It may belong to bpf-next instead. Acked-by: Martin KaFai

Re: [PATCH v2] bpf, i386: remove unneeded conversion to bool

2020-05-06 Thread Martin KaFai Lau
On Wed, May 06, 2020 at 10:03:52PM +0800, Jason Yan wrote: > The '==' expression itself is bool, no need to convert it to bool again. > This fixes the following coccicheck warning: Make sense. It may belong to bpf-next instead. Acked-by: Martin KaFai Lau

Re: [PATCH v2] bpf, i386: remove unneeded conversion to bool

2020-05-06 Thread hpa
On May 6, 2020 7:03:52 AM PDT, Jason Yan wrote: >The '==' expression itself is bool, no need to convert it to bool >again. >This fixes the following coccicheck warning: > >arch/x86/net/bpf_jit_comp32.c:1478:50-55: WARNING: conversion to bool >not needed here

[PATCH v2] bpf, i386: remove unneeded conversion to bool

2020-05-06 Thread Jason Yan
The '==' expression itself is bool, no need to convert it to bool again. This fixes the following coccicheck warning: arch/x86/net/bpf_jit_comp32.c:1478:50-55: WARNING: conversion to bool not needed here arch/x86/net/bpf_jit_comp32.c:1479:50-55: WARNING: conversion to bool not needed here